diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-05-07 11:49:46 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-05-07 11:49:46 +0200 |
| commit | 93f5d5a9190e0e03bf4822663652a4b068c44f75 (patch) | |
| tree | 9ac61601b056acad6a6c83d728c684661d3f3271 /vcl/source/helper | |
| parent | c6fdd34c16f415629222348631141c3e13af6d4a (diff) | |
The opaque PostUserEvent IDs are actually pointers
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
Diffstat (limited to 'vcl/source/helper')
| -rw-r--r-- | vcl/source/helper/threadex.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/source/helper/threadex.cxx b/vcl/source/helper/threadex.cxx index 85fe63c1736f..37d8ef892a9b 100644 --- a/vcl/source/helper/threadex.cxx +++ b/vcl/source/helper/threadex.cxx @@ -60,7 +60,7 @@ long SolarThreadExecutor::impl_execute( const TimeValue* _pTimeout ) osl_resetCondition( m_aStart ); osl_resetCondition( m_aFinish ); sal_uLong nSolarMutexCount = Application::ReleaseSolarMutex(); - sal_uLong nEvent = Application::PostUserEvent( LINK( this, SolarThreadExecutor, worker ) ); + ImplSVEvent * nEvent = Application::PostUserEvent( LINK( this, SolarThreadExecutor, worker ) ); if ( osl_cond_result_timeout == osl_waitCondition( m_aStart, _pTimeout ) ) { m_bTimeout = true; |