diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-05-03 14:09:20 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-05-03 15:32:53 +0200 |
commit | c5a0b7af847a71fd50f713934b29305f8ce96c6b (patch) | |
tree | d7c0193bc183250c36e467f830a4327ab94dc24e /vcl/source/uitest | |
parent | d19dbcc139d18771e5e20e82a694f1512476e41c (diff) |
loplugin:stringadd improvement for appending numbers
I was wrong, the Concat framework already optimised appending
numbers by stack-allocating small buffers, so include
them in the plugin
Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/source/uitest')
-rw-r--r-- | vcl/source/uitest/logger.cxx | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/vcl/source/uitest/logger.cxx b/vcl/source/uitest/logger.cxx index 8c23eb8b1cb2..6b3eed64f849 100644 --- a/vcl/source/uitest/logger.cxx +++ b/vcl/source/uitest/logger.cxx @@ -99,15 +99,13 @@ void UITestLogger::logCommand(const OUString& rAction, { sal_Int32 nValue = 0; rProp.Value >>= nValue; - aBuffer.append("\"" + rProp.Name + "\": "); - aBuffer.append(nValue).append(", "); + aBuffer.append("\"" + rProp.Name + "\": " + OUString::number(nValue) + ", "); } else if (aTypeName == "unsigned long") { sal_uInt32 nValue = 0; rProp.Value >>= nValue; - aBuffer.append("\"" + rProp.Name + "\": "); - aBuffer.append(static_cast<sal_Int64>(nValue)).append(", "); + aBuffer.append("\"" + rProp.Name + "\": " + OUString::number(nValue) + ", "); } else if (aTypeName == "boolean") { |