diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-11-12 08:13:40 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-11-12 16:53:30 +0100 |
| commit | f34ac579fac16fff37bf00fe85d43ad6b938eca7 (patch) | |
| tree | 0747c4d86bbf40a5093fb7a3215dd52a8e8586b2 /vcl/source/window/builder.cxx | |
| parent | c45753847dfc2b4645dc2f7500a18ec2c5d438df (diff) | |
New loplugin:stringviewparam
...to "Find functions that take rtl::O[U]String parameters that can be
generalized to take std::[u16]string_view instead." (Which in turn can avoid
costly O[U]String constructions, see e.g. loplugin:stringview and subView.)
Some of those functions' call sites, passing plain char string literals, needed
to be adapted when converting them.
Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'vcl/source/window/builder.cxx')
| -rw-r--r-- | vcl/source/window/builder.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index 3e9200df6d2e..c1163335aaff 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -11,6 +11,7 @@ #include <config_options.h> #include <memory> +#include <string_view> #include <unordered_map> #include <com/sun/star/accessibility/AccessibleRole.hpp> @@ -76,9 +77,9 @@ #include <dlfcn.h> #endif -static bool toBool(const OString &rValue) +static bool toBool(std::string_view rValue) { - return (!rValue.isEmpty() && (rValue[0] == 't' || rValue[0] == 'T' || rValue[0] == '1')); + return (!rValue.empty() && (rValue[0] == 't' || rValue[0] == 'T' || rValue[0] == '1')); } namespace |