diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2019-10-18 16:02:57 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2019-10-19 17:33:04 +0200 |
| commit | 4bc377da92e83192facb736d8dadc32891f99e25 (patch) | |
| tree | 3710d97862f8a2337c48c1525563afd6be3b994d /vcl/source/window/menu.cxx | |
| parent | fbe12462aaa98d9ea820908af1e7436d4590e698 (diff) | |
only warn if it would make a difference
Change-Id: I7ee9ccb2444fc63b2d32520907f502ae596c984d
Reviewed-on: https://gerrit.libreoffice.org/81067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/source/window/menu.cxx')
| -rw-r--r-- | vcl/source/window/menu.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index c1502e891a84..34ceee0069aa 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -950,7 +950,7 @@ void Menu::ShowItem( sal_uInt16 nItemId, bool bVisible ) size_t nPos; MenuItemData* pData = pItemList->GetData( nItemId, nPos ); - SAL_WARN_IF(IsMenuBar(), "vcl", "Menu::ShowItem - ignored for menu bar entries!"); + SAL_WARN_IF(IsMenuBar() && !bVisible , "vcl", "Menu::ShowItem - ignored for menu bar entries!"); if (!IsMenuBar()&& pData && (pData->bVisible != bVisible)) { vcl::Window* pWin = ImplGetWindow(); @@ -1463,7 +1463,6 @@ Size Menu::ImplCalcSize( vcl::Window* pWin ) // Separator if (!IsMenuBar()&& (pData->eType == MenuItemType::SEPARATOR)) { - //Useless: SAL_WARN_IF( IsMenuBar(), "vcl", "Separator in MenuBar ?! " ); pData->aSz.setHeight( 4 ); } |