tdf#127211 Revert "tdf#71087 sfx2: avoid flicker in the start center"

This reverts commit d5c7657c541c1f6d17bfe5e605594c235eecfcdb.

By the time I created that, I forgot to test the case when there are no
recent documents. I'm not exactly sure how to fix that, so just go back
to the old behavior for now (trading a regression for a normal bug).

Change-Id: I8abc251a3e6506ca17429ba106e2dd70fff31556
Reviewed-on: https://gerrit.libreoffice.org/78301
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

1 files changed, 2 insertions, 14 deletions

diff --git a/vcl/source/window/menubarwindow.cxx b/vcl/source/window/menubarwindow.cxx
index e9d93765bb9a..040385d5cf9b 100644
--- a/vcl/source/window/menubarwindow.cxx
+++ b/vcl/source/window/menubarwindow.cxx
@@ -913,20 +913,8 @@ void MenuBarWindow::Paint(vcl::RenderContext& rRenderContext, const tools::Recta
         return;
     }
 
-    vcl::RenderContext* pBuffer = nullptr;
-    std::unique_ptr<vcl::BufferDevice> pBufferDevice;
-    if (SupportsDoubleBuffering())
-    {
-        // No need to buffer twice, just set up the background.
-        pBuffer = &rRenderContext;
-        pBuffer->Erase(tools::Rectangle(Point(GetOutOffXPixel(), GetOutOffYPixel()), GetOutputSizePixel()));
-    }
-    else
-    {
-        // Make sure that all actual rendering happens in one go to avoid flicker.
-        pBufferDevice.reset(new vcl::BufferDevice(this, rRenderContext));
-        pBuffer = &pBufferDevice->GetRenderContext();
-    }
+    // Make sure that all actual rendering happens in one go to avoid flicker.
+    vcl::BufferDevice pBuffer(this, rRenderContext);
 
     if (rRenderContext.IsNativeControlSupported(ControlType::Menubar, ControlPart::Entire))
     {