summaryrefslogtreecommitdiff
path: root/vcl/source/window/stacking.cxx
diff options
context:
space:
mode:
authorCaolán McNamara <caolan.mcnamara@collabora.com>2024-07-04 09:02:06 +0100
committerCaolán McNamara <caolan.mcnamara@collabora.com>2024-07-04 12:58:38 +0200
commita14ef3ee8d34e5a1e31f50eb49b29200feaafa1a (patch)
tree0ecd2883890bb3c3c6930dee8c1db2165593f330 /vcl/source/window/stacking.cxx
parenta6a95c0ce4334fda99cba0528d08207a7514e8a1 (diff)
cid#1607240 silence Copy-paste error
and cid#1607649 Copy-paste error Change-Id: I9b0bfc1b2403ecaa514b6086bc5a4c37b0fdf7ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169981 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Diffstat (limited to 'vcl/source/window/stacking.cxx')
-rw-r--r--vcl/source/window/stacking.cxx6
1 files changed, 6 insertions, 0 deletions
diff --git a/vcl/source/window/stacking.cxx b/vcl/source/window/stacking.cxx
index 84b4efadc27b..034e6d1056a5 100644
--- a/vcl/source/window/stacking.cxx
+++ b/vcl/source/window/stacking.cxx
@@ -200,7 +200,10 @@ void Window::ImplToBottomChild()
if ( mpWindowImpl->mpPrev )
mpWindowImpl->mpPrev->mpWindowImpl->mpNext = mpWindowImpl->mpNext;
else
+ {
+ // coverity[copy_paste_error : FALSE] - this is correct mpFirstChild, not mpNext
mpWindowImpl->mpParent->mpWindowImpl->mpFirstChild = mpWindowImpl->mpNext;
+ }
mpWindowImpl->mpNext->mpWindowImpl->mpPrev = mpWindowImpl->mpPrev;
mpWindowImpl->mpPrev = mpWindowImpl->mpParent->mpWindowImpl->mpLastChild;
mpWindowImpl->mpParent->mpWindowImpl->mpLastChild = this;
@@ -268,7 +271,10 @@ void Window::ImplToTop( ToTopFlags nFlags )
if ( mpWindowImpl->mpNext )
mpWindowImpl->mpNext->mpWindowImpl->mpPrev = mpWindowImpl->mpPrev;
else
+ {
+ // coverity[copy_paste_error : FALSE] - this is correct mpLastOverlap, not mpPrev
mpWindowImpl->mpOverlapWindow->mpWindowImpl->mpLastOverlap = mpWindowImpl->mpPrev;
+ }
// take AlwaysOnTop into account
bool bOnTop = IsAlwaysOnTopEnabled();