summaryrefslogtreecommitdiff
path: root/vcl/source
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2014-10-31 12:12:41 +0000
committerCaolán McNamara <caolanm@redhat.com>2014-10-31 13:04:15 +0000
commit0b32d9dcb86d3b5cc55c24634b39d29980f873a7 (patch)
tree8cc8a5f7907a56fe8fa4310bdc199a997c22905b /vcl/source
parent1c5b25e680bb2f6ebbc90df6c8c9e4529948979e (diff)
coverity#735346 Unchecked return value
Change-Id: Ic9aab232667a9b0a3a995d7b033b7ba508fd42dc
Diffstat (limited to 'vcl/source')
-rw-r--r--vcl/source/gdi/pdfwriter_impl.cxx60
1 files changed, 34 insertions, 26 deletions
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx
index 924260451bc8..a33d7ac382de 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2534,8 +2534,10 @@ OString PDFWriterImpl::emitStructureAttributes( PDFStructureElement& i_rEle )
aRef.append( " 0 R>>\n"
"endobj\n\n"
);
- updateObject( nRefObject );
- writeBuffer( aRef.getStr(), aRef.getLength() );
+ if (updateObject(nRefObject))
+ {
+ writeBuffer( aRef.getStr(), aRef.getLength() );
+ }
i_rEle.m_aKids.push_back( PDFStructureElementKid( nRefObject ) );
}
@@ -2573,38 +2575,44 @@ OString PDFWriterImpl::emitStructureAttributes( PDFStructureElement& i_rEle )
if( !aLayout.isEmpty() )
{
aAttribObjects.push_back( createObject() );
- updateObject( aAttribObjects.back() );
- OStringBuffer aObj( 64 );
- aObj.append( aAttribObjects.back() );
- aObj.append( " 0 obj\n"
- "<</O/Layout\n" );
- aLayout.append( ">>\nendobj\n\n" );
- writeBuffer( aObj.getStr(), aObj.getLength() );
- writeBuffer( aLayout.getStr(), aLayout.getLength() );
+ if (updateObject( aAttribObjects.back() ))
+ {
+ OStringBuffer aObj( 64 );
+ aObj.append( aAttribObjects.back() );
+ aObj.append( " 0 obj\n"
+ "<</O/Layout\n" );
+ aLayout.append( ">>\nendobj\n\n" );
+ writeBuffer( aObj.getStr(), aObj.getLength() );
+ writeBuffer( aLayout.getStr(), aLayout.getLength() );
+ }
}
if( !aList.isEmpty() )
{
aAttribObjects.push_back( createObject() );
- updateObject( aAttribObjects.back() );
- OStringBuffer aObj( 64 );
- aObj.append( aAttribObjects.back() );
- aObj.append( " 0 obj\n"
- "<</O/List\n" );
- aList.append( ">>\nendobj\n\n" );
- writeBuffer( aObj.getStr(), aObj.getLength() );
- writeBuffer( aList.getStr(), aList.getLength() );
+ if (updateObject( aAttribObjects.back() ))
+ {
+ OStringBuffer aObj( 64 );
+ aObj.append( aAttribObjects.back() );
+ aObj.append( " 0 obj\n"
+ "<</O/List\n" );
+ aList.append( ">>\nendobj\n\n" );
+ writeBuffer( aObj.getStr(), aObj.getLength() );
+ writeBuffer( aList.getStr(), aList.getLength() );
+ }
}
if( !aTable.isEmpty() )
{
aAttribObjects.push_back( createObject() );
- updateObject( aAttribObjects.back() );
- OStringBuffer aObj( 64 );
- aObj.append( aAttribObjects.back() );
- aObj.append( " 0 obj\n"
- "<</O/Table\n" );
- aTable.append( ">>\nendobj\n\n" );
- writeBuffer( aObj.getStr(), aObj.getLength() );
- writeBuffer( aTable.getStr(), aTable.getLength() );
+ if (updateObject( aAttribObjects.back() ))
+ {
+ OStringBuffer aObj( 64 );
+ aObj.append( aAttribObjects.back() );
+ aObj.append( " 0 obj\n"
+ "<</O/Table\n" );
+ aTable.append( ">>\nendobj\n\n" );
+ writeBuffer( aObj.getStr(), aObj.getLength() );
+ writeBuffer( aTable.getStr(), aTable.getLength() );
+ }
}
OStringBuffer aRet( 64 );