diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-29 08:46:47 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-29 09:57:15 +0100 |
commit | 933660e591211f06a1be43e83c64ad1e8529bc2f (patch) | |
tree | adc0ede7c30c9ee5af7b75e649c806831f73da41 /vcl/unx/generic/print | |
parent | b9c9c70157e7bc5b868437ab6bda2b21ba34c627 (diff) |
loplugin:stringconstant look for unnecessary OString constructor use
and tweak the methods in check.hxx to make them more flexible when
called with
dc.Class(xxx ? "foo" : "bar")
Change-Id: I881fe628f22121ced4d8849715d6b1c92b092da1
Reviewed-on: https://gerrit.libreoffice.org/64207
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/unx/generic/print')
-rw-r--r-- | vcl/unx/generic/print/common_gfx.cxx | 2 | ||||
-rw-r--r-- | vcl/unx/generic/print/genprnpsp.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/vcl/unx/generic/print/common_gfx.cxx b/vcl/unx/generic/print/common_gfx.cxx index 85984e835736..586b59693fc6 100644 --- a/vcl/unx/generic/print/common_gfx.cxx +++ b/vcl/unx/generic/print/common_gfx.cxx @@ -1078,7 +1078,7 @@ PrinterGfx::DrawEPS( const tools::Rectangle& rBoundingBox, void* pPtr, sal_uInt3 char cChar = aLine[1]; if( cChar == '%' ) { - if( aLine.matchIgnoreAsciiCase( OString( "%%BoundingBox:") ) ) + if( aLine.matchIgnoreAsciiCase( "%%BoundingBox:" ) ) { aLine = WhitespaceToSpace( aLine.getToken(1, ':') ); if( !aLine.isEmpty() && aLine.indexOf( "atend" ) == -1 ) diff --git a/vcl/unx/generic/print/genprnpsp.cxx b/vcl/unx/generic/print/genprnpsp.cxx index 376da8fcf51f..69080676102f 100644 --- a/vcl/unx/generic/print/genprnpsp.cxx +++ b/vcl/unx/generic/print/genprnpsp.cxx @@ -254,7 +254,7 @@ static bool passFileToCommandLine( const OUString& rFilename, const OUString& rC // setup command line for exec if( ! bPipe ) - aCmdLine = aCmdLine.replaceAll(OString("(TMP)"), aFilename); + aCmdLine = aCmdLine.replaceAll("(TMP)", aFilename); #if OSL_DEBUG_LEVEL > 1 fprintf( stderr, "%s commandline: \"%s\"\n", |