diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-22 15:52:16 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-24 07:56:01 +0100 |
| commit | de8f6b25de6fbe813fe172542e7eff1596b37335 (patch) | |
| tree | 4a2864c87395463391cd2ad40c4f1ada962f44e9 /vcl/unx/generic/print | |
| parent | 182a3c7e12a0f56d664deaf67d17bc51eef6299d (diff) | |
loplugin:unused-returns in vcl
Change-Id: I507320900a47f604d17ed7d402d531a7cbdf744e
Reviewed-on: https://gerrit.libreoffice.org/48331
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/unx/generic/print')
| -rw-r--r-- | vcl/unx/generic/print/glyphset.cxx | 6 | ||||
| -rw-r--r-- | vcl/unx/generic/print/glyphset.hxx | 2 | ||||
| -rw-r--r-- | vcl/unx/generic/print/printerjob.cxx | 6 |
3 files changed, 6 insertions, 8 deletions
diff --git a/vcl/unx/generic/print/glyphset.cxx b/vcl/unx/generic/print/glyphset.cxx index 1d60d7510145..5e1ff90aa737 100644 --- a/vcl/unx/generic/print/glyphset.cxx +++ b/vcl/unx/generic/print/glyphset.cxx @@ -58,15 +58,15 @@ GlyphSet::~GlyphSet () /* FIXME delete the glyphlist ??? */ } -bool +void GlyphSet::GetGlyphID ( sal_GlyphId nGlyph, unsigned char* nOutGlyphID, sal_Int32* nOutGlyphSetID ) { - return LookupGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID) - || AddGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID); + if (LookupGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID)) + AddGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID); } bool diff --git a/vcl/unx/generic/print/glyphset.hxx b/vcl/unx/generic/print/glyphset.hxx index 45d0c81d6474..a8484bd7a5a8 100644 --- a/vcl/unx/generic/print/glyphset.hxx +++ b/vcl/unx/generic/print/glyphset.hxx @@ -51,7 +51,7 @@ private: OString GetGlyphSetName (sal_Int32 nGlyphSetID); - bool GetGlyphID (sal_GlyphId nGlyphId, + void GetGlyphID (sal_GlyphId nGlyphId, unsigned char* nOutGlyphID, sal_Int32* nOutGlyphSetID); bool LookupGlyphID (sal_GlyphId nGlyphId, unsigned char* nOutGlyphID, sal_Int32* nOutGlyphSetID); diff --git a/vcl/unx/generic/print/printerjob.cxx b/vcl/unx/generic/print/printerjob.cxx index 4aaa737d12e4..aa6a6f088d64 100644 --- a/vcl/unx/generic/print/printerjob.cxx +++ b/vcl/unx/generic/print/printerjob.cxx @@ -623,14 +623,14 @@ PrinterJob::StartPage (const JobData& rJobSetup) } } -bool +void PrinterJob::EndPage () { osl::File* pPageHeader = maHeaderVector.back().get(); osl::File* pPageBody = maPageVector.back().get(); if( ! (pPageBody && pPageHeader) ) - return false; + return; // copy page to paper and write page trailer according to DSC @@ -645,8 +645,6 @@ PrinterJob::EndPage () pPageHeader->close(); pPageBody->close(); - - return true; } struct less_ppd_key |