diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-01-26 15:25:40 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-01-26 20:00:08 +0100 |
| commit | 63d4ab4bd709b66724c8cb78668fed71f8977098 (patch) | |
| tree | 96de2ff6652280454cfdf2a302e391a053802822 /vcl/unx/generic/window | |
| parent | af2a2a0c72db312902e466c36697b5c198041e82 (diff) | |
Remove redundant(?) initialization of frame geometry
The memset of maGeometry was added with 79e2c2577527578629d7bb719a88396645a4cc49
"INTEGRATION: CWS vclplug" in 2003, before
f7be39169fef0823e04f556cc9c9fdcda34d8685 "INTEGRATION: CWS presenterview" in
2008 introduced a user-provided _SalFrameGeometry default ctor, which sets all
members except nWidth and nHeight to 0, and sets nWidth and nHeight to 1.
So the memset effectively set nWidth and nHeight to back 0 (whether or not that
was by design or by accident after the latter commit), but that seems to be
unnecessary after all, seeing that a SAL_USE_VCLPLUGIN=gen soffice appears to
stll work well after removing the memset.
Change-Id: Ic6d1c6476a1234e84dca1e560149cd1e9af37b73
Reviewed-on: https://gerrit.libreoffice.org/48696
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'vcl/unx/generic/window')
| -rw-r--r-- | vcl/unx/generic/window/salframe.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/vcl/unx/generic/window/salframe.cxx b/vcl/unx/generic/window/salframe.cxx index 5833463f354a..89ea99b6a7f9 100644 --- a/vcl/unx/generic/window/salframe.cxx +++ b/vcl/unx/generic/window/salframe.cxx @@ -822,9 +822,6 @@ X11SalFrame::X11SalFrame( SalFrame *pParent, SalFrameStyleFlags nSalFrameStyle, { GenericUnixSalData *pData = GetGenericUnixSalData(); - // initialize frame geometry - memset( &maGeometry, 0, sizeof(maGeometry) ); - mpParent = static_cast< X11SalFrame* >( pParent ); mbTransientForRoot = false; |