diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-28 15:13:42 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-29 07:17:37 +0100 |
| commit | 21de55596c0fdc2be736c6d0369bd9d3783020be (patch) | |
| tree | 07d0f0cd54690e54405fe574c572cb2be74a3336 /vcl/unx/generic | |
| parent | da9fb5d6d9ebf9363981c370ce937d8848989fcb (diff) | |
remove unnecessary "if (!empty()" checks before loops
found with
git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'
Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/unx/generic')
| -rw-r--r-- | vcl/unx/generic/fontmanager/fontmanager.cxx | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx b/vcl/unx/generic/fontmanager/fontmanager.cxx index 394c5484a5bd..8690378c1120 100644 --- a/vcl/unx/generic/fontmanager/fontmanager.cxx +++ b/vcl/unx/generic/fontmanager/fontmanager.cxx @@ -174,15 +174,12 @@ std::vector<fontID> PrintFontManager::addFontFile( const OString& rFileName ) if( aFontIds.empty() ) { std::vector<std::unique_ptr<PrintFont>> aNewFonts = analyzeFontFile(nDirID, aName); - if (!aNewFonts.empty()) + for (auto & font : aNewFonts) { - for (auto & font : aNewFonts) - { - fontID nFontId = m_nNextFontID++; - m_aFonts[nFontId] = std::move(font); - m_aFontFileToFontID[ aName ].insert( nFontId ); - aFontIds.push_back(nFontId); - } + fontID nFontId = m_nNextFontID++; + m_aFonts[nFontId] = std::move(font); + m_aFontFileToFontID[ aName ].insert( nFontId ); + aFontIds.push_back(nFontId); } } return aFontIds; |