New loplugin:external

...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 1d5ca9e415ef..d99fa04f09fb 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2235,7 +2235,7 @@ public:
     }
 };
 
-GType crippled_viewport_get_type();
+static GType crippled_viewport_get_type();
 
 #define CRIPPLED_TYPE_VIEWPORT            (crippled_viewport_get_type ())
 #define CRIPPLED_VIEWPORT(obj)            (G_TYPE_CHECK_INSTANCE_CAST ((obj), CRIPPLED_TYPE_VIEWPORT, CrippledViewport))
@@ -2380,7 +2380,7 @@ GType crippled_viewport_get_type()
     return type;
 }
 
-VclPolicyType GtkToVcl(GtkPolicyType eType)
+static VclPolicyType GtkToVcl(GtkPolicyType eType)
 {
     VclPolicyType eRet(VclPolicyType::NEVER);
     switch (eType)
@@ -2399,7 +2399,7 @@ VclPolicyType GtkToVcl(GtkPolicyType eType)
     return eRet;
 }
 
-GtkPolicyType VclToGtk(VclPolicyType eType)
+static GtkPolicyType VclToGtk(VclPolicyType eType)
 {
     GtkPolicyType eRet(GTK_POLICY_ALWAYS);
     switch (eType)
@@ -2417,7 +2417,7 @@ GtkPolicyType VclToGtk(VclPolicyType eType)
     return eRet;
 }
 
-GtkMessageType VclToGtk(VclMessageType eType)
+static GtkMessageType VclToGtk(VclMessageType eType)
 {
     GtkMessageType eRet(GTK_MESSAGE_INFO);
     switch (eType)
@@ -2438,7 +2438,7 @@ GtkMessageType VclToGtk(VclMessageType eType)
     return eRet;
 }
 
-GtkButtonsType VclToGtk(VclButtonsType eType)
+static GtkButtonsType VclToGtk(VclButtonsType eType)
 {
     GtkButtonsType eRet(GTK_BUTTONS_NONE);
     switch (eType)