diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-01-26 10:03:37 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-01-27 10:18:50 +0100 |
| commit | df788fcc308bbf8950ad8a22a1f8290681b64f0d (patch) | |
| tree | eac883afe20faea112046e1ca4d3999c5668ef1c /vcl/unx/gtk3_kde5 | |
| parent | 7d506f6bb45725bff9d5a6ddf0893d826f992596 (diff) | |
tdf#139609 avoid fetching unnecessary xid under gtk3
because of the side effects
using a bare GtkGrid as m_pSocket in vcl/unx/gtk3/gtk3gtkobject.cxx
is perhaps a poor choice, getting its xid causes poor side effects
wrt events belonging to its child widgets getting delivered to
the SalFrame widget, so duplicate scrolling after showing a opengl
slide and/or showing a video and lots of flickering
we're (generally at least) not using the xid under gtk3 so don't set it
unless it's explicitly asked for. Happily the gtk Player::createPlayerWindow
doesn't use its arg[0] xid in any case, so don't bother setting it for
that backend.
Change-Id: I1c59a607a332635091782c3b49de10647558f301
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109941
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/unx/gtk3_kde5')
| -rw-r--r-- | vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx index 30d1f64afefc..4bccf1e24d72 100644 --- a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx +++ b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx @@ -197,7 +197,7 @@ std::function<void()> Gtk3KDE5FilePickerIpc::blockMainWindow() if (!pSysData) return {}; - sendCommand(Commands::SetWinId, pSysData->GetWindowHandle()); + sendCommand(Commands::SetWinId, pSysData->GetWindowHandle(pParentWin->ImplGetFrame())); auto* pMainWindow = static_cast<GtkWidget*>(pSysData->pWidget); if (!pMainWindow) |