diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-07-18 09:13:21 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-07-18 20:19:15 +0200 |
| commit | 278e97ab0272e9c1975bd7780697067f0b91bd46 (patch) | |
| tree | 7d8db23b12516aecd1289a7afcd88b7ff5402d35 /vcl/unx | |
| parent | 54aebc2c8ff25f17a4083fe6c60c38c4f391af12 (diff) | |
cid#1507357 Big parameter passed by value
and
cid#1507358 Big parameter passed by value
cid#1507359 Big parameter passed by value
Change-Id: I7adb0497e4e8b90683ee644790c4657b8ac75fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/unx')
| -rw-r--r-- | vcl/unx/generic/print/prtsetup.cxx | 5 | ||||
| -rw-r--r-- | vcl/unx/generic/print/prtsetup.hxx | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/vcl/unx/generic/print/prtsetup.cxx b/vcl/unx/generic/print/prtsetup.cxx index 0ff7366fab6c..56ee475e701e 100644 --- a/vcl/unx/generic/print/prtsetup.cxx +++ b/vcl/unx/generic/print/prtsetup.cxx @@ -22,7 +22,6 @@ #include <strings.hrc> #include <officecfg/Office/Common.hxx> -#include <utility> using namespace psp; @@ -68,9 +67,9 @@ void RTSDialog::insertAllPPDValues(weld::ComboBox& rBox, const PPDParser* pParse * RTSDialog */ -RTSDialog::RTSDialog(PrinterInfo aJobData, weld::Window* pParent) +RTSDialog::RTSDialog(const PrinterInfo& rJobData, weld::Window* pParent) : GenericDialogController(pParent, "vcl/ui/printerpropertiesdialog.ui", "PrinterPropertiesDialog") - , m_aJobData(std::move(aJobData)) + , m_aJobData(rJobData) , m_bDataModified(false) , m_xTabControl(m_xBuilder->weld_notebook("tabcontrol")) , m_xOKButton(m_xBuilder->weld_button("ok")) diff --git a/vcl/unx/generic/print/prtsetup.hxx b/vcl/unx/generic/print/prtsetup.hxx index 4052bb50aa03..bcf86670d0b6 100644 --- a/vcl/unx/generic/print/prtsetup.hxx +++ b/vcl/unx/generic/print/prtsetup.hxx @@ -52,7 +52,7 @@ class RTSDialog : public weld::GenericDialogController void insertAllPPDValues(weld::ComboBox&, const psp::PPDParser*, const psp::PPDKey*); public: - RTSDialog(::psp::PrinterInfo aJobData, weld::Window* pParent); + RTSDialog(const ::psp::PrinterInfo& rJobData, weld::Window* pParent); virtual ~RTSDialog() override; const ::psp::PrinterInfo& getSetup() const { return m_aJobData; } |