diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-13 15:03:20 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-13 17:54:41 +0200 |
| commit | b37653fdc74e05ff2f86dad39cc1878d9047580b (patch) | |
| tree | 852fa5e6bb90bc5c3728e2ceef294a54afd18c9e /vcl | |
| parent | 49e2bd6103669ca94d4e308fc08beed57f85c7e2 (diff) | |
improve comments around blocks which abort on UI thread event exceptions
Change-Id: If3336b8a39e41d958de2e998e3d9467888f2df6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100659
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/app/salusereventlist.cxx | 7 | ||||
| -rw-r--r-- | vcl/source/app/scheduler.cxx | 1 |
2 files changed, 8 insertions, 0 deletions
diff --git a/vcl/source/app/salusereventlist.cxx b/vcl/source/app/salusereventlist.cxx index 088bc141f5a6..0321fc29e9fd 100644 --- a/vcl/source/app/salusereventlist.cxx +++ b/vcl/source/app/salusereventlist.cxx @@ -103,6 +103,13 @@ bool SalUserEventList::DispatchUserEvents( bool bHandleAllCurrentEvents ) continue; } + /* + * Current policy is that scheduler tasks aren't allowed to throw an exception. + * Because otherwise the exception is caught somewhere totally unrelated. + * TODO Ideally we could capture a proper backtrace and feed this into breakpad, + * which is do-able, but requires writing some assembly. + * See also Scheduler::ProcessTaskScheduling + */ #ifndef IOS try #endif diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx index e8ad527ec949..f9fc3dc01fc6 100644 --- a/vcl/source/app/scheduler.cxx +++ b/vcl/source/app/scheduler.cxx @@ -479,6 +479,7 @@ bool Scheduler::ProcessTaskScheduling() * Because otherwise the exception is caught somewhere totally unrelated. * TODO Ideally we could capture a proper backtrace and feed this into breakpad, * which is do-able, but requires writing some assembly. + * See also SalUserEventList::DispatchUserEvents */ try { |