Some loplugin:revisibility clean-up

Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.

However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.

Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510

5 files changed, 10 insertions, 10 deletions

diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index 687cc943b09a..ca40b4a46e4a 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -1160,7 +1160,7 @@ BitmapEx BitmapEx::ModifyBitmapEx(const basegfx::BColorModifierStack& rBColorMod
     }
 }
 
-BitmapEx VCL_DLLPUBLIC createBlendFrame(
+BitmapEx createBlendFrame(
     const Size& rSize,
     sal_uInt8 nAlpha,
     Color aColorTopLeft,
@@ -1184,7 +1184,7 @@ BitmapEx VCL_DLLPUBLIC createBlendFrame(
     return BitmapEx();
 }
 
-BitmapEx VCL_DLLPUBLIC createBlendFrame(
+BitmapEx createBlendFrame(
     const Size& rSize,
     sal_uInt8 nAlpha,
     Color aColorTopLeft,
diff --git a/vcl/source/gdi/gdimetafiletools.cxx b/vcl/source/gdi/gdimetafiletools.cxx
index 963592b9853f..e58fb0c2dadb 100644
--- a/vcl/source/gdi/gdimetafiletools.cxx
+++ b/vcl/source/gdi/gdimetafiletools.cxx
@@ -1057,7 +1057,7 @@ void clipMetafileContentAgainstOwnRegions(GDIMetaFile& rSource)
     }
 }
 
-bool VCL_DLLPUBLIC usesClipActions(const GDIMetaFile& rSource)
+bool usesClipActions(const GDIMetaFile& rSource)
 {
     const sal_uLong nObjCount(rSource.GetActionSize());
 
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 1a5938bdebab..4d9ee516c259 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -219,13 +219,13 @@ sal_UCS4 GetVerticalChar( sal_UCS4 )
     return 0; // #i14788# input method is responsible vertical char changes
 }
 
-VCL_DLLPUBLIC sal_UCS4 GetMirroredChar( sal_UCS4 nChar )
+sal_UCS4 GetMirroredChar( sal_UCS4 nChar )
 {
     nChar = u_charMirror( nChar );
     return nChar;
 }
 
-VCL_DLLPUBLIC sal_UCS4 GetLocalizedChar( sal_UCS4 nChar, LanguageType eLang )
+sal_UCS4 GetLocalizedChar( sal_UCS4 nChar, LanguageType eLang )
 {
     // currently only conversion from ASCII digits is interesting
     if( (nChar < '0') || ('9' < nChar) )
diff --git a/vcl/source/gdi/svgdata.cxx b/vcl/source/gdi/svgdata.cxx
index b844c502c689..3a98b87d8b55 100644
--- a/vcl/source/gdi/svgdata.cxx
+++ b/vcl/source/gdi/svgdata.cxx
@@ -31,7 +31,7 @@
 
 using namespace ::com::sun::star;
 
-BitmapEx VCL_DLLPUBLIC convertPrimitive2DSequenceToBitmapEx(
+BitmapEx convertPrimitive2DSequenceToBitmapEx(
     const Primitive2DSequence& rSequence,
     const basegfx::B2DRange& rTargetRange,
     const sal_uInt32 nMaximumQuadraticPixels)
diff --git a/vcl/source/helper/canvastools.cxx b/vcl/source/helper/canvastools.cxx
index 54a9ae1f2e36..901527b36a34 100644
--- a/vcl/source/helper/canvastools.cxx
+++ b/vcl/source/helper/canvastools.cxx
@@ -181,7 +181,7 @@ namespace vcl
             }
         }
 
-        ::BitmapEx VCL_DLLPUBLIC bitmapExFromXBitmap( const uno::Reference< rendering::XIntegerReadOnlyBitmap >& xInputBitmap )
+        ::BitmapEx bitmapExFromXBitmap( const uno::Reference< rendering::XIntegerReadOnlyBitmap >& xInputBitmap )
         {
             SAL_INFO( "vcl.helper", "::vcl::unotools::bitmapExFromXBitmap()" );
 
@@ -563,7 +563,7 @@ namespace vcl
             };
         }
 
-        uno::Reference<rendering::XColorSpace> VCL_DLLPUBLIC createStandardColorSpace()
+        uno::Reference<rendering::XColorSpace> createStandardColorSpace()
         {
             return new StandardColorSpace();
         }
@@ -599,7 +599,7 @@ namespace vcl
             return aColor;
         }
 
-        uno::Sequence< double > VCL_DLLPUBLIC colorToDoubleSequence(
+        uno::Sequence< double > colorToDoubleSequence(
             const Color&                                    rColor,
             const uno::Reference< rendering::XColorSpace >& xColorSpace )
         {
@@ -613,7 +613,7 @@ namespace vcl
             return xColorSpace->convertFromARGB(aSeq);
         }
 
-        Color VCL_DLLPUBLIC doubleSequenceToColor(
+        Color doubleSequenceToColor(
             const uno::Sequence< double >&                  rColor,
             const uno::Reference< rendering::XColorSpace >& xColorSpace )
         {