diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2015-06-19 11:33:24 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2015-06-19 13:26:09 +0200 |
| commit | cbe944e323edb20f958bb46ea644de659b75382e (patch) | |
| tree | c51e99e46e447f139fbbc48ff0d9aa8885e70a82 /vcl | |
| parent | 2f6af46dedcf3ad5ec3a40876dbf1120eec359b6 (diff) | |
Catch inadvertent uses of OUString(sal_Unicode) ctor
...with numeric values that are not meant to be characters. Inspired by
<https://gerrit.libreoffice.org/#/c/16339/> "OUString: add constructor from
single Unicode code point" and ecaf1cb3861c1b519a1495487fc796884cf37b92 "seems
to be what was meant." Found e46e8d19458fd64ff20b1013e5eeabd07e62379c "Shall
this produce a string representation of a number?" and
f2a0e4032734d6be635f14ade3dea499c29ec6c2 "Don't truncate a UTF-32 code point to
a UTF-16 code unit."
(LIBO_INTERNAL_ONLY mostly because it uses a C++11 delegating ctor for
simplicity, but also because it requires mild modifications to client code, see
additional changes in this commit and some other recent commits.)
Change-Id: I8a156f01d1b772c6052d7afaa088ae13ed234e2b
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/app/IconThemeInfo.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/source/app/IconThemeInfo.cxx b/vcl/source/app/IconThemeInfo.cxx index da07e2c6bf77..95b47fbc1b0c 100644 --- a/vcl/source/app/IconThemeInfo.cxx +++ b/vcl/source/app/IconThemeInfo.cxx @@ -132,7 +132,7 @@ IconThemeInfo::ThemeIdToDisplayName(const OUString& themeId) OUString r; sal_Unicode firstLetter = themeId[0]; if (rtl::isAsciiLowerCase(firstLetter)) { - r = OUString(rtl::toAsciiUpperCase(firstLetter)); + r = OUString(sal_Unicode(rtl::toAsciiUpperCase(firstLetter))); r += themeId.copy(1); } else { |