diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-07-19 10:50:07 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-07-19 10:50:07 +0200 |
commit | 90576b93244ea836714cb1b75dff16503a270772 (patch) | |
tree | b2e8eab0e2d298a5aa0b2ebff48457c722035f04 /vcl | |
parent | 454ab144c9f531a090a38ad23b5f50af85f1fbea (diff) |
clang-tidy performance-unnecessary-value-param in vcl
Change-Id: I0b53c4bf5b4619cde357cf4eb432b153b1f7e6b5
Diffstat (limited to 'vcl')
-rw-r--r-- | vcl/inc/opengl/LineRenderUtils.hxx | 6 | ||||
-rw-r--r-- | vcl/opengl/LineRenderUtils.cxx | 6 | ||||
-rw-r--r-- | vcl/qa/cppunit/BitmapTest.cxx | 4 | ||||
-rw-r--r-- | vcl/source/control/ctrl.cxx | 2 | ||||
-rw-r--r-- | vcl/source/control/longcurr.cxx | 2 | ||||
-rw-r--r-- | vcl/source/control/slider.cxx | 2 | ||||
-rw-r--r-- | vcl/source/filter/jpeg/jpeg.h | 2 | ||||
-rw-r--r-- | vcl/source/filter/jpeg/jpegc.cxx | 2 | ||||
-rw-r--r-- | vcl/source/image/ImplImageTree.cxx | 4 | ||||
-rw-r--r-- | vcl/unx/kde4/KDESalGraphics.cxx | 8 | ||||
-rw-r--r-- | vcl/workben/outdevgrind.cxx | 2 |
11 files changed, 20 insertions, 20 deletions
diff --git a/vcl/inc/opengl/LineRenderUtils.hxx b/vcl/inc/opengl/LineRenderUtils.hxx index 7c9018a67fa9..58ae6a809104 100644 --- a/vcl/inc/opengl/LineRenderUtils.hxx +++ b/vcl/inc/opengl/LineRenderUtils.hxx @@ -40,9 +40,9 @@ public: void appendAndConnectLinePoint(const glm::vec2& rPoint, const glm::vec2& aNormal, GLfloat aExtrusion); - void appendMiterJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector); - void appendBevelJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector); - void appendRoundJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector); + void appendMiterJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 const & nextLineVector); + void appendBevelJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 nextLineVector); + void appendRoundJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 nextLineVector); void appendRoundLineCapVertices(const glm::vec2& rPoint1, const glm::vec2& rPoint2); void appendSquareLineCapVertices(const glm::vec2& rPoint1, const glm::vec2& rPoint2); }; diff --git a/vcl/opengl/LineRenderUtils.cxx b/vcl/opengl/LineRenderUtils.cxx index 1b7fb9919490..c815b8a014d2 100644 --- a/vcl/opengl/LineRenderUtils.cxx +++ b/vcl/opengl/LineRenderUtils.cxx @@ -93,7 +93,7 @@ void LineBuilder::appendAndConnectLinePoint(const glm::vec2& rPoint, const glm:: } } -void LineBuilder::appendMiterJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector) +void LineBuilder::appendMiterJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 const & nextLineVector) { // With miter join we calculate the extrusion vector by adding normals of // previous and next line segment. The vector shows the way but we also @@ -111,7 +111,7 @@ void LineBuilder::appendMiterJoint(glm::vec2 point, glm::vec2 prevLineVector, gl appendAndConnectLinePoint(point, extrusionVector, length); } -void LineBuilder::appendBevelJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector) +void LineBuilder::appendBevelJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 nextLineVector) { // For bevel join we just add 2 additional vertices and use previous // line segment normal and next line segment normal as extrusion vector. @@ -125,7 +125,7 @@ void LineBuilder::appendBevelJoint(glm::vec2 point, glm::vec2 prevLineVector, gl appendAndConnectLinePoint(point, nextNormal, 1.0f); } -void LineBuilder::appendRoundJoint(glm::vec2 point, glm::vec2 prevLineVector, glm::vec2 nextLineVector) +void LineBuilder::appendRoundJoint(glm::vec2 const & point, glm::vec2 prevLineVector, glm::vec2 nextLineVector) { // For round join we do a similar thing as in bevel, we add more intermediate // vertices and add normals to get extrusion vectors in the between the diff --git a/vcl/qa/cppunit/BitmapTest.cxx b/vcl/qa/cppunit/BitmapTest.cxx index d2444b15abc8..6823cfb4e28d 100644 --- a/vcl/qa/cppunit/BitmapTest.cxx +++ b/vcl/qa/cppunit/BitmapTest.cxx @@ -165,12 +165,12 @@ void checkAndInsert(CRCHash &rHash, sal_uInt64 nCRC, const char *pLocation) rHash[nCRC] = pLocation; } -void checkAndInsert(CRCHash &rHash, Bitmap rBmp, const char *pLocation) +void checkAndInsert(CRCHash &rHash, Bitmap const & rBmp, const char *pLocation) { checkAndInsert(rHash, rBmp.GetChecksum(), pLocation); } -Bitmap getAsBitmap(VclPtr<OutputDevice> pOut) +Bitmap getAsBitmap(VclPtr<OutputDevice> const & pOut) { return pOut->GetBitmap(Point(), pOut->GetOutputSizePixel()); } diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx index 13ea3d0cdd96..2235cd4c3ca1 100644 --- a/vcl/source/control/ctrl.cxx +++ b/vcl/source/control/ctrl.cxx @@ -311,7 +311,7 @@ void Control::AppendLayoutData( const Control& rSubControl ) const } } -bool Control::ImplCallEventListenersAndHandler( sal_uLong nEvent, std::function<void()> callHandler ) +bool Control::ImplCallEventListenersAndHandler( sal_uLong nEvent, std::function<void()> const & callHandler ) { VclPtr<Control> xThis(this); diff --git a/vcl/source/control/longcurr.cxx b/vcl/source/control/longcurr.cxx index 6eb44c527742..b9283666c79d 100644 --- a/vcl/source/control/longcurr.cxx +++ b/vcl/source/control/longcurr.cxx @@ -259,7 +259,7 @@ inline bool ImplLongCurrencyGetValue( const OUString& rStr, BigInt& rValue, return ImplNumericGetValue( rStr, rValue, nDecDigits, rLocaleDataWrapper, true ); } -bool ImplLongCurrencyReformat( const OUString& rStr, BigInt nMin, BigInt nMax, +bool ImplLongCurrencyReformat( const OUString& rStr, BigInt const & nMin, BigInt const & nMax, sal_uInt16 nDecDigits, const LocaleDataWrapper& rLocaleDataWrapper, OUString& rOutStr, LongCurrencyFormatter& rFormatter ) diff --git a/vcl/source/control/slider.cxx b/vcl/source/control/slider.cxx index 96e31060742c..a59eb77bc4e4 100644 --- a/vcl/source/control/slider.cxx +++ b/vcl/source/control/slider.cxx @@ -823,7 +823,7 @@ void Slider::Resize() Invalidate(InvalidateFlags::NoChildren | InvalidateFlags::NoErase); } -void Slider::SetLinkedField(VclPtr<NumericField> pField) +void Slider::SetLinkedField(VclPtr<NumericField> const & pField) { if (mpLinkedField) { diff --git a/vcl/source/filter/jpeg/jpeg.h b/vcl/source/filter/jpeg/jpeg.h index 63c4b2ac3d28..08caa474226c 100644 --- a/vcl/source/filter/jpeg/jpeg.h +++ b/vcl/source/filter/jpeg/jpeg.h @@ -40,7 +40,7 @@ void jpeg_svstream_src (j_decompress_ptr cinfo, void* infile); void jpeg_svstream_dest (j_compress_ptr cinfo, void* outfile); bool WriteJPEG( JPEGWriter* pJPEGWriter, void* pOutputStream, - long nWidth, long nHeight, basegfx::B2DSize aPPI, bool bGreyScale, + long nWidth, long nHeight, basegfx::B2DSize const & aPPI, bool bGreyScale, long nQualityPercent, long aChromaSubsampling, css::uno::Reference<css::task::XStatusIndicator> const & status); diff --git a/vcl/source/filter/jpeg/jpegc.cxx b/vcl/source/filter/jpeg/jpegc.cxx index ef3c91c736bf..74be061644c1 100644 --- a/vcl/source/filter/jpeg/jpegc.cxx +++ b/vcl/source/filter/jpeg/jpegc.cxx @@ -231,7 +231,7 @@ void ReadJPEG( JPEGReader* pJPEGReader, void* pInputStream, long* pLines, } bool WriteJPEG( JPEGWriter* pJPEGWriter, void* pOutputStream, - long nWidth, long nHeight, basegfx::B2DSize aPPI, bool bGreys, + long nWidth, long nHeight, basegfx::B2DSize const & aPPI, bool bGreys, long nQualityPercent, long aChromaSubsampling, css::uno::Reference<css::task::XStatusIndicator> const & status ) { diff --git a/vcl/source/image/ImplImageTree.cxx b/vcl/source/image/ImplImageTree.cxx index b512dd43047a..1f7f1eca2480 100644 --- a/vcl/source/image/ImplImageTree.cxx +++ b/vcl/source/image/ImplImageTree.cxx @@ -78,7 +78,7 @@ std::shared_ptr<SvStream> wrapStream(css::uno::Reference< css::io::XInputStream return s; } -void loadImageFromStream(std::shared_ptr<SvStream> xStream, OUString const & rPath, BitmapEx & rBitmap) +void loadImageFromStream(std::shared_ptr<SvStream> const & xStream, OUString const & rPath, BitmapEx & rBitmap) { if (rPath.endsWith(".png")) { @@ -359,7 +359,7 @@ void ImplImageTree::loadImageLinks() } } -void ImplImageTree::parseLinkFile(std::shared_ptr<SvStream> xStream) +void ImplImageTree::parseLinkFile(std::shared_ptr<SvStream> const & xStream) { OString aLine; OUString aLink, aOriginal; diff --git a/vcl/unx/kde4/KDESalGraphics.cxx b/vcl/unx/kde4/KDESalGraphics.cxx index c3239ae220d4..0a7066f2f953 100644 --- a/vcl/unx/kde4/KDESalGraphics.cxx +++ b/vcl/unx/kde4/KDESalGraphics.cxx @@ -116,7 +116,7 @@ bool KDESalGraphics::IsNativeControlSupported( ControlType type, ControlPart par /// helper drawing methods namespace { - void draw( QStyle::ControlElement element, QStyleOption* option, QImage* image, QStyle::State state, QRect rect = QRect()) + void draw( QStyle::ControlElement element, QStyleOption* option, QImage* image, QStyle::State const & state, QRect rect = QRect()) { option->state |= state; option->rect = !rect.isNull() ? rect : image->rect(); @@ -125,7 +125,7 @@ namespace QApplication::style()->drawControl(element, option, &painter); } - void draw( QStyle::PrimitiveElement element, QStyleOption* option, QImage* image, QStyle::State state, QRect rect = QRect()) + void draw( QStyle::PrimitiveElement element, QStyleOption* option, QImage* image, QStyle::State const & state, QRect rect = QRect()) { option->state |= state; option->rect = !rect.isNull() ? rect : image->rect(); @@ -134,7 +134,7 @@ namespace QApplication::style()->drawPrimitive(element, option, &painter); } - void draw( QStyle::ComplexControl element, QStyleOptionComplex* option, QImage* image, QStyle::State state ) + void draw( QStyle::ComplexControl element, QStyleOptionComplex* option, QImage* image, QStyle::State const & state ) { option->state |= state; option->rect = image->rect(); @@ -143,7 +143,7 @@ namespace QApplication::style()->drawComplexControl(element, option, &painter); } - void lcl_drawFrame(QStyle::PrimitiveElement element, QImage* image, QStyle::State state) + void lcl_drawFrame(QStyle::PrimitiveElement element, QImage* image, QStyle::State const & state) { #if ( QT_VERSION >= QT_VERSION_CHECK( 4, 5, 0 ) ) QStyleOptionFrameV3 option; diff --git a/vcl/workben/outdevgrind.cxx b/vcl/workben/outdevgrind.cxx index e6ff4f48cbff..1b983bcd2f3a 100644 --- a/vcl/workben/outdevgrind.cxx +++ b/vcl/workben/outdevgrind.cxx @@ -580,7 +580,7 @@ void setupMethodStubs( functor_vector_type& res ) } void grindFunc( OutputDevice& rTarget, - functor_vector_type::const_iterator iter, + functor_vector_type::const_iterator const & iter, sal_Int32 nTurns, const char* pMsg ) { |