diff options
| author | Michael Meeks <michael.meeks@collabora.com> | 2021-11-23 14:25:45 +0000 |
|---|---|---|
| committer | Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> | 2022-05-23 10:45:50 +0200 |
| commit | 87494146c5f56ef8779966f8c59544613a4d3f60 (patch) | |
| tree | 4c22f01e6a335d8a2d840a0ffabb74fca73619aa /vcl | |
| parent | b3ac549ba096dd7bfc6842a3d8e68a3cc4ad4054 (diff) | |
Crash around help-windows.
Seems a popular way to crash:
vcl::Window::ImplCallMove()
vcl/source/window/event.cxx:555
vcl::Window::Show(bool, ShowFlags) [clone .localalias]
/usr/include/c++/10/bits/unique_ptr.h:173
vcl::Window::Show(bool, ShowFlags)
vcl/source/window/window.cxx:2345
HelpTextWindow::ImplShow()
vcl/source/app/help.cxx:371
Scheduler::ProcessTaskScheduling()
vcl/source/app/scheduler.cxx:495
Change-Id: I33ca0059844395c41f4d76619cca22aec81df207
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125702
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/window/event.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/vcl/source/window/event.cxx b/vcl/source/window/event.cxx index edfa7fd8c4d8..a0ccb699b1d9 100644 --- a/vcl/source/window/event.cxx +++ b/vcl/source/window/event.cxx @@ -548,7 +548,8 @@ void Window::ImplCallMove() vcl::Window *pParent = ImplGetParent(); while( pParent ) { - if( pParent->mpWindowImpl->mpFrame != mpWindowImpl->mpFrame ) + if( pParent->mpWindowImpl && + pParent->mpWindowImpl->mpFrame != mpWindowImpl->mpFrame ) { pParentFrame = pParent->mpWindowImpl->mpFrame; break; |