summaryrefslogtreecommitdiff
path: root/vcl
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-01-18 15:59:46 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-01-19 13:25:54 +0100
commitbe94207ecb88a9005ee6624e354d70c9613d7653 (patch)
treee57c6534adaea7930e7eac95f3b77c4e37ac452e /vcl
parent7d9a5d886f4ba5c61d3c5602a9825510c68eea41 (diff)
new loplugin:emptyif
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl')
-rw-r--r--vcl/source/edit/textview.cxx4
-rw-r--r--vcl/source/filter/jpeg/transupp.c2
-rw-r--r--vcl/source/uitest/uiobject.cxx3
-rw-r--r--vcl/source/window/brdwin.cxx5
4 files changed, 3 insertions, 11 deletions
diff --git a/vcl/source/edit/textview.cxx b/vcl/source/edit/textview.cxx
index e080dcdb51a8..c092ecd7ae72 100644
--- a/vcl/source/edit/textview.cxx
+++ b/vcl/source/edit/textview.cxx
@@ -1603,10 +1603,6 @@ void TextView::ImpShowCursor( bool bGotoCursor, bool bForceVisCursor, bool bSpec
TETextPortion* pTextPortion = pParaPortion->GetTextPortions()[ nTextPortion ];
if ( pTextPortion->GetKind() == PORTIONKIND_TAB )
{
- if ( mpImpl->mpTextEngine->IsRightToLeft() )
- {
-
- }
aEditCursor.Right() += pTextPortion->GetWidth();
}
else
diff --git a/vcl/source/filter/jpeg/transupp.c b/vcl/source/filter/jpeg/transupp.c
index 72dba281b578..aa126f03f9be 100644
--- a/vcl/source/filter/jpeg/transupp.c
+++ b/vcl/source/filter/jpeg/transupp.c
@@ -1533,7 +1533,7 @@ jcopy_markers_execute (j_decompress_ptr srcinfo, j_compress_ptr dstinfo,
* But to avoid confusion, we do not output JFIF and Adobe APP14 markers
* if the encoder library already wrote one.
*/
- if (option) {}
+ (void)option;
for (marker = srcinfo->marker_list; marker != NULL; marker = marker->next) {
if (dstinfo->write_JFIF_header &&
diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 2e404df6c2d7..7b8d0b287b18 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -832,7 +832,7 @@ void TabPageUIObject::execute(const OUString& rAction,
{
if (rAction == "SELECT")
{
-
+ /* code */
}
}
@@ -999,6 +999,7 @@ void SpinUIObject::execute(const OUString& rAction,
}
else if (rAction == "DOWN")
{
+ /* code */
}
}
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index 58914dd83fdc..5cf138c4f2e7 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -977,11 +977,6 @@ bool ImplStdBorderWindowView::Tracking( const TrackingEvent& rTEvt )
{
maFrameData.mnHelpState &= ~DrawButtonFlags::Pressed;
pBorderWindow->InvalidateBorder();
-
- // do not call a Click-Handler when aborting
- if ( !rTEvt.IsTrackingCanceled() )
- {
- }
}
}
else