diff options
| author | Andrea Gelmini <andrea.gelmini@gelma.net> | 2018-07-17 23:18:10 +0200 |
|---|---|---|
| committer | Julien Nabet <serval2412@yahoo.fr> | 2018-07-19 13:54:05 +0200 |
| commit | c9e31a8de05b5ba4b21849a22d7809ab0768aefb (patch) | |
| tree | 5665fc165c685df3f51f698f91b497244762cc1b /vcl | |
| parent | b073bbdacf694fd6a0ecc1e107b6b05af2b8ac9d (diff) | |
Fix typos
Change-Id: I2aa5448869bf60e9c8d9b1ebabd0d0932d28f3a1
Reviewed-on: https://gerrit.libreoffice.org/57606
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/README.lifecycle | 11 | ||||
| -rw-r--r-- | vcl/inc/win/winlayout.hxx | 2 |
2 files changed, 6 insertions, 7 deletions
diff --git a/vcl/README.lifecycle b/vcl/README.lifecycle index 6ef91ccfce51..732b1908d077 100644 --- a/vcl/README.lifecycle +++ b/vcl/README.lifecycle @@ -296,12 +296,12 @@ ways and often both. the inheritance chain from children to parent, during dispose. The easiest way to fix these is to just ensure that these - cleanup methods, especially LoseFocus continue to work even + cleanup methods, especially LoseFocus, continue to work even on disposed Window sub-class instances. -** It crashes with some invalid memory ... +** It crashes with some invalid memory... - Assuming that the invalid memory is a Window sub-class itself, + Assuming that the invalid memory is a Window sub-class itself, then almost certainly there is some cockup in the reference-counting; eg. if you hit an OutputDevice::release assert on mnRefCount - then almost certainly you have a @@ -309,13 +309,12 @@ ways and often both. happen via this sort of pattern: ModelessDialog *pDlg = VclPtr<ModelessDialog>(nullptr /* parent */); - // by here the pDlg quite probably points to free'd memory - ... + // by here the pDlg quite probably points to free'd memory... It is necessary in these cases to ensure that the *pDlg is a VclPtr<ModelessDialog> instead. -** It crashes with some invalid memory #2 ... +** It crashes with some invalid memory #2... Often a ::dispose method will free some pImpl member, but not NULL it; and (cf. above) we can now get various virtual diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx index 0ef5cc03b846..598d90c60588 100644 --- a/vcl/inc/win/winlayout.hxx +++ b/vcl/inc/win/winlayout.hxx @@ -157,7 +157,7 @@ public: void SetHFONT(const HFONT); HFONT GetHFONT() const { return m_hFont; } - // Prevend deletion of the HFONT in the WinFontInstance destructor + // Prevent deletion of the HFONT in the WinFontInstance destructor // Used for the ScopedFont handling void UnsetHFONT() { m_hFont = nullptr; } |