diff options
| author | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:39:24 +0100 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:50:03 +0100 |
| commit | 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba (patch) | |
| tree | 3959801825b12a5def0a4e6402917a455aa9c6a2 /vcl | |
| parent | a7b9167235d38130aab1af4bed66b6c48d375fc9 (diff) | |
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/gdi/configsettings.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/vcl/source/gdi/configsettings.cxx b/vcl/source/gdi/configsettings.cxx index dd5c32757a7f..1e33a4819e89 100644 --- a/vcl/source/gdi/configsettings.cxx +++ b/vcl/source/gdi/configsettings.cxx @@ -53,8 +53,7 @@ SettingsConfigItem::SettingsConfigItem() SettingsConfigItem::~SettingsConfigItem() { - if( IsModified() ) - Commit(); + assert(!IsModified()); // should have been committed } void SettingsConfigItem::ImplCommit() |