diff options
| author | Noel Grandin <noel@peralex.com> | 2015-11-25 08:42:22 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-11-25 13:57:29 +0200 |
| commit | 1522d4b36aa4a8c6f61788b897c24ddfb065185b (patch) | |
| tree | a73772f50a4620c6fdb02a65f16794ba88592cc0 /vcl | |
| parent | a0d112a53023758a28d180ffd12766b4d325bf52 (diff) | |
loplugin:unusedfields in include/vcl
and fixed bug in sepia filter, where it was using the
wrong member of the union to get the percentage
Change-Id: I56b76496a3ac711adec12dd8c08b28d69644d66f
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/gdi/animate.cxx | 1 | ||||
| -rw-r--r-- | vcl/source/gdi/bitmap4.cxx | 6 | ||||
| -rw-r--r-- | vcl/source/window/builder.cxx | 2 | ||||
| -rw-r--r-- | vcl/source/window/dockmgr.cxx | 2 |
4 files changed, 3 insertions, 8 deletions
diff --git a/vcl/source/gdi/animate.cxx b/vcl/source/gdi/animate.cxx index 911e0ca0a051..d6d9ea1071c7 100644 --- a/vcl/source/gdi/animate.cxx +++ b/vcl/source/gdi/animate.cxx @@ -802,7 +802,6 @@ SvStream& ReadAnimation( SvStream& rIStm, Animation& rAnimation ) AInfo::AInfo() : pOutDev( nullptr ), pViewData( nullptr ), nExtraData( 0L ), - bWithSize( false ), bPause( false ) {} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/source/gdi/bitmap4.cxx b/vcl/source/gdi/bitmap4.cxx index 3d56db313825..2b5723cc1af7 100644 --- a/vcl/source/gdi/bitmap4.cxx +++ b/vcl/source/gdi/bitmap4.cxx @@ -678,16 +678,14 @@ bool Bitmap::ImplSepia( const BmpFilterParam* pFilterParam ) if( pReadAcc ) { long nSepiaPercent = ( pFilterParam && pFilterParam->meFilter == BMP_FILTER_SEPIA ) ? - pFilterParam->mcSolarGreyThreshold : 10; + pFilterParam->mnSepiaPercent : 10; const long nSepia = 10000 - 100 * SAL_BOUND( nSepiaPercent, 0, 100 ); BitmapPalette aSepiaPal( 256 ); - DBG_ASSERT( nSepiaPercent <= 100, "Bitmap::ImplSepia(): sepia value out of range; defaulting to 100%" ); - for( sal_uInt16 i = 0; i < 256; i++ ) { BitmapColor& rCol = aSepiaPal[ i ]; - const sal_uInt8 cSepiaValue = (sal_uInt8) ( ( nSepia * i ) / 10000 ); + const sal_uInt8 cSepiaValue = (sal_uInt8) ( nSepia * i / 10000 ); rCol.SetRed( (sal_uInt8) i ); rCol.SetGreen( cSepiaValue ); diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index 11efd79cc089..2ee7ab9dc1ac 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -2572,7 +2572,7 @@ void VclBuilder::handleMenuObject(PopupMenu *pParent, xmlreader::XmlReader &read void VclBuilder::handleSizeGroup(xmlreader::XmlReader &reader, const OString &rID) { - m_pParserState->m_aSizeGroups.push_back(SizeGroup(rID)); + m_pParserState->m_aSizeGroups.push_back(SizeGroup()); SizeGroup &rSizeGroup = m_pParserState->m_aSizeGroups.back(); int nLevel = 1; diff --git a/vcl/source/window/dockmgr.cxx b/vcl/source/window/dockmgr.cxx index 20950c6f23e6..305878e74a53 100644 --- a/vcl/source/window/dockmgr.cxx +++ b/vcl/source/window/dockmgr.cxx @@ -811,10 +811,8 @@ ImplDockingWindowWrapper::ImplDockingWindowWrapper( const vcl::Window *pWindow ) , mbFloatPrevented(false) , mbDockable(true) , mbDocking(false) - , mbDragFull(false) , mbLastFloatMode(false) , mbStartFloat(false) - , mbTrackDock(false) , mbPinned(false) , mbRollUp(false) , mbDockBtn(false) |