diff options
| author | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-10-30 16:49:11 +0000 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-10-31 06:16:19 +0100 |
| commit | 0bd5b0f92c10db2da04ad8ee7de8e11534df046e (patch) | |
| tree | 85046bf0f35a6d4cc58b404d8be2c55a7d3918b0 /vcl | |
| parent | 2ecd5da533f8fc4229bb8a38167eb147c1213fa8 (diff) | |
ofz#63741 Unknown Read
this went wrong in
commit d97e0458914991214e3d396273862855aff66234
Date: Mon Oct 1 03:09:35 2018 +0200
vcl: no raw pointers
where
rJobData.SetDriverDataLen()
was dropped
in favour of using using nDriverDataLen, but missed replacing an interleaved
GetDriverDataLen() with nDriverDataLen
Change-Id: Iebc9145865fa4ec985bc2feed754c775d77011b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158671
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/gdi/jobset.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx index c9ed0d9626ec..19fa712ea658 100644 --- a/vcl/source/gdi/jobset.cxx +++ b/vcl/source/gdi/jobset.cxx @@ -297,7 +297,7 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) if ( nDriverDataLen ) { const char* pDriverData = reinterpret_cast<const char*>(pOldJobData) + nOldJobDataSize; - const char* pDriverDataEnd = pDriverData + rJobData.GetDriverDataLen(); + const char* pDriverDataEnd = pDriverData + nDriverDataLen; if (pDriverDataEnd > pTempBuf.get() + nRead) { SAL_WARN("vcl", "corrupted job setup"); |