summaryrefslogtreecommitdiff
path: root/vcl
diff options
context:
space:
mode:
authorTomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>2015-09-28 12:51:02 +0200
committerTomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>2015-09-28 17:02:09 +0200
commitd76c5aa78f0b9004c6719dcc4d2be052c0703ba5 (patch)
tree2f3c82ebe3fdd4c1ef72155f52154573eaf35055 /vcl
parentac84e4ff6135d51461122e0e1b5b39614b3e6eca (diff)
don't allocate (by eraseing) an un-initialized 1x1 virtual device
Change-Id: I11c7063d7ac689866461ceabf8648f1c3c7bb17d
Diffstat (limited to 'vcl')
-rw-r--r--vcl/source/gdi/virdev.cxx10
1 files changed, 6 insertions, 4 deletions
diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index b8dc0613fda4..7319a1f056af 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -129,6 +129,8 @@ void VirtualDevice::ImplInitVirDev( const OutputDevice* pOutDev,
{
SAL_INFO( "vcl.virdev", "ImplInitVirDev(" << nDX << "," << nDY << "," << nBitCount << ")" );
+ bool bErase = nDX > 0 && nDY > 0;
+
if ( nDX < 1 )
nDX = 1;
@@ -191,7 +193,7 @@ void VirtualDevice::ImplInitVirDev( const OutputDevice* pOutDev,
SetBackground( Wallpaper( Color( COL_WHITE ) ) );
// #i59283# don't erase user-provided surface
- if( !pData )
+ if( !pData && bErase)
Erase();
// register VirDev in the list
@@ -212,7 +214,7 @@ VirtualDevice::VirtualDevice( sal_uInt16 nBitCount )
"VirtualDevice::VirtualDevice(): Only 0, 1 or 8 allowed for BitCount, not " << nBitCount );
SAL_INFO( "vcl.gdi", "VirtualDevice::VirtualDevice( " << nBitCount << " )" );
- ImplInitVirDev( Application::GetDefaultDevice(), 1, 1, nBitCount );
+ ImplInitVirDev( Application::GetDefaultDevice(), 0, 0, nBitCount );
}
VirtualDevice::VirtualDevice( const OutputDevice& rCompDev, sal_uInt16 nBitCount )
@@ -223,7 +225,7 @@ VirtualDevice::VirtualDevice( const OutputDevice& rCompDev, sal_uInt16 nBitCount
"VirtualDevice::VirtualDevice(): Only 0, 1 or 8 allowed for BitCount, not " << nBitCount );
SAL_INFO( "vcl.gdi", "VirtualDevice::VirtualDevice( " << nBitCount << " )" );
- ImplInitVirDev( &rCompDev, 1, 1, nBitCount );
+ ImplInitVirDev( &rCompDev, 0, 0, nBitCount );
}
VirtualDevice::VirtualDevice( const OutputDevice& rCompDev, sal_uInt16 nBitCount, sal_uInt16 nAlphaBitCount )
@@ -235,7 +237,7 @@ VirtualDevice::VirtualDevice( const OutputDevice& rCompDev, sal_uInt16 nBitCount
SAL_INFO( "vcl.gdi",
"VirtualDevice::VirtualDevice( " << nBitCount << ", " << nAlphaBitCount << " )" );
- ImplInitVirDev( &rCompDev, 1, 1, nBitCount );
+ ImplInitVirDev( &rCompDev, 0, 0, nBitCount );
// Enable alpha channel
mnAlphaDepth = sal::static_int_cast<sal_Int8>(nAlphaBitCount);