loplugin:constparams handle constructors

had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis

Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

9 files changed, 13 insertions, 13 deletions

diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 6c78ca519a1f..32c67d1f8e8a 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -198,7 +198,7 @@ private:
 class VCL_DLLPUBLIC FreetypeFontInstance : public LogicalFontInstance
 {
 public:
-                            FreetypeFontInstance( FontSelectPattern& );
+                            FreetypeFontInstance( FontSelectPattern const & );
     virtual                 ~FreetypeFontInstance() override;
 
     void                    SetFreetypeFont(FreetypeFont* p);
diff --git a/vcl/opengl/PackedTextureAtlas.cxx b/vcl/opengl/PackedTextureAtlas.cxx
index bd1b829427da..ee1ca827ccc7 100644
--- a/vcl/opengl/PackedTextureAtlas.cxx
+++ b/vcl/opengl/PackedTextureAtlas.cxx
@@ -26,7 +26,7 @@ struct Node
     bool mOccupied;
 
     explicit Node(int nWidth, int nHeight);
-    explicit Node(tools::Rectangle& aRectangle);
+    explicit Node(tools::Rectangle const & aRectangle);
 
     bool isLeaf();
     Node* insert(int nWidth, int nHeight, int nPadding);
@@ -39,7 +39,7 @@ Node::Node(int nWidth, int nHeight)
     , mOccupied(false)
 {}
 
-Node::Node(tools::Rectangle& aRectangle)
+Node::Node(tools::Rectangle const & aRectangle)
     : mRectangle(aRectangle)
     , mLeftNode()
     , mRightNode()
diff --git a/vcl/source/filter/FilterConfigItem.cxx b/vcl/source/filter/FilterConfigItem.cxx
index 2047ff882215..b0458df5430f 100644
--- a/vcl/source/filter/FilterConfigItem.cxx
+++ b/vcl/source/filter/FilterConfigItem.cxx
@@ -144,7 +144,7 @@ FilterConfigItem::FilterConfigItem( const OUString& rSubTree )
     ImpInitTree( rSubTree );
 }
 
-FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValue >* pFilterData )
+FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValue > const * pFilterData )
     : bModified(false)
 {
     if ( pFilterData )
@@ -152,7 +152,7 @@ FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValu
 }
 
 FilterConfigItem::FilterConfigItem( const OUString& rSubTree,
-    css::uno::Sequence< css::beans::PropertyValue >* pFilterData )
+    css::uno::Sequence< css::beans::PropertyValue > const * pFilterData )
 {
     ImpInitTree( rSubTree );
 
diff --git a/vcl/source/filter/graphicfilter.cxx b/vcl/source/filter/graphicfilter.cxx
index b99d5e0c8490..23070eb10622 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -2030,7 +2030,7 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& rGraphic, const OUString& r
     if( nFormat >= nFormatCount )
         return ImplSetError( ERRCODE_GRFILTER_FORMATERROR );
 
-    FilterConfigItem aConfigItem( const_cast<css::uno::Sequence< css::beans::PropertyValue >*>(pFilterData) );
+    FilterConfigItem aConfigItem( pFilterData );
     OUString aFilterName( pConfig->GetExportFilterName( nFormat ) );
 #ifndef DISABLE_DYNLOADING
     OUString aExternalFilterName(pConfig->GetExternalFilterName(nFormat, true));
diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx b/vcl/source/filter/ipdf/pdfdocument.cxx
index f6a8de05363c..a7ad2c73c897 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -2727,7 +2727,7 @@ PDFDocument& PDFObjectElement::GetDocument()
     return m_rDoc;
 }
 
-PDFReferenceElement::PDFReferenceElement(PDFDocument& rDoc, PDFNumberElement& rObject, PDFNumberElement& rGeneration)
+PDFReferenceElement::PDFReferenceElement(PDFDocument& rDoc, PDFNumberElement& rObject, PDFNumberElement const & rGeneration)
     : m_rDoc(rDoc),
       m_fObjectValue(rObject.GetValue()),
       m_fGenerationValue(rGeneration.GetValue()),
diff --git a/vcl/source/filter/jpeg/JpegWriter.cxx b/vcl/source/filter/jpeg/JpegWriter.cxx
index eff1bacd2ddb..1cf302312b22 100644
--- a/vcl/source/filter/jpeg/JpegWriter.cxx
+++ b/vcl/source/filter/jpeg/JpegWriter.cxx
@@ -109,7 +109,7 @@ JPEGWriter::JPEGWriter( SvStream& rStream, const css::uno::Sequence< css::beans:
     mbNative     ( false ),
     mpExpWasGrey ( pExportWasGrey )
 {
-    FilterConfigItem aConfigItem( const_cast<css::uno::Sequence< css::beans::PropertyValue >*>(pFilterData) );
+    FilterConfigItem aConfigItem( pFilterData );
     mbGreys = aConfigItem.ReadInt32( "ColorMode", 0 ) != 0;
     mnQuality = aConfigItem.ReadInt32( "Quality", 75 );
     maChromaSubsampling = aConfigItem.ReadInt32( "ChromaSubsamplingMode", 0 );
diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index 071435544097..40ad7f23034d 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -718,7 +718,7 @@ struct LinearScaleContext
     std::unique_ptr<long[]> mpMapXOffset;
     std::unique_ptr<long[]> mpMapYOffset;
 
-    LinearScaleContext(tools::Rectangle& aDstRect, tools::Rectangle& aBitmapRect,
+    LinearScaleContext(tools::Rectangle const & aDstRect, tools::Rectangle& aBitmapRect,
                  Size& aOutSize, long nOffX, long nOffY)
 
         : mpMapX(new long[aDstRect.GetWidth()])
@@ -882,7 +882,7 @@ struct TradScaleContext
     std::unique_ptr<long[]> mpMapX;
     std::unique_ptr<long[]> mpMapY;
 
-    TradScaleContext(tools::Rectangle& aDstRect, tools::Rectangle& aBitmapRect,
+    TradScaleContext(tools::Rectangle const & aDstRect, tools::Rectangle& aBitmapRect,
                  Size& aOutSize, long nOffX, long nOffY)
 
         : mpMapX(new long[aDstRect.GetWidth()])
diff --git a/vcl/unx/generic/glyphs/glyphcache.cxx b/vcl/unx/generic/glyphs/glyphcache.cxx
index 5ca4abed98fe..c4c54ad0dffe 100644
--- a/vcl/unx/generic/glyphs/glyphcache.cxx
+++ b/vcl/unx/generic/glyphs/glyphcache.cxx
@@ -349,7 +349,7 @@ void FreetypeFont::GarbageCollect( long nMinLruIndex )
     }
 }
 
-FreetypeFontInstance::FreetypeFontInstance( FontSelectPattern& rFSD )
+FreetypeFontInstance::FreetypeFontInstance( FontSelectPattern const & rFSD )
 :   LogicalFontInstance( rFSD )
 ,   mpFreetypeFont( nullptr )
 {}
diff --git a/vcl/unx/generic/print/genprnpsp.cxx b/vcl/unx/generic/print/genprnpsp.cxx
index d400e1d8178b..df5ea054809a 100644
--- a/vcl/unx/generic/print/genprnpsp.cxx
+++ b/vcl/unx/generic/print/genprnpsp.cxx
@@ -99,7 +99,7 @@ namespace
 
     public:
         // parent window, Query text, initial value
-        QueryString(vcl::Window*, OUString &, OUString &);
+        QueryString(vcl::Window*, OUString const &, OUString &);
         virtual ~QueryString() override { disposeOnce(); }
         virtual void dispose() override
         {
@@ -113,7 +113,7 @@ namespace
     /*
      *  QueryString
      */
-    QueryString::QueryString(vcl::Window* pParent, OUString& rQuery, OUString& rRet)
+    QueryString::QueryString(vcl::Window* pParent, OUString const & rQuery, OUString& rRet)
         : ModalDialog(pParent, "QueryDialog",
             "vcl/ui/querydialog.ui" )
         , m_rReturnValue( rRet )