diff options
| author | Tor Lillqvist <tml@iki.fi> | 2013-04-06 13:50:26 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@iki.fi> | 2013-04-07 01:13:33 +0300 |
| commit | 4478145e7be87be9df6b38f44b5cf3ad44cf03a2 (patch) | |
| tree | 85e580654cea6f66927226be94726d833b9acdf2 /vcl | |
| parent | ca9ceb2011d4597cee4df1987a9a806bc95a6f65 (diff) | |
Add comments to some questionable code
Change-Id: I06121b065f360ecfeddb25c9e1487f4849e453a2
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/aqua/source/gdi/atsui/salatslayout.cxx | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/vcl/aqua/source/gdi/atsui/salatslayout.cxx b/vcl/aqua/source/gdi/atsui/salatslayout.cxx index ec28a70fb493..ad62d0115355 100644 --- a/vcl/aqua/source/gdi/atsui/salatslayout.cxx +++ b/vcl/aqua/source/gdi/atsui/salatslayout.cxx @@ -452,6 +452,13 @@ void ATSLayout::DrawText( SalGraphics& rGraphics ) const } } +#if 1 + // I am not sure at all if this code actually is needed; putting + // it in #if 0 didn't seem to cause any immediately visible bad + // effect. Aybody know? But I guess, better safe than sorry, so + // let's keep it in for now. This ATSUI-using code is destined for + // the bin anyway... + // request an update of the changed window area if( rAquaGraphics.IsWindowGraphics() ) { @@ -462,6 +469,12 @@ void ATSLayout::DrawText( SalGraphics& rGraphics ) const { // FIXME: transformation from baseline to top left // with the simple approach below we invalidate too much + + // Indeed, this simply triples the rectangle's height, + // enlarging it on top and bottom with its old height!? Is + // that really necessary? (Sure, it can't harm, but it + // seems silly. But OTOH, see comment above.) + short d = drawRect.bottom - drawRect.top; drawRect.top -= d; drawRect.bottom += d; @@ -472,7 +485,7 @@ void ATSLayout::DrawText( SalGraphics& rGraphics ) const rAquaGraphics.RefreshRect( aRect ); } } - +#endif // restore the original graphic context transformations CGContextRestoreGState( rAquaGraphics.mrContext ); } |