diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-03-02 10:13:53 +0000 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2022-03-09 09:17:22 +0100 |
| commit | 32c7ba7d654fd8dfd3ab5b02b5dd5cacdc83561a (patch) | |
| tree | 04e1b5c8c8adb7de8c0000d9044b08a9ce1ac928 /vcl | |
| parent | 9c5a509c9062c6a9ea060c894d55989a901b391a (diff) | |
ofz: detect endless loop in font processing
Change-Id: I4e6c61d8be15a560f43b5d37d646e7bad9739eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130778
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/fontsubset/sft.cxx | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx index 5f85c1b30673..8084bb247567 100644 --- a/vcl/source/fontsubset/sft.cxx +++ b/vcl/source/fontsubset/sft.cxx @@ -568,9 +568,9 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID, C if( std::find( glyphlist.begin(), glyphlist.end(), index ) != glyphlist.end() ) { -#if OSL_DEBUG_LEVEL > 1 - SAL_INFO("vcl.fonts", "Endless loop found in a compound glyph."); + SAL_WARN("vcl.fonts", "Endless loop found in a compound glyph."); +#if OSL_DEBUG_LEVEL > 1 std::ostringstream oss; oss << index << " -> ["; for( const auto& rGlyph : glyphlist ) @@ -581,6 +581,7 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID, C SAL_INFO("vcl.fonts", oss.str()); /**/ #endif + return 0; } glyphlist.push_back( index ); @@ -588,10 +589,8 @@ static int GetCompoundTTOutline(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID, C if ((np = GetTTGlyphOutline(ttf, index, &nextComponent, nullptr, &glyphlist)) == 0) { /* XXX that probably indicates a corrupted font */ -#if OSL_DEBUG_LEVEL > 1 SAL_WARN("vcl.fonts", "An empty compound!"); /* assert(!"An empty compound"); */ -#endif } if( ! glyphlist.empty() ) @@ -1513,6 +1512,12 @@ int GetTTGlyphComponents(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID, std::vec if (nptr <= ptr) return 0; + if (std::find(glyphlist.begin(), glyphlist.end(), glyphID) != glyphlist.end()) + { + SAL_WARN("vcl.fonts", "Endless loop found in a compound glyph."); + return 0; + } + glyphlist.push_back( glyphID ); sal_uInt32 nRemainingData = glyflength - nOffset; |