diff options
| author | Tor Lillqvist <tml@collabora.com> | 2015-02-23 14:42:08 +0200 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2015-02-23 15:30:42 +0200 |
| commit | 639730a75294346d4195539c26f466f14d030802 (patch) | |
| tree | d0081207e3471de04c6ea8892d790510bd534d13 /vcl | |
| parent | f4f08203ba4acebb4ae3143323ca508fdc0644bd (diff) | |
tdf#84881: Unclear what the PKIStatusInfo::statusString is
Anyway, we can't assume that a string from an external source is correctly
formed UTF-8.
Change-Id: Ic906c7047b933388d5b51b23095a5a3d4ac7e508
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/gdi/pdfwriter_impl.cxx | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index b0ec56894176..5f1be3ddd80a 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -6385,10 +6385,12 @@ OUString PKIStatusInfoToString(const PKIStatusInfo& rStatusInfo) result += PKIStatusToString(rStatusInfo.status.data[0]); else result += "unknown (len=" + OUString::number(rStatusInfo.status.len); - if (rStatusInfo.statusString.data != NULL) - result += ",statusString='" + - OUString::fromUtf8(OString(reinterpret_cast<const sal_Char*>(rStatusInfo.statusString.data), rStatusInfo.statusString.len)) + - "'"; + + // FIXME: Perhaps look at rStatusInfo.statusString.data but note + // that we of course can't assume it contains proper UTF-8. After + // all, it is data from an external source. Also, RFC3161 claims + // it should be a SEQUENCE (1..MAX) OF UTF8String, but another + // source claimed it would be a single UTF8String, hmm? // FIXME: Worth it to decode failInfo to cleartext, probably not at least as long as this is only for a SAL_INFO |