diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2022-07-13 10:23:59 +0200 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2022-07-13 12:04:22 +0200 |
| commit | ca1b528972235c16dab74e3662ff768c68a6cc38 (patch) | |
| tree | 50891b7570fe2d64c2aacc371b0e642d39d3877d /vcl | |
| parent | 454e182898cdf9c8a9ce1b575591910bbff3a762 (diff) | |
gtk3 a11y: Activate code that needs AtkRectangle
I don't see where `HAS_ATKRECTANGLE` would be defined,
not even in what we have as a single git commit that adds the
code:
commit 9b5df79fbd9e84ef9c2dde845867dbb1f98ac98a
Date: Fri May 5 09:55:52 2006 +0000
INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED
2006/03/31 14:09:17 obr 1.1.2.20: #i63580# AtkRectangle already in atk 1.7.0, but ATK_TYPE_RECTANGLE in 1.7.2
2006/03/31 12:19:39 obr 1.1.2.19: #i63583# eliminated warnings
2006/03/30 12:39:35 obr 1.1.2.18: #i63580# AtkRectangle not defined in older atk versions
[...]
The above extract from the commmit message as well as a quick
look into the corresponding OOo ticket [1] suggest that the only
concern were old ATK versions that didn't have `AtkRectangle` yet.
Since the code looks sane at a quick glance at the corresponding
ATK doc [2], just drop the `#ifdev HAS_ATKRECTANGLE` check
and enable this unconditionally.
(atk >= 2.28.1 is required by now, which definitely has
AtkRectangle.)
While at it, switch to the new style of using a dash
instead of an underscore in the signal name.
[1] https://bz.apache.org/ooo/show_bug.cgi?id=63580
[2] https://docs.gtk.org/atk/signal.Component.bounds-changed.html
Change-Id: If448c5e79df6f2dd38c3a9acd414cc778f4d1f3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137011
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/unx/gtk3/a11y/atklistener.cxx | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/vcl/unx/gtk3/a11y/atklistener.cxx b/vcl/unx/gtk3/a11y/atklistener.cxx index 0c6842ab130c..600bb2273881 100644 --- a/vcl/unx/gtk3/a11y/atklistener.cxx +++ b/vcl/unx/gtk3/a11y/atklistener.cxx @@ -486,7 +486,6 @@ void AtkListener::notifyEvent( const accessibility::AccessibleEventObject& aEven case accessibility::AccessibleEventId::BOUNDRECT_CHANGED: -#ifdef HAS_ATKRECTANGLE if( ATK_IS_COMPONENT( atk_obj ) ) { AtkRectangle rect; @@ -498,12 +497,10 @@ void AtkListener::notifyEvent( const accessibility::AccessibleEventObject& aEven &rect.height, ATK_XY_SCREEN ); - g_signal_emit_by_name( atk_obj, "bounds_changed", &rect ); + g_signal_emit_by_name( atk_obj, "bounds-changed", &rect ); } else - g_warning( "bounds_changed event for object not implementing AtkComponent\n"); -#endif - + g_warning( "bounds-changed event for object not implementing AtkComponent\n"); break; case accessibility::AccessibleEventId::VISIBLE_DATA_CHANGED: |