diff options
author | Armin Le Grand <alg@apache.org> | 2013-05-29 09:54:44 +0000 |
---|---|---|
committer | Armin Le Grand <alg@apache.org> | 2013-05-29 09:54:44 +0000 |
commit | d4b5b8bf22edc31f18232abd764edddb2ca19738 (patch) | |
tree | 2f8f4a527a204bcd674312f63284d25a0deb00d5 /vcl | |
parent | 8c142809c7e16853d5634487cc9ed4e53caa3f91 (diff) |
i121591 Corrected some transparent printing stuff for windows
Notes
Notes:
merged as: 8681545a76e71ceef95c8ec9cdb5d692fd1ce21e
Diffstat (limited to 'vcl')
-rw-r--r-- | vcl/source/gdi/outdev6.cxx | 10 | ||||
-rw-r--r-- | vcl/win/source/gdi/salgdi_gdiplus.cxx | 27 |
2 files changed, 35 insertions, 2 deletions
diff --git a/vcl/source/gdi/outdev6.cxx b/vcl/source/gdi/outdev6.cxx index e2e23ffa9535..fa097c846a45 100644 --- a/vcl/source/gdi/outdev6.cxx +++ b/vcl/source/gdi/outdev6.cxx @@ -302,8 +302,14 @@ void OutputDevice::DrawTransparent( const PolyPolygon& rPolyPoly, const double fTransparency = 0.01 * nTransparencePercent; if( mbFillColor ) { - // draw the transparent polygon - // NOTE: filled polygons are assumed to be drawn as if they were always closed + // #121591# + // CAUTION: Only non printing (pixel-renderer) VCL commands from OutputDevices + // should be used when printing. Normally this is avoided by the printer being + // non-AAed and thus e.g. on WIN GdiPlus calls are not used. It may be necessary + // to add (OUTDEV_PRINTER != meOutDevType) to the entering if statement, thus + // using the fallbacl some lines below (which is not very good, though). For + // now, WinSalGraphics::drawPolyPolygon will detect printer usage and correct + // the wrong mapping (see there for details) bDrawn = mpGraphics->DrawPolyPolygon( aB2DPolyPolygon, fTransparency, this ); } diff --git a/vcl/win/source/gdi/salgdi_gdiplus.cxx b/vcl/win/source/gdi/salgdi_gdiplus.cxx index 9a0c8c4d7609..7ed1a9ae5897 100644 --- a/vcl/win/source/gdi/salgdi_gdiplus.cxx +++ b/vcl/win/source/gdi/salgdi_gdiplus.cxx @@ -178,6 +178,33 @@ bool WinSalGraphics::drawPolyPolygon( const ::basegfx::B2DPolyPolygon& rPolyPoly aGraphics.SetSmoothingMode(Gdiplus::SmoothingModeNone); } + if(mbPrinter) + { + // #121591# + // Normally GdiPlus should not be used for printing at all since printers cannot + // print transparent filled polygon geometry and normally this does not happen + // since OutputDevice::RemoveTransparenciesFromMetaFile is used as preparation + // and no transparent parts should remain for printing. But this can be overriden + // by the user and thus happens. This call can only come (currently) from + // OutputDevice::DrawTransparent, see comments sthere with the same TaskID. + // If it is used, the mapping for the printer is wrong and needs to be corrected. I + // checked that there is *no* transformation set (testcode commented out below) and + // estimated that a stable factor dependent of the printer's DPI is used. Create + // and set a transformation here to correct this + const Gdiplus::REAL aDpiX(aGraphics.GetDpiX()); + const Gdiplus::REAL aDpiY(aGraphics.GetDpiY()); + + // test code to check the current transformation at the graphics device + //Gdiplus::Matrix matrix; + //aGraphics.GetTransform(&matrix); + //Gdiplus::REAL elements[6]; + //matrix.GetElements(elements); + + Gdiplus::Matrix aPrinterTransform; + aPrinterTransform.Scale(Gdiplus::REAL(100.0) / aDpiX, Gdiplus::REAL(100.0) / aDpiY); + aGraphics.SetTransform(&aPrinterTransform); + } + aGraphics.FillPath(&aTestBrush, &aPath); } |