new loplugin:moveit

look for local variables that can be std::move'd to parameters

off by default, since it doesn't do proper data flow analysis

Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 7 insertions, 7 deletions

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index c4e3d23660c6..25885ce11aee 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -1459,7 +1459,8 @@ JSDrawingArea::JSDrawingArea(JSDialogSender* pSender, VclDrawingArea* pDrawingAr
                              SalInstanceBuilder* pBuilder, const a11yref& rAlly,
                              FactoryFunction pUITestFactoryFunction, void* pUserData)
     : JSWidget<SalInstanceDrawingArea, VclDrawingArea>(pSender, pDrawingArea, pBuilder, rAlly,
-                                                       pUITestFactoryFunction, pUserData, false)
+                                                       std::move(pUITestFactoryFunction), pUserData,
+                                                       false)
 {
 }
 
diff --git a/vcl/qt5/QtBitmap.cxx b/vcl/qt5/QtBitmap.cxx
index 0a9fb2b7812f..666cb673db65 100644
--- a/vcl/qt5/QtBitmap.cxx
+++ b/vcl/qt5/QtBitmap.cxx
@@ -53,7 +53,7 @@ bool QtBitmap::Create(const Size& rSize, vcl::PixelFormat ePixelFormat, const Bi
         QVector<QRgb> aColorTable(count);
         for (unsigned i = 0; i < count; ++i)
             aColorTable[i] = qRgb(rPal[i].GetRed(), rPal[i].GetGreen(), rPal[i].GetBlue());
-        m_pImage->setColorTable(aColorTable);
+        m_pImage->setColorTable(std::move(aColorTable));
     }
     return true;
 }
@@ -162,7 +162,7 @@ void QtBitmap::ReleaseBuffer(BitmapBuffer* pBuffer, BitmapAccessMode nMode)
         for (unsigned i = 0; i < count; ++i)
             aColorTable[i]
                 = qRgb(m_aPalette[i].GetRed(), m_aPalette[i].GetGreen(), m_aPalette[i].GetBlue());
-        m_pImage->setColorTable(aColorTable);
+        m_pImage->setColorTable(std::move(aColorTable));
     }
     delete pBuffer;
     if (nMode == BitmapAccessMode::Write)
diff --git a/vcl/source/control/fmtfield.cxx b/vcl/source/control/fmtfield.cxx
index 359856c64486..a88b6a9bbf00 100644
--- a/vcl/source/control/fmtfield.cxx
+++ b/vcl/source/control/fmtfield.cxx
@@ -1091,8 +1091,7 @@ void DoubleCurrencyField::UpdateCurrencyFormat()
      * there's
      * error: request for member 'getNumThousandSep' in 'aLocaleInfo', which is
      * of non-class type 'LocaleDataWrapper(LanguageTag)' */
-    LanguageTag aLanguageTag( eLanguage);
-    LocaleDataWrapper aLocaleInfo( aLanguageTag );
+    LocaleDataWrapper aLocaleInfo(( LanguageTag(eLanguage) ));
 
     OUStringBuffer sNewFormat;
     if (bThSep)
diff --git a/vcl/source/uitest/uno/uiobject_uno.cxx b/vcl/source/uitest/uno/uiobject_uno.cxx
index d64a595442a4..042b2fcf5cbb 100644
--- a/vcl/source/uitest/uno/uiobject_uno.cxx
+++ b/vcl/source/uitest/uno/uiobject_uno.cxx
@@ -138,7 +138,7 @@ void SAL_CALL UIObjectUnoObj::executeAction(const OUString& rAction, const css::
     };
 
     Notifier notifier;
-    ExecuteWrapper* pWrapper = new ExecuteWrapper(func, LINK(&notifier, Notifier, NotifyHdl));
+    ExecuteWrapper* pWrapper = new ExecuteWrapper(std::move(func), LINK(&notifier, Notifier, NotifyHdl));
     aIdle->SetInvokeHandler(LINK(pWrapper, ExecuteWrapper, ExecuteActionHdl));
     {
         SolarMutexGuard aGuard;
diff --git a/vcl/unx/generic/printer/cpdmgr.cxx b/vcl/unx/generic/printer/cpdmgr.cxx
index fdee9d5b70d6..e8b22111d584 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -125,7 +125,7 @@ void CPDManager::printerAdded (GDBusConnection *connection,
             g_free(contents);
             g_dbus_node_info_unref(introspection_data);
             std::pair<std::string, GDBusProxy *> new_backend (sender_name, proxy);
-            current->addBackend(new_backend);
+            current->addBackend(std::move(new_backend));
         }
     }
     CPDPrinter *pDest = static_cast<CPDPrinter *>(malloc(sizeof(CPDPrinter)));