diff options
author | Michael Weghorn <m.weghorn@posteo.de> | 2024-09-16 11:15:13 +0100 |
---|---|---|
committer | Michael Weghorn <m.weghorn@posteo.de> | 2024-09-17 07:50:45 +0200 |
commit | e20f03372bec243258c01d1098cb185138471cbc (patch) | |
tree | 5a2c61431352a86cb03d6b366d709d0b27d314de /winaccessibility/source/UAccCOM | |
parent | 397fb1a565199c0de34f373a7287476b8d51c1cb (diff) |
wina11y: Drop "//special query" comments
It's unclear to me what these
//special query
comments above the null checks refer to and I
find them more confusing than helpful.
Remove them.
Change-Id: I3a3d886a664d03ec37085e2f074928c2a3055820
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173441
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Diffstat (limited to 'winaccessibility/source/UAccCOM')
-rw-r--r-- | winaccessibility/source/UAccCOM/AccActionBase.cxx | 2 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccComponentBase.cxx | 3 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccEditableText.cxx | 3 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccHyperLink.cxx | 2 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccHypertext.cxx | 3 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccImage.cxx | 2 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccTable.cxx | 2 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccTextBase.cxx | 2 | ||||
-rw-r--r-- | winaccessibility/source/UAccCOM/AccValue.cxx | 3 |
9 files changed, 13 insertions, 9 deletions
diff --git a/winaccessibility/source/UAccCOM/AccActionBase.cxx b/winaccessibility/source/UAccCOM/AccActionBase.cxx index 391623f07034..81165464cc8b 100644 --- a/winaccessibility/source/UAccCOM/AccActionBase.cxx +++ b/winaccessibility/source/UAccCOM/AccActionBase.cxx @@ -199,9 +199,9 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccActionBase::put_XInterface(hyper pXInterfa CUNOXWrapper::put_XInterface(pXInterface); - //special query. if(pUNOInterface == nullptr) return E_FAIL; + Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); if( !pRContext.is() ) return E_FAIL; diff --git a/winaccessibility/source/UAccCOM/AccComponentBase.cxx b/winaccessibility/source/UAccCOM/AccComponentBase.cxx index f0a74a1d09aa..4b0cb4e8011d 100644 --- a/winaccessibility/source/UAccCOM/AccComponentBase.cxx +++ b/winaccessibility/source/UAccCOM/AccComponentBase.cxx @@ -130,9 +130,10 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccComponentBase::put_XInterface(hyper pXInte try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if (pUNOInterface == nullptr) return E_FAIL; + Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); if (!pRContext.is()) { diff --git a/winaccessibility/source/UAccCOM/AccEditableText.cxx b/winaccessibility/source/UAccCOM/AccEditableText.cxx index 212546e12ee0..01fd38fcea07 100644 --- a/winaccessibility/source/UAccCOM/AccEditableText.cxx +++ b/winaccessibility/source/UAccCOM/AccEditableText.cxx @@ -473,9 +473,10 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccEditableText::put_XInterface(hyper pXInter try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if(pUNOInterface == nullptr) return E_FAIL; + Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); if( !pRContext.is() ) { diff --git a/winaccessibility/source/UAccCOM/AccHyperLink.cxx b/winaccessibility/source/UAccCOM/AccHyperLink.cxx index dfd32ca8ef39..388058abaec7 100644 --- a/winaccessibility/source/UAccCOM/AccHyperLink.cxx +++ b/winaccessibility/source/UAccCOM/AccHyperLink.cxx @@ -263,7 +263,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccHyperLink::put_XInterface(hyper pXInterfac try { CAccActionBase::put_XInterface(pXInterface); - //special query. + if (pUNOInterface != nullptr) { Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); diff --git a/winaccessibility/source/UAccCOM/AccHypertext.cxx b/winaccessibility/source/UAccCOM/AccHypertext.cxx index 039a57667df4..b6b09a8b6c4f 100644 --- a/winaccessibility/source/UAccCOM/AccHypertext.cxx +++ b/winaccessibility/source/UAccCOM/AccHypertext.cxx @@ -374,9 +374,10 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccHypertext::put_XInterface(hyper pXInterfac try { CAccTextBase::put_XInterface(pXInterface); - //special query. + if (pUNOInterface == nullptr) return E_FAIL; + Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); if (!pRContext.is()) { diff --git a/winaccessibility/source/UAccCOM/AccImage.cxx b/winaccessibility/source/UAccCOM/AccImage.cxx index faabffe331e4..bf53f440d98a 100644 --- a/winaccessibility/source/UAccCOM/AccImage.cxx +++ b/winaccessibility/source/UAccCOM/AccImage.cxx @@ -86,7 +86,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccImage::put_XInterface(hyper pXInterface) try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if (pUNOInterface == nullptr) return E_FAIL; diff --git a/winaccessibility/source/UAccCOM/AccTable.cxx b/winaccessibility/source/UAccCOM/AccTable.cxx index b142b525bb32..f5b45e0d4f52 100644 --- a/winaccessibility/source/UAccCOM/AccTable.cxx +++ b/winaccessibility/source/UAccCOM/AccTable.cxx @@ -804,7 +804,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccTable::put_XInterface(hyper pXInterface) try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if(pUNOInterface == nullptr) return E_INVALIDARG; diff --git a/winaccessibility/source/UAccCOM/AccTextBase.cxx b/winaccessibility/source/UAccCOM/AccTextBase.cxx index 620fa18b6925..8cb082d29192 100644 --- a/winaccessibility/source/UAccCOM/AccTextBase.cxx +++ b/winaccessibility/source/UAccCOM/AccTextBase.cxx @@ -778,7 +778,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccTextBase::put_XInterface(hyper pXInterface try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if(pUNOInterface == nullptr) return E_FAIL; Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); diff --git a/winaccessibility/source/UAccCOM/AccValue.cxx b/winaccessibility/source/UAccCOM/AccValue.cxx index 8465fb5718f7..b24b523008cc 100644 --- a/winaccessibility/source/UAccCOM/AccValue.cxx +++ b/winaccessibility/source/UAccCOM/AccValue.cxx @@ -213,9 +213,10 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP CAccValue::put_XInterface(hyper pXInterface) try { CUNOXWrapper::put_XInterface(pXInterface); - //special query. + if (pUNOInterface == nullptr) return E_FAIL; + Reference<XAccessibleContext> pRContext = pUNOInterface->getAccessibleContext(); if (!pRContext.is()) { |