diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2022-08-05 11:41:53 +0100 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2022-08-05 16:38:18 +0200 |
| commit | f03b908e285ad65fa4518f26862454c51efb54a8 (patch) | |
| tree | c3c7307f8488b02b07169c55e7587509a19961ce /winaccessibility/source/UAccCOMIDL | |
| parent | 0c3a159807965fa7db548a943a8d67d8bad5b208 (diff) | |
wina11y: Drop extra location bookkeeping
The location is already retrieved on demand from the
underlying `XAccessible` in `CMAccessible::accLocation`
and the separately remembered location was just used
as fallback in case `m_xAccessible` was not (no more)
set.
However, when there is no valid associated `XAccessible`,
there is probably no value in returning any location
anyway, so just return `S_FALSE` for that case, as
other `CMAccessible` methods also do.
Whether the separately remembered `m_sLocation`
was up to date is also questionable, s.a.
Change-Id I04d0230d3599466aaa92082caba54da22a3b1a28,
"wina11y: Drop AccObjectManagerAgent::UpdateLocation".
This is also in line with what's mentioned in
commit fcf4a26275d7503835f9aa23cb94938809840300
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jan 5 13:41:53 2022 +0000
tdf#146306 wina11y: Retrieve accessible desc on demand
> Querying up-to-date values from the underlying
> UNO interfaces on demand instead of doing extra
> manual bookkeeping in the winaccessibility code
> may be possible for more a11y attributes in addition
> to the accessible description handled in this commit,
> but each one will have to be looked at separately.
Change-Id: I2fc51939a5db1896e02efacb1cf5fbc90ce87c04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137858
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'winaccessibility/source/UAccCOMIDL')
| -rw-r--r-- | winaccessibility/source/UAccCOMIDL/UAccCOM.idl | 1 | ||||
| -rw-r--r-- | winaccessibility/source/UAccCOMIDL/defines.idl | 7 |
2 files changed, 0 insertions, 8 deletions
diff --git a/winaccessibility/source/UAccCOMIDL/UAccCOM.idl b/winaccessibility/source/UAccCOMIDL/UAccCOM.idl index f48b66ddd227..4befd13de0bc 100644 --- a/winaccessibility/source/UAccCOMIDL/UAccCOM.idl +++ b/winaccessibility/source/UAccCOMIDL/UAccCOM.idl @@ -38,7 +38,6 @@ import "defines.idl"; [id(4), helpstring("method IncreaseState")] HRESULT IncreaseState(DWORD pXSate); [id(6), helpstring("method Put_XAccValue")] HRESULT Put_XAccValue(const OLECHAR* pszAccValue); [id(7), helpstring("method SetState")] HRESULT SetState(DWORD pXSate); - [id(8), helpstring("method Put_XAccLocation")] HRESULT Put_XAccLocation(const Location sLocation); [id(9), helpstring("method Put_XAccFocus")] HRESULT Put_XAccFocus(long dChildID); [id(10), helpstring("method Put_XAccParent")] HRESULT Put_XAccParent(IMAccessible* pIParent); [id(13), helpstring("method Put_XAccWindowHandle")] HRESULT Put_XAccWindowHandle(HWND hwnd); diff --git a/winaccessibility/source/UAccCOMIDL/defines.idl b/winaccessibility/source/UAccCOMIDL/defines.idl index 2902b4f920ff..844262cb017c 100644 --- a/winaccessibility/source/UAccCOMIDL/defines.idl +++ b/winaccessibility/source/UAccCOMIDL/defines.idl @@ -30,11 +30,4 @@ typedef struct { IMAccessible* m_pIMAccessible; }AccChildNode; -typedef struct Location { - long m_dLeft; - long m_dTop; - long m_dWidth; - long m_dHeight; -}Location; - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |