diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-02 15:10:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-03 08:07:41 +0100 |
| commit | acdba3c2eee18ef0c079b7c41cd4165e06c956c7 (patch) | |
| tree | 18c6da7b7d46bf901b6dd4f7a5b280caa7f62280 /writerfilter/source | |
| parent | f4bd9029ba7b500ebf99b7fa3d774de7fa029176 (diff) | |
loplugin:passstuffbyref more return improvements
slightly less restrictive check when calling functions
Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'writerfilter/source')
| -rw-r--r-- | writerfilter/source/dmapper/TableData.hxx | 2 | ||||
| -rw-r--r-- | writerfilter/source/ooxml/OOXMLPropertySet.cxx | 2 | ||||
| -rw-r--r-- | writerfilter/source/ooxml/OOXMLPropertySet.hxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/writerfilter/source/dmapper/TableData.hxx b/writerfilter/source/dmapper/TableData.hxx index de30d2247a63..a3614b953605 100644 --- a/writerfilter/source/dmapper/TableData.hxx +++ b/writerfilter/source/dmapper/TableData.hxx @@ -352,7 +352,7 @@ public: @param i index of the row */ - const RowPointer_t getRow(unsigned int i) const + RowPointer_t const & getRow(unsigned int i) const { return mRows[i]; } diff --git a/writerfilter/source/ooxml/OOXMLPropertySet.cxx b/writerfilter/source/ooxml/OOXMLPropertySet.cxx index 286da4fb040e..195d75b83185 100644 --- a/writerfilter/source/ooxml/OOXMLPropertySet.cxx +++ b/writerfilter/source/ooxml/OOXMLPropertySet.cxx @@ -224,7 +224,7 @@ OOXMLValue::Pointer_t const & OOXMLBooleanValue::Create(bool bValue) return bValue ? True : False; } -OOXMLValue::Pointer_t OOXMLBooleanValue::Create(const char *pValue) +OOXMLValue::Pointer_t const & OOXMLBooleanValue::Create(const char *pValue) { return Create (GetBooleanValue(pValue)); } diff --git a/writerfilter/source/ooxml/OOXMLPropertySet.hxx b/writerfilter/source/ooxml/OOXMLPropertySet.hxx index c6b664f59b90..fbedaeda6498 100644 --- a/writerfilter/source/ooxml/OOXMLPropertySet.hxx +++ b/writerfilter/source/ooxml/OOXMLPropertySet.hxx @@ -92,7 +92,7 @@ class OOXMLBooleanValue : public OOXMLValue explicit OOXMLBooleanValue(bool bValue); public: static OOXMLValue::Pointer_t const & Create (bool bValue); - static OOXMLValue::Pointer_t Create (const char *pValue); + static OOXMLValue::Pointer_t const & Create (const char *pValue); virtual ~OOXMLBooleanValue() override; |