diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-03-11 11:06:57 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-03-25 07:19:13 +0100 |
| commit | b1cfdb7bee4f7af97af54e6abbc5d04aed4ba082 (patch) | |
| tree | 8211ea564e36152b9eeb7be7212342d9e82800c6 /writerfilter | |
| parent | 26b81b23f0ad061b6d44fcea3e07ae4b18a63f94 (diff) | |
new loplugin:unoquery
look for places we are doing code like:
Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty()
which might result in a SIGSEGV is the query fails
Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e
Reviewed-on: https://gerrit.libreoffice.org/69044
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'writerfilter')
| -rw-r--r-- | writerfilter/source/dmapper/ModelEventListener.cxx | 6 | ||||
| -rw-r--r-- | writerfilter/source/rtftok/rtfdispatchdestination.cxx | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/writerfilter/source/dmapper/ModelEventListener.cxx b/writerfilter/source/dmapper/ModelEventListener.cxx index b3a73cc6b9de..bc2286d69dea 100644 --- a/writerfilter/source/dmapper/ModelEventListener.cxx +++ b/writerfilter/source/dmapper/ModelEventListener.cxx @@ -56,8 +56,8 @@ void ModelEventListener::notifyEvent( const document::EventObject& rEvent ) try { //remove listener - uno::Reference<document::XEventBroadcaster>(rEvent.Source, uno::UNO_QUERY )->removeEventListener( - uno::Reference<document::XEventListener>(this)); + uno::Reference<document::XEventBroadcaster>(rEvent.Source, uno::UNO_QUERY_THROW )->removeEventListener( + uno::Reference<document::XEventListener>(this)); // If we have PAGEREF fields, update fields as well. uno::Reference<text::XTextFieldsSupplier> xTextFieldsSupplier(rEvent.Source, uno::UNO_QUERY); @@ -107,7 +107,7 @@ void ModelEventListener::disposing( const lang::EventObject& rEvent ) { try { - uno::Reference<document::XEventBroadcaster>(rEvent.Source, uno::UNO_QUERY )->removeEventListener( + uno::Reference<document::XEventBroadcaster>(rEvent.Source, uno::UNO_QUERY_THROW )->removeEventListener( uno::Reference<document::XEventListener>(this)); } catch( const uno::Exception& ) diff --git a/writerfilter/source/rtftok/rtfdispatchdestination.cxx b/writerfilter/source/rtftok/rtfdispatchdestination.cxx index 773138c27e86..fa93abb624b3 100644 --- a/writerfilter/source/rtftok/rtfdispatchdestination.cxx +++ b/writerfilter/source/rtftok/rtfdispatchdestination.cxx @@ -601,7 +601,7 @@ RTFError RTFDocumentImpl::dispatchDestination(RTFKeyword nKeyword) { uno::Reference<drawing::XShape> xShape(xGroupShape, uno::UNO_QUERY); // set default VertOrient before inserting - uno::Reference<beans::XPropertySet>(xShape, uno::UNO_QUERY) + uno::Reference<beans::XPropertySet>(xShape, uno::UNO_QUERY_THROW) ->setPropertyValue("VertOrient", uno::makeAny(text::VertOrientation::NONE)); xDrawSupplier->getDrawPage()->add(xShape); |