diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /writerfilter | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'writerfilter')
| -rw-r--r-- | writerfilter/source/dmapper/DomainMapper_Impl.cxx | 4 | ||||
| -rw-r--r-- | writerfilter/source/dmapper/DomainMapper_Impl.hxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index d1d0309a6b83..9ec336f263eb 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -4553,7 +4553,7 @@ void DomainMapper_Impl::handleAutoNum } void DomainMapper_Impl::handleAuthor - (OUString const& rFirstParam, + (std::u16string_view rFirstParam, uno::Reference< beans::XPropertySet > const& xFieldProperties, FieldId eFieldId ) { @@ -4561,7 +4561,7 @@ void DomainMapper_Impl::handleAuthor xFieldProperties->setPropertyValue ( getPropertyName(PROP_FULL_NAME), uno::makeAny( true )); - if (!rFirstParam.isEmpty()) + if (!rFirstParam.empty()) { xFieldProperties->setPropertyValue( getPropertyName( PROP_IS_FIXED ), diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 575f6fd1876f..e3501da2d342 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -833,7 +833,7 @@ public: css::uno::Reference< css::uno::XInterface > const & xFieldInterface, css::uno::Reference< css::beans::XPropertySet > const& xFieldProperties); static void handleAuthor - (OUString const& rFirstParam, + (std::u16string_view rFirstParam, css::uno::Reference< css::beans::XPropertySet > const& xFieldProperties, FieldId eFieldId); void handleDocProperty |