summaryrefslogtreecommitdiff
path: root/writerfilter
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-09-23 08:48:06 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-09-27 11:48:46 +0200
commit1534025a0386584a7b8f3f929b10ce5eb33257cf (patch)
tree7f12dd6763148089cd4fb5495c8fffe84f415e12 /writerfilter
parent0f2e01677cd0e8857faec99c61d71e88eee78b27 (diff)
loplugin:methodcycles more graph theory for the win
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'writerfilter')
-rw-r--r--writerfilter/source/dmapper/DomainMapperTableManager.hxx8
-rw-r--r--writerfilter/source/dmapper/TableManager.cxx13
-rw-r--r--writerfilter/source/dmapper/TableManager.hxx8
-rw-r--r--writerfilter/source/ooxml/OOXMLFastContextHandler.cxx15
-rw-r--r--writerfilter/source/ooxml/OOXMLFastContextHandler.hxx2
5 files changed, 0 insertions, 46 deletions
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.hxx b/writerfilter/source/dmapper/DomainMapperTableManager.hxx
index b9970f6a6b42..cf130a021462 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.hxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.hxx
@@ -111,14 +111,6 @@ public:
TableManager::cellProps( pProps );
};
- virtual void cellPropsByCell(unsigned int i, const TablePropertyMapPtr& pProps) override
- {
- if ( m_pStyleProps.get( ) )
- m_pStyleProps->InsertProps(pProps.get());
- else
- TableManager::cellPropsByCell( i, pProps );
- };
-
virtual void insertRowProps(const TablePropertyMapPtr& pProps) override
{
if ( m_pStyleProps.get( ) )
diff --git a/writerfilter/source/dmapper/TableManager.cxx b/writerfilter/source/dmapper/TableManager.cxx
index bfe8618c8de8..aa173cbffa2f 100644
--- a/writerfilter/source/dmapper/TableManager.cxx
+++ b/writerfilter/source/dmapper/TableManager.cxx
@@ -94,19 +94,6 @@ void TableManager::insertRowProps(const TablePropertyMapPtr& pProps)
#endif
}
-void TableManager::cellPropsByCell(unsigned int i, const TablePropertyMapPtr& pProps)
-{
-#ifdef DEBUG_WRITERFILTER
- TagLogger::getInstance().startElement("tablemanager.cellPropsByCell");
-#endif
-
- mTableDataStack.top()->insertCellProperties(i, pProps);
-
-#ifdef DEBUG_WRITERFILTER
- TagLogger::getInstance().endElement();
-#endif
-}
-
void TableManager::cellProps(const TablePropertyMapPtr& pProps)
{
#ifdef DEBUG_WRITERFILTER
diff --git a/writerfilter/source/dmapper/TableManager.hxx b/writerfilter/source/dmapper/TableManager.hxx
index 02839c681e29..15d9da8c3bc1 100644
--- a/writerfilter/source/dmapper/TableManager.hxx
+++ b/writerfilter/source/dmapper/TableManager.hxx
@@ -444,14 +444,6 @@ public:
virtual void cellProps(const TablePropertyMapPtr& pProps);
/**
- Handle properties of a certain cell in the current row.
-
- @paran i index of the cell in the current row
- @param pProps the properties
- */
- virtual void cellPropsByCell(unsigned int i, const TablePropertyMapPtr& pProps);
-
- /**
Handle properties of the current row.
@param pProps the properties
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index 3ebe463b6270..ff3da8a3ba5a 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -295,12 +295,6 @@ Token_t OOXMLFastContextHandler::getToken() const
return mnToken;
}
-void OOXMLFastContextHandler::setParent
-(OOXMLFastContextHandler * pParent)
-{
- mpParent = pParent;
-}
-
void OOXMLFastContextHandler::sendTableDepth() const
{
if (mnTableDepth > 0)
@@ -1113,15 +1107,6 @@ void OOXMLFastContextHandlerProperties::handleHyperlinkURL() {
getPropertySet()->resolve(aHyperlinkURLHandler);
}
-void OOXMLFastContextHandlerProperties::setParent
-(OOXMLFastContextHandler * pParent)
-{
- OOXMLFastContextHandler::setParent(pParent);
-
- if (mpParent->getResource() == STREAM)
- mbResolve = true;
-}
-
void OOXMLFastContextHandlerProperties::setPropertySet
(const OOXMLPropertySet::Pointer_t& pPropertySet)
{
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
index 68e5d8e8c36f..891b7644fada 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
@@ -119,7 +119,6 @@ public:
sal_Int32 getXNoteId() const;
void setForwardEvents(bool bForwardEvents);
bool isForwardEvents() const;
- virtual void setParent(OOXMLFastContextHandler * pParent);
virtual void setId(Id nId);
virtual Id getId() const;
@@ -298,7 +297,6 @@ protected:
OOXMLPropertySet::Pointer_t mpPropertySet;
virtual void lcl_endFastElement(Token_t Element) override;
- virtual void setParent(OOXMLFastContextHandler * pParent) override;
private: