diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /writerfilter | |
parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'writerfilter')
4 files changed, 0 insertions, 48 deletions
diff --git a/writerfilter/source/dmapper/TableManager.cxx b/writerfilter/source/dmapper/TableManager.cxx index 920a07d7c2fd..9047bea2bc65 100644 --- a/writerfilter/source/dmapper/TableManager.cxx +++ b/writerfilter/source/dmapper/TableManager.cxx @@ -170,11 +170,6 @@ void TableManager::handle0x7() #endif } -void TableManager::props(TablePropertyMapPtr pProps) -{ - setProps(pProps); -} - bool TableManager::sprm(Sprm& rSprm) { bool bRet = true; diff --git a/writerfilter/source/dmapper/TableManager.hxx b/writerfilter/source/dmapper/TableManager.hxx index 2f1c32d5df8d..9f120eccefdf 100644 --- a/writerfilter/source/dmapper/TableManager.hxx +++ b/writerfilter/source/dmapper/TableManager.hxx @@ -552,13 +552,6 @@ public: virtual bool sprm(Sprm & rSprm); /** - Handle properties at current handle. - - @param pProps the properites - */ - void props(TablePropertyMapPtr pProps); - - /** Handle occurrence of character 0x7. */ void handle0x7(); diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx index c87e9811b7fc..fe716446d28a 100644 --- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx +++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx @@ -281,20 +281,6 @@ const uno::Sequence< sal_Int8 > & OOXMLFastContextHandler::getUnoTunnelId() return theOOXMLFastContextHandlerUnoTunnelId::get().getSeq(); } -sal_Int64 SAL_CALL OOXMLFastContextHandler::getSomething( const uno::Sequence< sal_Int8 >& rId ) - throw(uno::RuntimeException) -{ - if( rId.getLength() == 16 - && 0 == memcmp( getUnoTunnelId().getConstArray(), - rId.getConstArray(), 16 ) ) - { - return sal::static_int_cast<sal_Int64> - (reinterpret_cast<sal_IntPtr>(this)); - } - - return 0x0; -} - void OOXMLFastContextHandler::setStream(Stream * pStream) { mpStream = pStream; @@ -355,12 +341,6 @@ void OOXMLFastContextHandler::setParent mpParent = pParent; } -OOXMLPropertySet * OOXMLFastContextHandler::getPicturePropSet -(const OUString & rId) -{ - return mpParserState->getDocument()->getPicturePropSet(rId); -} - void OOXMLFastContextHandler::sendTableDepth() const { if (mnTableDepth > 0) @@ -697,11 +677,6 @@ void OOXMLFastContextHandler::propagateCharacterPropertiesAsSet(const Id & rId) mpParserState->setCharacterProperties(pPropertySet); } -bool OOXMLFastContextHandler::propagatesProperties() const -{ - return false; -} - void OOXMLFastContextHandler::propagateCellProperties() { mpParserState->setCellProperties(getPropertySet()); @@ -1269,12 +1244,6 @@ void OOXMLFastContextHandlerTable::addCurrentChild() } } -void OOXMLFastContextHandlerTable::newPropertySet -(OOXMLPropertySet::Pointer_t /*pPropertySet*/) -{ - -} - /* class OOXMLFastContextHandlerXNote */ diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx index ae1b6258274e..4c980ce6240c 100644 --- a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx +++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx @@ -83,7 +83,6 @@ public: throw (css::uno::RuntimeException, css::xml::sax::SAXException, std::exception) SAL_OVERRIDE; static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); - sal_Int64 SAL_CALL getSomething(const css::uno::Sequence<sal_Int8> & rId) throw (css::uno::RuntimeException); // local @@ -187,7 +186,6 @@ public: void propagateTableProperties(); void propagateRowProperties(); void propagateCellProperties(); - bool propagatesProperties() const; void sendPropertiesWithId(const Id & rId); void sendPropertiesToParent(); void sendCellProperties(); @@ -234,8 +232,6 @@ protected: void startAction(Token_t Element); void endAction(Token_t Element); - OOXMLPropertySet * getPicturePropSet - (const OUString & rId); virtual void resolvePropertySetAttrs(); css::uno::Reference< css::uno::XComponentContext > getComponentContext() { return m_xContext;} @@ -364,7 +360,6 @@ public: const css::uno::Reference< css::xml::sax::XFastAttributeList > & Attribs) throw (css::uno::RuntimeException, css::xml::sax::SAXException, std::exception) SAL_OVERRIDE; - void newPropertySet(OOXMLPropertySet::Pointer_t pPropertySet); protected: OOXMLTableImpl mTable; |