diff options
| author | Moaz <moaz.eldefrawy@gmail.com> | 2021-02-25 15:52:06 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-03-05 08:36:52 +0100 |
| commit | dbbda04d52e75858840ce9748a19a61a1c565149 (patch) | |
| tree | 66c2d38ff6b0ef77dae47962050e93614b054db1 /writerperfect/qa | |
| parent | 5146d482a20494069670496786a1ba3037e979ce (diff) | |
tdf#139734 Remove redundant asserts after functions loadFromDesktop and load
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.
SwModelTestBase::load calls SwModelTestBase::loadURL which calls loadFromDesktop from within.
Change-Id: I30061bbc6e13e05f0cfbf17a7910926070b996f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111547
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'writerperfect/qa')
| -rw-r--r-- | writerperfect/qa/unit/EPUBExportTest.cxx | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/writerperfect/qa/unit/EPUBExportTest.cxx b/writerperfect/qa/unit/EPUBExportTest.cxx index d703c9fa61f6..c1769607605a 100644 --- a/writerperfect/qa/unit/EPUBExportTest.cxx +++ b/writerperfect/qa/unit/EPUBExportTest.cxx @@ -94,8 +94,6 @@ void EPUBExportTest::createDoc(std::u16string_view rFile, // Import the bugdoc and export as EPUB. OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + rFile; mxComponent = loadFromDesktop(aURL); - CPPUNIT_ASSERT(mxComponent.is()); - uno::Reference<frame::XStorable> xStorable(mxComponent, uno::UNO_QUERY); maTempFile.EnableKillingFile(); utl::MediaDescriptor aMediaDescriptor; |