summaryrefslogtreecommitdiff
path: root/writerperfect
diff options
context:
space:
mode:
authorCatalin Iacob <iacobcatalin@gmail.com>2012-02-23 12:57:22 +0000
committerMichael Meeks <michael.meeks@suse.com>2012-02-23 12:59:14 +0000
commitf881540b3295c17286f8003c7b897907bf9f57cb (patch)
treea9b5da15fc3b1aafa4fba700a91b523ec747fe70 /writerperfect
parent3b18642d62dad7128420f1d59f632acf5057da2b (diff)
cppcheck: fix "possible null dereference" in ScMyCellInfo::CreateCell.
Diffstat (limited to 'writerperfect')
0 files changed, 0 insertions, 0 deletions
d17d2fa66a27573ebc5a3624'>tdf#159422 - chart view: fix symbols position of data table legendBalazs Varga Calculate the correct/optimal row height after calculating and set correct width of a table cell. Then we will have the correct row height for the symbol positions. Change-Id: I65bc0f0579ea100906b0b32449c2200a54c2a353 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164512 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> 2022-09-15Add documentation for data table added classes and functionsTomaž Vajngerl Change-Id: Idc9756bf5b468d8ed0d11e6a75703d96350e1273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139960 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-22chart2: always use the series for the keys (symbols) in data tableTomaž Vajngerl In special case the legend keys are not series, but can be each value of a series. This can't be done for the data table where so this has been disabled. This caused a crash when positioning the symbols, as in some cases we got 0 symbols (due to another bug that didn't put the symbols into the collection) or more symbols that there were series (and the symbols couldn't be positioned correctly). With this change we now get the correct number of symbols for the data table. Also added the test document and test to open the document, to make sure we don't crash anymore. Change-Id: Idbebdd5295595a823b5420958e803b13258df035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138697 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-18chart2: improve keys (symbols) rendering in a data tableTomaž Vajngerl - better symbol positioning taking symbol height and cell height into account. - symbol height depends on font size (as with the legend) - take symbol aspect ratio into account - remove hardcoded values Change-Id: I3537d82538035cd31b928d4bb6fc5572914fcd13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-18chart2: convert the fill color only when style is "solid"Tomaž Vajngerl The CharBackColor should only be set when the fill style has the value "FillStyle_SOLID", otherwise don't set it as we can't handle any other fill style. Change-Id: Icaec8996d47966bb32bd8cf88b8c5aad70ab07a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138462 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: support data table rendering when the X axis is swappedTomaž Vajngerl In case when the X axis is swapped, so the Y axis is rendered in the place of X axis, we need to render the data table below the Y-axis labels. This is best done to put the data table into the Y-axis instead, so we get the correct size and position of the data table, and then just allow rendering of the axis labels and (re)position the table below Y-axis. Change-Id: I74aa79402a5638133b0d1ed83bbd8aad6f6c9d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138336 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: use the FillColor property as CharBackColorTomaž Vajngerl For chart data table, the fill is always setting the char background (highlight). As we don't support other fill types in LibreOffice for the char background, we can't set anything else when rendering. We need to extend editeng and UNO API with the support for this. Change-Id: I47d342e02ad2347bac0515a62cc0de4391f98150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138331 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: always set text props. of the first paragraph and not cellTomaž Vajngerl When setting the properties of the data table it is important to differentiate when we set the properties of the text of the (first and only) paragraph or set the properties for the current cell. In this chage we refactor the code so that we always set the text via UNO text::XText call for the current cell, and in the next step get the XPropertySet of the first paragraph and set the properties relevant for the text from the DataTable model. Change-Id: Ibe82b21c3416083cfe8e86b95443d77984da05f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: render line legend symbols better in a data tableTomaž Vajngerl Change-Id: I556b4f249688a3836bbeeb3f554cb9ecf1d31f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138301 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: fix rendering of table borders of row/column headersTomaž Vajngerl The row/column headers didn't enable/disable the table borders correctly when outline was enabled and horizontal and vertical borders properties were disabled. Change-Id: Ifcb059dd7d39890bbcaf55d3a68dce41eef586cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138300 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-16chart2: Data table rendering of keys (legend symbols)Tomaž Vajngerl Change-Id: Iff13b188df18fe8f9919274869774f53f2ea323b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138299 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-08-14chart2: allow to select the data table, fix object CIDTomaž Vajngerl Change-Id: I0a8d3643fcaefe8105e935b929947174bd9bdc96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138247 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-07-28chart2: set the char props. to the cells of a data table from modelTomaž Vajngerl This copies the char. properties from the model to the cells of a data table, so the correct char width, font is used for text when the table is rendered. Also add margin to the text, so it looks better. Change-Id: Ib74a8136459a31d64a86dec36a6ba14d2c313cf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-07-21chart2: apply line props. to borders when rendering a data tableTomaž Vajngerl This sets the color, line width, line style to the borders of the table when rendering the data table. We also need the ChartModel inside DataTableView, so we can access the needed line dashes. Change-Id: Id3bef23b75e88517d6569ad87a716f178ed64343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137158 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-07-18chart2: use {V,H}Border, Outline Data Table props. at renderingTomaž Vajngerl insert DataTable class into DataTableView, so it is possible to take the properties into account when rendering. Change rendering: VBorder - draw vert. border of data table HBorder - draw horiz. border of data table Outline - draw the outline borders of a data table Change-Id: I8348d0672d9c188014d664d667abddde8ebbc7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137155 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-07-17chart2: add initial code for rendering the Data TableTomaž Vajngerl Create a (svx) table with the data from the chart and place it below the x-axis line. Data table rendering is disabled in the code until the data table properties are available. Change-Id: I07d282c0b5e8df6b843516c8bdad538862d6575e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136788 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>