diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-04-07 10:02:18 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-04-09 20:51:44 +0200 |
| commit | eaf071397a1ff30536616f2ed76051f77fd38ed6 (patch) | |
| tree | ce55cdc75a0826c54b6b60458a028251f11fcb78 /xmlhelp | |
| parent | 1e79befa61a08de7a1ddaccb6c435dbb8015c063 (diff) | |
new loplugin:unnecessarygetstr
which prevents constructing unnecessary temporaries via getStr()
Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmlhelp')
| -rw-r--r-- | xmlhelp/source/cxxhelp/provider/urlparameter.cxx | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx index 6f92fae77db8..8859970980b9 100644 --- a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx +++ b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx @@ -737,14 +737,12 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam, parString[last++] = "System"; parString[last++] = "'" + urlParam->getByName( "System" ) + "'"; parString[last++] = "productname"; - parString[last++] = "'" + OString( - pDatabases->getProductName().getStr(), - pDatabases->getProductName().getLength(), + parString[last++] = "'" + OUStringToOString( + pDatabases->getProductName(), RTL_TEXTENCODING_UTF8 ) + "'"; parString[last++] = "productversion"; parString[last++] = "'" + - OString( pDatabases->getProductVersion().getStr(), - pDatabases->getProductVersion().getLength(), + OUStringToOString( pDatabases->getProductVersion(), RTL_TEXTENCODING_UTF8 ) + "'"; parString[last++] = "imgtheme"; @@ -829,9 +827,8 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam, OUString xslURL = pDatabases->getInstallPathAsURL(); - OString xslURLascii = OString( - xslURL.getStr(), - xslURL.getLength(), + OString xslURLascii = OUStringToOString( + xslURL, RTL_TEXTENCODING_UTF8) + "main_transform.xsl"; |