summaryrefslogtreecommitdiff
path: root/xmloff/source/draw/animimp.cxx
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2023-11-07 08:31:29 +0100
committerMiklos Vajna <vmiklos@collabora.com>2023-11-07 09:52:50 +0100
commit4f1121255ebac035a439d242b47c2f81124418c3 (patch)
treeb58dca862efb5178159d59c09c3f2f414d8eb31a /xmloff/source/draw/animimp.cxx
parentca650cad8fccc7eb27c300ffb7aa7d961c83dc56 (diff)
sw floattable, insert UI: fix default frame width when inserting a new one
Insert -> Frame -> Frame presented a dialog which stated the width of the new frame will be 2cm, but the width was ~zero. This is a regression from commit 9da7b1592e010928c26c43ee93b91cdd66403985 (sw: remove all uses of MM50 with (added) o3tl::toTwip, 2021-07-23). Previously the code worked because the 2cm was speficified as MM50*4 (283*4=1132 twips), and we compared this to the 2cm from the UI, which had no rounding errors (283.46456692913387*4=1134 twips), and this 1132 vs 1134 meant the dialog put the unchanged size to the output item set. Now we don't have rounding errors anymore, so we have 1134 everywhere, which means the dialog doesn't specify a default size, but no other code would do it, resulting in a frame with minimal width, which is clearly not wanted. Fix the problem by checking if this will be a new frame, and if so, the dialog should send the default size to the caller, even if the user didn't customize the size. This restores the lost 2cm default width while keeping the rounding improvements. This requires running the test in its own process, because the measurement unit is only loaded once from the config and the rounding error is not hit with the default inches. Change-Id: I9a5945fdd0e5cd64ff8bd84f95f11be5277b8d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159050 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
Diffstat (limited to 'xmloff/source/draw/animimp.cxx')
0 files changed, 0 insertions, 0 deletions