new loplugin:conststringfield

Look for const string fields which can be static, and
mostly convert them to OUStringLiteral

And add a getLength() method to OUStringLiteral to make
the transition easier.

Remove dead code in XclExpRoot::GenerateDefaultEncryptionData,
default password is never empty.

Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091
Reviewed-on: https://gerrit.libreoffice.org/59204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 10 insertions, 9 deletions

diff --git a/xmloff/source/script/XMLStarBasicContextFactory.cxx b/xmloff/source/script/XMLStarBasicContextFactory.cxx
index f849db55758d..7dd340b00301 100644
--- a/xmloff/source/script/XMLStarBasicContextFactory.cxx
+++ b/xmloff/source/script/XMLStarBasicContextFactory.cxx
@@ -33,11 +33,12 @@ using ::com::sun::star::uno::Reference;
 using ::com::sun::star::uno::Sequence;
 
 
-XMLStarBasicContextFactory::XMLStarBasicContextFactory() :
-    sEventType("EventType"),
-    sLibrary("Library"),
-    sMacroName("MacroName"),
-    sStarBasic("StarBasic")
+static const OUStringLiteral gsEventType("EventType");
+static const OUStringLiteral gsLibrary("Library");
+static const OUStringLiteral gsMacroName("MacroName");
+static const OUStringLiteral gsStarBasic("StarBasic");
+
+XMLStarBasicContextFactory::XMLStarBasicContextFactory()
 {
 }
 
@@ -95,15 +96,15 @@ SvXMLImportContext* XMLStarBasicContextFactory::CreateContext(
     Sequence<PropertyValue> aValues(3);
 
     // EventType
-    aValues[0].Name = sEventType;
-    aValues[0].Value <<= sStarBasic;
+    aValues[0].Name = gsEventType;
+    aValues[0].Value <<= OUString(gsStarBasic);
 
     // library name
-    aValues[1].Name = sLibrary;
+    aValues[1].Name = gsLibrary;
     aValues[1].Value <<= sLibraryVal;
 
     // macro name
-    aValues[2].Name = sMacroName;
+    aValues[2].Name = gsMacroName;
     aValues[2].Value <<= sMacroNameVal;
 
     // add values for event now