return nullptr from CreateChildContext methods in subclasses

the calling class handles this nicely, and also tells us when we are not
handling some part of the XML file

Change-Id: Ib64a704bc96bb4d6eff2d57116d62c9c15e25c6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 10 deletions

diff --git a/xmloff/source/text/XMLChangedRegionImportContext.cxx b/xmloff/source/text/XMLChangedRegionImportContext.cxx
index bf29d7390efd..44f68d98d2de 100644
--- a/xmloff/source/text/XMLChangedRegionImportContext.cxx
+++ b/xmloff/source/text/XMLChangedRegionImportContext.cxx
@@ -95,7 +95,7 @@ void XMLChangedRegionImportContext::StartElement(
 SvXMLImportContextRef XMLChangedRegionImportContext::CreateChildContext(
     sal_uInt16 nPrefix,
     const OUString& rLocalName,
-    const Reference<XAttributeList> & xAttrList)
+    const Reference<XAttributeList> & /*xAttrList*/)
 {
     SvXMLImportContextRef xContext;
 
@@ -121,16 +121,7 @@ SvXMLImportContextRef XMLChangedRegionImportContext::CreateChildContext(
     {
         // illegal element content! TODO: discard the redlines
         // for the moment -> use text
-
-        xContext = SvXMLImportContext::CreateChildContext(nPrefix, rLocalName,
-                                                          xAttrList);
-
         // or default if text fail
-        if (!xContext)
-        {
-            xContext = SvXMLImportContext::CreateChildContext(
-                nPrefix, rLocalName, xAttrList);
-        }
     }
 
     return xContext;