diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-30 15:34:35 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-30 18:54:44 +0200 |
commit | c90da566ed1026a70217ac8a52a90e5df5c3026e (patch) | |
tree | 2726d4fa022bc82918e6513b0a1fd213a7ac5cc4 /xmloff/source/transform/TransformerBase.cxx | |
parent | 4bef6511332073fbe3899fa2003caf88d9f2ac49 (diff) |
loplugin:returnconstant in xmloff
Change-Id: Ia837a93ae817df282096abb80efcbd6922867b25
Reviewed-on: https://gerrit.libreoffice.org/58335
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmloff/source/transform/TransformerBase.cxx')
-rw-r--r-- | xmloff/source/transform/TransformerBase.cxx | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/xmloff/source/transform/TransformerBase.cxx b/xmloff/source/transform/TransformerBase.cxx index fd0f3ea903e6..148230a179b1 100644 --- a/xmloff/source/transform/TransformerBase.cxx +++ b/xmloff/source/transform/TransformerBase.cxx @@ -633,8 +633,8 @@ XMLMutableAttributeList *XMLTransformerBase::ProcessAttrList( static_cast<sal_uInt16>( bRename ? (*aIter).second.m_nParam2 : (*aIter).second.m_nParam1); - if( AddNamespacePrefix( aAttrValue, nValPrefix ) ) - pMutableAttrList->SetValueByIndex( i, aAttrValue ); + AddNamespacePrefix( aAttrValue, nValPrefix ); + pMutableAttrList->SetValueByIndex( i, aAttrValue ); } break; case XML_ATACTION_ADD_APP_NAMESPACE_PREFIX: @@ -646,8 +646,8 @@ XMLMutableAttributeList *XMLTransformerBase::ProcessAttrList( nValPrefix = XML_NAMESPACE_OOOC; else if( IsXMLToken( GetClass(), XML_TEXT ) ) nValPrefix = XML_NAMESPACE_OOOW; - if( AddNamespacePrefix( aAttrValue, nValPrefix ) ) - pMutableAttrList->SetValueByIndex( i, aAttrValue ); + AddNamespacePrefix( aAttrValue, nValPrefix ); + pMutableAttrList->SetValueByIndex( i, aAttrValue ); } break; case XML_ATACTION_RENAME_REMOVE_NAMESPACE_PREFIX: @@ -1200,11 +1200,10 @@ bool XMLTransformerBase::NegPercent( OUString& rValue ) return bRet; } -bool XMLTransformerBase::AddNamespacePrefix( OUString& rName, +void XMLTransformerBase::AddNamespacePrefix( OUString& rName, sal_uInt16 nPrefix ) const { rName = GetNamespaceMap().GetQNameByKey( nPrefix, rName, false ); - return true; } bool XMLTransformerBase::RemoveNamespacePrefix( OUString& rName, |