use more concrete UNO types in some local vars

found by a little plugin I created.

Plugin parked into store/ folder because it needs hand-holding
when run.

Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins

3 files changed, 7 insertions, 11 deletions

diff --git a/xmloff/source/transform/FormPropOASISTContext.cxx b/xmloff/source/transform/FormPropOASISTContext.cxx
index 042b57ae07e5..8cee944e39f4 100644
--- a/xmloff/source/transform/FormPropOASISTContext.cxx
+++ b/xmloff/source/transform/FormPropOASISTContext.cxx
@@ -106,15 +106,14 @@ void XMLFormPropOASISTransformerContext::StartElement(
 
     rtl::Reference<XMLMutableAttributeList> pMutableAttrList =
         new XMLMutableAttributeList( rAttrList );
-    Reference< XAttributeList > xAttrList( pMutableAttrList );
 
     sal_Int16 nValueTypeAttr = -1;
     OUString aValue;
     bool bIsVoid = false;
-    sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
+    sal_Int16 nAttrCount = pMutableAttrList.is() ? pMutableAttrList->getLength() : 0;
     for( sal_Int16 i=0; i < nAttrCount; i++ )
     {
-        const OUString aAttrName = xAttrList->getNameByIndex( i );
+        const OUString aAttrName = pMutableAttrList->getNameByIndex( i );
         OUString aLocalName;
         sal_uInt16 nPrefix =
             GetTransformer().GetNamespaceMap().GetKeyByAttrName( aAttrName,
@@ -124,7 +123,7 @@ void XMLFormPropOASISTransformerContext::StartElement(
             pActions->find( aKey );
         if( aIter != pActions->end() )
         {
-            const OUString aAttrValue = xAttrList->getValueByIndex( i );
+            const OUString aAttrValue = pMutableAttrList->getValueByIndex( i );
             switch( (*aIter).second.m_nActionType )
             {
             case XML_ATACTION_RENAME:
@@ -178,12 +177,11 @@ void XMLFormPropOASISTransformerContext::StartElement(
                                 GetXMLToken( GetValueType( aValue ) ) );
 
     if( !m_bIsListValue )
-        XMLRenameElemTransformerContext::StartElement( xAttrList );
+        XMLRenameElemTransformerContext::StartElement( pMutableAttrList );
     if( m_bIsList )
         return;
 
     pMutableAttrList = new XMLMutableAttributeList;
-    xAttrList = pMutableAttrList;
     if( bIsVoid )
     {
         OUString aNewAttrQName(
@@ -197,7 +195,7 @@ void XMLFormPropOASISTransformerContext::StartElement(
         GetTransformer().GetNamespaceMap().GetQNameByKey(
                 XML_NAMESPACE_FORM, GetXMLToken( XML_PROPERTY_VALUE ) ) );
     GetTransformer().GetDocHandler()->startElement( aValueElemQName,
-                                                    xAttrList );
+                                                    pMutableAttrList );
     GetTransformer().GetDocHandler()->characters( aValue );
     GetTransformer().GetDocHandler()->endElement( aValueElemQName );
 }
diff --git a/xmloff/source/transform/FrameOOoTContext.cxx b/xmloff/source/transform/FrameOOoTContext.cxx
index 5054f94f1d1c..ff507e4dbbad 100644
--- a/xmloff/source/transform/FrameOOoTContext.cxx
+++ b/xmloff/source/transform/FrameOOoTContext.cxx
@@ -59,7 +59,6 @@ void XMLFrameOOoTransformerContext::StartElement(
 
     rtl::Reference<XMLMutableAttributeList> pFrameMutableAttrList =
         new XMLMutableAttributeList;
-    Reference< XAttributeList > xFrameAttrList( pFrameMutableAttrList );
 
     sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
     for( sal_Int16 i=0; i < nAttrCount; i++ )
@@ -91,7 +90,7 @@ void XMLFrameOOoTransformerContext::StartElement(
     }
 
     GetTransformer().GetDocHandler()->startElement( m_aElemQName,
-                                                    xFrameAttrList );
+                                                    Reference< XAttributeList >( pFrameMutableAttrList ) );
     XMLTransformerContext::StartElement( xAttrList );
 }
 
diff --git a/xmloff/source/transform/OOo2Oasis.cxx b/xmloff/source/transform/OOo2Oasis.cxx
index e29c43b7f1d5..749ad826141b 100644
--- a/xmloff/source/transform/OOo2Oasis.cxx
+++ b/xmloff/source/transform/OOo2Oasis.cxx
@@ -1046,7 +1046,6 @@ void XMLBodyTransformerContext_Impl::StartElement(
 
     rtl::Reference<XMLMutableAttributeList> pMutableAttrList =
         new XMLMutableAttributeList( rAttrList );
-    Reference< XAttributeList > xAttrList = pMutableAttrList;
     OUString aClass( GetTransformer().GetClass() );
     if( aClass.isEmpty() )
     {
@@ -1065,7 +1064,7 @@ void XMLBodyTransformerContext_Impl::StartElement(
     m_aClassQName = GetTransformer().GetNamespaceMap().GetQNameByKey(
                         XML_NAMESPACE_OFFICE, aClass );
     GetTransformer().GetDocHandler()->startElement( m_aClassQName,
-                                                    xAttrList );
+                                                    pMutableAttrList );
 }
 
 void XMLBodyTransformerContext_Impl::EndElement()