summaryrefslogtreecommitdiff
path: root/xmloff/source
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2019-07-20 15:14:06 +0100
committerCaolán McNamara <caolanm@redhat.com>2019-07-21 13:49:46 +0200
commitbac57f75cd18472167742e804d789ffbc43fa9a9 (patch)
tree241d7b8ae2b09c8b833814cd010b64df334c5f55 /xmloff/source
parent3c6b2b734a00f4844e0bfd5707d14fd4a3d279b0 (diff)
cid#1448305 silence Out-of-bounds access
Change-Id: I7a25cc0c30f06ec146bdc205c51d5cad70e713b1 Reviewed-on: https://gerrit.libreoffice.org/76014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'xmloff/source')
-rw-r--r--xmloff/source/style/XMLFontAutoStylePool.cxx5
1 files changed, 3 insertions, 2 deletions
diff --git a/xmloff/source/style/XMLFontAutoStylePool.cxx b/xmloff/source/style/XMLFontAutoStylePool.cxx
index d16997977f10..b89525f75442 100644
--- a/xmloff/source/style/XMLFontAutoStylePool.cxx
+++ b/xmloff/source/style/XMLFontAutoStylePool.cxx
@@ -617,7 +617,7 @@ OUString XMLFontAutoStylePool::embedFontFile(OUString const & fileUrl, OUString
propertySet->setPropertyValue( "MediaType", uno::makeAny( OUString( "application/x-font-ttf" ))); // TODO
for(;;)
{
- char buffer[ 4096 ];
+ sal_Int8 buffer[ 4096 ];
sal_uInt64 readSize;
sal_Bool eof;
if( file.isEndOfFile( &eof ) != osl::File::E_None )
@@ -636,7 +636,8 @@ OUString XMLFontAutoStylePool::embedFontFile(OUString const & fileUrl, OUString
}
if( readSize == 0 )
break;
- outputStream->writeBytes( uno::Sequence< sal_Int8 >( reinterpret_cast< const sal_Int8* >( buffer ), readSize ));
+ // coverity[overrun-buffer-arg : FALSE] - coverity has difficulty with css::uno::Sequence
+ outputStream->writeBytes(uno::Sequence<sal_Int8>(buffer, readSize));
}
outputStream->closeOutput();
if( storage.is() )