diff options
author | Armin Le Grand <alg@apache.org> | 2013-10-29 14:11:45 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2013-10-31 15:56:14 +0000 |
commit | 223f6b631c1b087754c0f9051fb55f029f2503ce (patch) | |
tree | 14582be2894a88d16c6b0debbc8491350f9a5cce /xmloff | |
parent | 9069e26d1fe1fbbe7bceab0bae8a186d8cdb47cc (diff) |
Resolves: #i123433# Detect pseudo-vertices at svg import...
unify svg:d handling, correct svg:d import for relative sub-polygons in svg
import; changed default for moveto writes for svg:d in ODF to absolute
(cherry picked from commit f15874d8f976f3874bdbcb53429eeefa65c28841)
Conflicts:
basegfx/inc/basegfx/polygon/b2dpolygontools.hxx
basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx
basegfx/inc/basegfx/polygon/b3dpolypolygontools.hxx
basegfx/source/polygon/b2dpolypolygontools.cxx
basegfx/source/polygon/b2dsvgpolypolygon.cxx
basegfx/source/polygon/b3dpolypolygontools.cxx
basegfx/source/tools/makefile.mk
basegfx/test/boxclipper.cxx
basegfx/test/clipstate.cxx
basegfx/test/genericclipper.cxx
canvas/source/tools/surfaceproxy.cxx
sdext/source/pdfimport/tree/drawtreevisiting.cxx
sdext/source/pdfimport/tree/writertreevisiting.cxx
xmloff/inc/xexptran.hxx
xmloff/source/draw/XMLImageMapContext.cxx
xmloff/source/draw/XMLImageMapExport.cxx
xmloff/source/draw/shapeexport2.cxx
xmloff/source/draw/shapeexport3.cxx
xmloff/source/draw/xexptran.cxx
xmloff/source/draw/ximp3dobject.cxx
xmloff/source/draw/ximpshap.cxx
xmloff/source/style/MarkerStyle.cxx
xmloff/source/text/XMLTextFrameContext.cxx
xmloff/source/text/txtparae.cxx
Change-Id: I5171b4a3559ea116bea45152e1f2685666463635
Diffstat (limited to 'xmloff')
-rw-r--r-- | xmloff/inc/xexptran.hxx | 78 | ||||
-rw-r--r-- | xmloff/source/draw/XMLImageMapContext.cxx | 35 | ||||
-rw-r--r-- | xmloff/source/draw/XMLImageMapExport.cxx | 63 | ||||
-rw-r--r-- | xmloff/source/draw/shapeexport.cxx | 302 | ||||
-rw-r--r-- | xmloff/source/draw/xexptran.cxx | 909 | ||||
-rw-r--r-- | xmloff/source/draw/ximp3dobject.cxx | 74 | ||||
-rw-r--r-- | xmloff/source/draw/ximpshap.cxx | 247 | ||||
-rw-r--r-- | xmloff/source/style/MarkerStyle.cxx | 151 | ||||
-rw-r--r-- | xmloff/source/text/XMLTextFrameContext.cxx | 62 | ||||
-rw-r--r-- | xmloff/source/text/txtparae.cxx | 118 |
10 files changed, 492 insertions, 1547 deletions
diff --git a/xmloff/inc/xexptran.hxx b/xmloff/inc/xexptran.hxx index 77944533de2b..2c8112adf360 100644 --- a/xmloff/inc/xexptran.hxx +++ b/xmloff/inc/xexptran.hxx @@ -93,79 +93,23 @@ public: class SdXMLImExViewBox { - OUString msString; - sal_Int32 mnX; - sal_Int32 mnY; - sal_Int32 mnW; - sal_Int32 mnH; + OUString msString; + double mfX; + double mfY; + double mfW; + double mfH; public: - SdXMLImExViewBox(sal_Int32 nX = 0L, sal_Int32 nY = 0L, sal_Int32 nW = 1000L, sal_Int32 nH = 1000L); + SdXMLImExViewBox(double fX = 0.0, double fY = 0.0, double fW = 1000.0, double fH = 1000.0); SdXMLImExViewBox(const OUString& rNew, const SvXMLUnitConverter& rConv); - sal_Int32 GetX() const { return mnX; } - sal_Int32 GetY() const { return mnY; } - sal_Int32 GetWidth() const { return mnW; } - sal_Int32 GetHeight() const { return mnH; } + double GetX() const { return mfX; } + double GetY() const { return mfY; } + double GetWidth() const { return mfW; } + double GetHeight() const { return mfH; } const OUString& GetExportString(); }; -class SdXMLImExPointsElement -{ - OUString msString; - com::sun::star::drawing::PointSequenceSequence maPoly; - -public: - SdXMLImExPointsElement(com::sun::star::drawing::PointSequence* pPoints, - const SdXMLImExViewBox& rViewBox, - const com::sun::star::awt::Point& rObjectPos, - const com::sun::star::awt::Size& rObjectSize, - // #96328# - const bool bClosed = true); - SdXMLImExPointsElement(const OUString& rNew, - const SdXMLImExViewBox& rViewBox, - const com::sun::star::awt::Point& rObjectPos, - const com::sun::star::awt::Size& rObjectSize, - const SvXMLUnitConverter& rConv); - - const OUString& GetExportString() const { return msString; } - const com::sun::star::drawing::PointSequenceSequence& GetPointSequenceSequence() const { return maPoly; } -}; - -class SdXMLImExSvgDElement -{ - OUString msString; - const SdXMLImExViewBox& mrViewBox; - bool mbIsClosed; - bool mbIsCurve; - bool mbRelative; - sal_Int32 mnLastX; - sal_Int32 mnLastY; - - com::sun::star::drawing::PolyPolygonBezierCoords maPoly; - -public: - SdXMLImExSvgDElement(const SdXMLImExViewBox& rViewBox, const SvXMLExport& rExport); - SdXMLImExSvgDElement(const OUString& rNew, - const SdXMLImExViewBox& rViewBox, - const com::sun::star::awt::Point& rObjectPos, - const com::sun::star::awt::Size& rObjectSize, - const SvXMLImport& rImport); - - void AddPolygon( - com::sun::star::drawing::PointSequence* pPoints, - com::sun::star::drawing::FlagSequence* pFlags, - const com::sun::star::awt::Point& rObjectPos, - const com::sun::star::awt::Size& rObjectSize, - bool bClosed = false); - - const OUString& GetExportString() const { return msString; } - bool IsClosed() const { return mbIsClosed; } - bool IsCurve() const { return mbIsCurve; } - const com::sun::star::drawing::PointSequenceSequence& GetPointSequenceSequence() const { return maPoly.Coordinates; } - const com::sun::star::drawing::FlagSequenceSequence& GetFlagSequenceSequence() const { return maPoly.Flags; } -}; - -#endif // INCLUDED_XMLOFF_INC_XEXPTRAN_HXX +#endif // _XEXPTRANSFORM_HXX /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/draw/XMLImageMapContext.cxx b/xmloff/source/draw/XMLImageMapContext.cxx index efa3b48c18ab..4601b0065108 100644 --- a/xmloff/source/draw/XMLImageMapContext.cxx +++ b/xmloff/source/draw/XMLImageMapContext.cxx @@ -26,7 +26,6 @@ #include <com/sun/star/container/XIndexContainer.hpp> #include <com/sun/star/lang/XMultiServiceFactory.hpp> #include <com/sun/star/drawing/PointSequenceSequence.hpp> - #include <com/sun/star/document/XEventsSupplier.hpp> #include <com/sun/star/awt/Rectangle.hpp> #include <xmloff/xmltoken.hxx> @@ -40,7 +39,8 @@ #include <xmloff/XMLEventsImportContext.hxx> #include "XMLStringBufferImportContext.hxx" #include <tools/debug.hxx> - +#include <basegfx/polygon/b2dpolygon.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> using namespace ::com::sun::star; using namespace ::xmloff::token; @@ -492,34 +492,31 @@ void XMLImageMapPolygonContext::ProcessAttribute( bValid = bViewBoxOK && bPointsOK; } -void XMLImageMapPolygonContext::Prepare( - Reference<XPropertySet> & rPropertySet) +void XMLImageMapPolygonContext::Prepare(Reference<XPropertySet> & rPropertySet) { // process view box - SdXMLImExViewBox aViewBox(sViewBoxString, - GetImport().GetMM100UnitConverter()); + SdXMLImExViewBox aViewBox(sViewBoxString, GetImport().GetMM100UnitConverter()); // get polygon sequence - awt::Point aPoint(aViewBox.GetX(), aViewBox.GetY()); - awt::Size aSize(aViewBox.GetWidth(), aViewBox.GetHeight()); - SdXMLImExPointsElement aPoints( sPointsString, aViewBox, aPoint, aSize, - GetImport().GetMM100UnitConverter() ); - PointSequenceSequence aPointSeqSeq = aPoints.GetPointSequenceSequence(); - - // only use first element of sequence-sequence - if (aPointSeqSeq.getLength() > 0) + basegfx::B2DPolygon aPolygon; + + if(basegfx::tools::importFromSvgPoints(aPolygon, sPointsString)) { - Any aAny; - aAny <<= aPointSeqSeq[0]; - rPropertySet->setPropertyValue(sPolygon, aAny); + if(aPolygon.count()) + { + com::sun::star::drawing::PointSequence aPointSequence; + uno::Any aAny; + + basegfx::tools::B2DPolygonToUnoPointSequence(aPolygon, aPointSequence); + aAny <<= aPointSequence; + rPropertySet->setPropertyValue(sPolygon, aAny); + } } // parent properties XMLImageMapObjectContext::Prepare(rPropertySet); } - - class XMLImageMapCircleContext : public XMLImageMapObjectContext { awt::Point aCenter; diff --git a/xmloff/source/draw/XMLImageMapExport.cxx b/xmloff/source/draw/XMLImageMapExport.cxx index c6e40115597a..2abba024f112 100644 --- a/xmloff/source/draw/XMLImageMapExport.cxx +++ b/xmloff/source/draw/XMLImageMapExport.cxx @@ -26,7 +26,6 @@ #include <com/sun/star/beans/XPropertySet.hpp> #include <com/sun/star/lang/XServiceInfo.hpp> #include <com/sun/star/container/XIndexContainer.hpp> - #include <com/sun/star/document/XEventsSupplier.hpp> #include <com/sun/star/awt/Rectangle.hpp> #include <com/sun/star/awt/Point.hpp> @@ -38,8 +37,8 @@ #include <xmloff/XMLEventExport.hxx> #include <xmloff/xmluconv.hxx> #include "xexptran.hxx" - - +#include <basegfx/polygon/b2dpolygon.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> using namespace ::com::sun::star; using namespace ::xmloff::token; @@ -314,8 +313,7 @@ void XMLImageMapExport::ExportCircle( aBuffer.makeStringAndClear() ); } -void XMLImageMapExport::ExportPolygon( - const Reference<XPropertySet> & rPropertySet) +void XMLImageMapExport::ExportPolygon(const Reference<XPropertySet> & rPropertySet) { // polygons get exported as bounding box, viewbox, and coordinate // pair sequence. The bounding box is always the entire image. @@ -325,52 +323,33 @@ void XMLImageMapExport::ExportPolygon( PointSequence aPoly; aAny >>= aPoly; - // get bounding box (assume top-left to be 0,0) - sal_Int32 nWidth = 0; - sal_Int32 nHeight = 0; - sal_Int32 nLength = aPoly.getLength(); - const struct awt::Point* pPointPtr = aPoly.getConstArray(); - for ( sal_Int32 i = 0; i < nLength; i++ ) - { - sal_Int32 nPolyX = pPointPtr->X; - sal_Int32 nPolyY = pPointPtr->Y; - - if ( nPolyX > nWidth ) - nWidth = nPolyX; - if ( nPolyY > nHeight ) - nHeight = nPolyY; - - pPointPtr++; - } - DBG_ASSERT(nWidth > 0, "impossible Polygon found"); - DBG_ASSERT(nHeight > 0, "impossible Polygon found"); + const basegfx::B2DPolygon aPolygon( + basegfx::tools::UnoPointSequenceToB2DPolygon( + aPoly)); + const basegfx::B2DRange aPolygonRange(aPolygon.getB2DRange()); // parameters svg:x, svg:y, svg:width, svg:height OUStringBuffer aBuffer; + mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, 0); - mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_X, - aBuffer.makeStringAndClear() ); + mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_X, aBuffer.makeStringAndClear() ); mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, 0); - mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_Y, - aBuffer.makeStringAndClear() ); - mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, nWidth); - mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_WIDTH, - aBuffer.makeStringAndClear() ); - mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, nHeight); - mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_HEIGHT, - aBuffer.makeStringAndClear() ); + mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_Y, aBuffer.makeStringAndClear() ); + mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, basegfx::fround(aPolygonRange.getWidth())); + mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_WIDTH, aBuffer.makeStringAndClear() ); + mrExport.GetMM100UnitConverter().convertMeasureToXML(aBuffer, basegfx::fround(aPolygonRange.getHeight())); + mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_HEIGHT, aBuffer.makeStringAndClear() ); // svg:viewbox - SdXMLImExViewBox aViewBox(0, 0, nWidth, nHeight); - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, - aViewBox.GetExportString()); + SdXMLImExViewBox aViewBox(0.0, 0.0, aPolygonRange.getWidth(), aPolygonRange.getHeight()); + mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, aViewBox.GetExportString()); // export point sequence - awt::Point aPoint(0, 0); - awt::Size aSize(nWidth, nHeight); - SdXMLImExPointsElement aPoints( &aPoly, aViewBox, aPoint, aSize ); - mrExport.AddAttribute( XML_NAMESPACE_DRAW, XML_POINTS, - aPoints.GetExportString()); + const OUString aPointString( + basegfx::tools::exportToSvgPoints( + aPolygon)); + + mrExport.AddAttribute(XML_NAMESPACE_DRAW, XML_POINTS, aPointString); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/draw/shapeexport.cxx b/xmloff/source/draw/shapeexport.cxx index 16f5d173b282..3a2a636027e1 100644 --- a/xmloff/source/draw/shapeexport.cxx +++ b/xmloff/source/draw/shapeexport.cxx @@ -20,6 +20,14 @@ #include <memory> #include <basegfx/matrix/b2dhommatrix.hxx> +#include <basegfx/matrix/b2dhommatrixtools.hxx> +#include <basegfx/matrix/b3dhommatrix.hxx> +#include <basegfx/point/b2dpoint.hxx> +#include <basegfx/polygon/b2dpolypolygon.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> +#include <basegfx/polygon/b3dpolypolygon.hxx> +#include <basegfx/polygon/b3dpolypolygontools.hxx> #include <basegfx/tuple/b2dtuple.hxx> #include <basegfx/vector/b3dvector.hxx> @@ -2119,8 +2127,6 @@ void XMLShapeExport::ImpExportPolygonShape( const uno::Reference< beans::XPropertySet > xPropSet(xShape, uno::UNO_QUERY); if(xPropSet.is()) { - sal_Bool bClosed(eShapeType == XmlShapeTypeDrawPolyPolygonShape - || eShapeType == XmlShapeTypeDrawClosedBezierShape); sal_Bool bBezier(eShapeType == XmlShapeTypeDrawClosedBezierShape || eShapeType == XmlShapeTypeDrawOpenBezierShape); @@ -2150,111 +2156,83 @@ void XMLShapeExport::ImpExportPolygonShape( { // get PolygonBezier uno::Any aAny( xPropSet->getPropertyValue("Geometry") ); - drawing::PolyPolygonBezierCoords* pSourcePolyPolygon = - (drawing::PolyPolygonBezierCoords*)aAny.getValue(); + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::UnoPolyPolygonBezierCoordsToB2DPolyPolygon(*(drawing::PolyPolygonBezierCoords*)aAny.getValue())); - if(pSourcePolyPolygon && pSourcePolyPolygon->Coordinates.getLength()) + if(aPolyPolygon.count()) { - sal_Int32 nOuterCnt(pSourcePolyPolygon->Coordinates.getLength()); - drawing::PointSequence* pOuterSequence = pSourcePolyPolygon->Coordinates.getArray(); - drawing::FlagSequence* pOuterFlags = pSourcePolyPolygon->Flags.getArray(); + // complex polygon shape, write as svg:d + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible - if(pOuterSequence && pOuterFlags) - { - // prepare svx:d element export - SdXMLImExSvgDElement aSvgDElement(aViewBox, GetExport()); - - for(sal_Int32 a(0L); a < nOuterCnt; a++) - { - drawing::PointSequence* pSequence = pOuterSequence++; - drawing::FlagSequence* pFlags = pOuterFlags++; - - if(pSequence && pFlags) - { - aSvgDElement.AddPolygon(pSequence, pFlags, - aPoint, aSize, bClosed); - } - } - - // write point array - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aSvgDElement.GetExportString()); - } + // write point array + mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aPolygonString); // write object now - SvXMLElementExport aOBJ(mrExport, XML_NAMESPACE_DRAW, XML_PATH, bCreateNewline, sal_True); + SvXMLElementExport aOBJ( + mrExport, + XML_NAMESPACE_DRAW, + XML_PATH, + bCreateNewline, + sal_True); - ImpExportDescription( xShape ); // #i68101# - ImpExportEvents( xShape ); - ImpExportGluePoints( xShape ); - ImpExportText( xShape ); } } else { // get non-bezier polygon uno::Any aAny( xPropSet->getPropertyValue("Geometry") ); - drawing::PointSequenceSequence* pSourcePolyPolygon = (drawing::PointSequenceSequence*)aAny.getValue(); + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::UnoPointSequenceSequenceToB2DPolyPolygon(*(drawing::PointSequenceSequence*)aAny.getValue())); - if(pSourcePolyPolygon && pSourcePolyPolygon->getLength()) + if(!aPolyPolygon.areControlPointsUsed() && 1 == aPolyPolygon.count()) { - sal_Int32 nOuterCnt(pSourcePolyPolygon->getLength()); - - if(1L == nOuterCnt && !bBezier) - { - // simple polygon shape, can be written as svg:points sequence - drawing::PointSequence* pSequence = pSourcePolyPolygon->getArray(); - if(pSequence) - { - SdXMLImExPointsElement aPoints(pSequence, aViewBox, aPoint, aSize, - // #96328# - bClosed); - - // write point array - mrExport.AddAttribute(XML_NAMESPACE_DRAW, XML_POINTS, aPoints.GetExportString()); - } - - // write object now - SvXMLElementExport aOBJ(mrExport, XML_NAMESPACE_DRAW, - bClosed ? XML_POLYGON : XML_POLYLINE , bCreateNewline, sal_True); - - ImpExportDescription( xShape ); // #i68101# - ImpExportEvents( xShape ); - ImpExportGluePoints( xShape ); - ImpExportText( xShape ); - } - else - { - // polypolygon or bezier, needs to be written as a svg:path sequence - drawing::PointSequence* pOuterSequence = pSourcePolyPolygon->getArray(); - if(pOuterSequence) - { - // prepare svx:d element export - SdXMLImExSvgDElement aSvgDElement(aViewBox, GetExport()); + // simple polygon shape, can be written as svg:points sequence + const basegfx::B2DPolygon aPolygon(aPolyPolygon.getB2DPolygon(0)); + const OUString aPointString(basegfx::tools::exportToSvgPoints(aPolygon)); - for(sal_Int32 a(0L); a < nOuterCnt; a++) - { - drawing::PointSequence* pSequence = pOuterSequence++; - if(pSequence) - { - aSvgDElement.AddPolygon(pSequence, 0L, aPoint, - aSize, bClosed); - } - } + // write point array + mrExport.AddAttribute(XML_NAMESPACE_DRAW, XML_POINTS, aPointString); - // write point array - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aSvgDElement.GetExportString()); - } + // write object now + SvXMLElementExport aOBJ( + mrExport, + XML_NAMESPACE_DRAW, + aPolygon.isClosed() ? XML_POLYGON : XML_POLYLINE, + bCreateNewline, + sal_True); + } + else + { + // complex polygon shape, write as svg:d + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible - // write object now - SvXMLElementExport aOBJ(mrExport, XML_NAMESPACE_DRAW, XML_PATH, bCreateNewline, sal_True); + // write point array + mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aPolygonString); - ImpExportDescription( xShape ); // #i68101# - ImpExportEvents( xShape ); - ImpExportGluePoints( xShape ); - ImpExportText( xShape ); - } + // write object now + SvXMLElementExport aOBJ( + mrExport, + XML_NAMESPACE_DRAW, + XML_PATH, + bCreateNewline, + sal_True); } } + + ImpExportDescription( xShape ); // #i68101# + ImpExportEvents( xShape ); + ImpExportGluePoints( xShape ); + ImpExportText( xShape ); } } @@ -2595,38 +2573,19 @@ void XMLShapeExport::ImpExportConnectorShape( if( xProps->getPropertyValue("PolyPolygonBezier") >>= aAny ) { // get PolygonBezier - drawing::PolyPolygonBezierCoords* pSourcePolyPolygon = - (drawing::PolyPolygonBezierCoords*)aAny.getValue(); + drawing::PolyPolygonBezierCoords* pSourcePolyPolygon = (drawing::PolyPolygonBezierCoords*)aAny.getValue(); if(pSourcePolyPolygon && pSourcePolyPolygon->Coordinates.getLength()) { - sal_Int32 nOuterCnt(pSourcePolyPolygon->Coordinates.getLength()); - drawing::PointSequence* pOuterSequence = pSourcePolyPolygon->Coordinates.getArray(); - drawing::FlagSequence* pOuterFlags = pSourcePolyPolygon->Flags.getArray(); - - if(pOuterSequence && pOuterFlags) - { - // prepare svx:d element export - awt::Point aPoint( 0, 0 ); - awt::Size aSize( 1, 1 ); - SdXMLImExViewBox aViewBox( 0, 0, 1, 1 ); - SdXMLImExSvgDElement aSvgDElement(aViewBox, GetExport()); - - for(sal_Int32 a(0L); a < nOuterCnt; a++) - { - drawing::PointSequence* pSequence = pOuterSequence++; - drawing::FlagSequence* pFlags = pOuterFlags++; - - if(pSequence && pFlags) - { - aSvgDElement.AddPolygon(pSequence, pFlags, - aPoint, aSize, sal_False ); - } - } - - // write point array - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aSvgDElement.GetExportString()); - } + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::UnoPolyPolygonBezierCoordsToB2DPolyPolygon( + *pSourcePolyPolygon)); + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible } } @@ -3440,104 +3399,45 @@ void XMLShapeExport::ImpExport3DShape( case XmlShapeTypeDraw3DLatheObject: case XmlShapeTypeDraw3DExtrudeObject: { - // write special 3DLathe/3DExtrude attributes + // write special 3DLathe/3DExtrude attributes, get 3D PolyPolygon as drawing::PolyPolygonShape3D aAny = xPropSet->getPropertyValue("D3DPolyPolygon3D"); drawing::PolyPolygonShape3D xPolyPolygon3D; aAny >>= xPolyPolygon3D; - // look for maximal values - double fXMin = 0; - double fXMax = 0; - double fYMin = 0; - double fYMax = 0; - sal_Bool bInit(sal_False); - sal_Int32 nOuterSequenceCount(xPolyPolygon3D.SequenceX.getLength()); - drawing::DoubleSequence* pInnerSequenceX = xPolyPolygon3D.SequenceX.getArray(); - drawing::DoubleSequence* pInnerSequenceY = xPolyPolygon3D.SequenceY.getArray(); - - sal_Int32 a; - for (a = 0; a < nOuterSequenceCount; a++) - { - sal_Int32 nInnerSequenceCount(pInnerSequenceX->getLength()); - double* pArrayX = pInnerSequenceX->getArray(); - double* pArrayY = pInnerSequenceY->getArray(); - - for(sal_Int32 b(0L); b < nInnerSequenceCount; b++) - { - double fX = *pArrayX++; - double fY = *pArrayY++; + // convert to 3D PolyPolygon + const basegfx::B3DPolyPolygon aPolyPolygon3D( + basegfx::tools::UnoPolyPolygonShape3DToB3DPolyPolygon( + xPolyPolygon3D)); - if(bInit) - { - if(fX > fXMax) - fXMax = fX; + // convert to 2D PolyPolygon using identity 3D transformation (just grep X and Y) + const basegfx::B3DHomMatrix aB3DHomMatrixFor2DConversion; + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::createB2DPolyPolygonFromB3DPolyPolygon( + aPolyPolygon3D, + aB3DHomMatrixFor2DConversion)); - if(fX < fXMin) - fXMin = fX; - - if(fY > fYMax) - fYMax = fY; - - if(fY < fYMin) - fYMin = fY; - } - else - { - fXMin = fXMax = fX; - fYMin = fYMax = fY; - bInit = sal_True; - } - } - - pInnerSequenceX++; - pInnerSequenceY++; - } + // get 2D range of it + const basegfx::B2DRange aPolyPolygonRange(aPolyPolygon.getB2DRange()); // export ViewBox - awt::Point aMinPoint(FRound(fXMin), FRound(fYMin)); - awt::Size aMaxSize(FRound(fXMax) - aMinPoint.X, FRound(fYMax) - aMinPoint.Y); SdXMLImExViewBox aViewBox( - aMinPoint.X, aMinPoint.Y, aMaxSize.Width, aMaxSize.Height); - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, - aViewBox.GetExportString()); + aPolyPolygonRange.getMinX(), + aPolyPolygonRange.getMinY(), + aPolyPolygonRange.getWidth(), + aPolyPolygonRange.getHeight()); - // prepare svx:d element export - SdXMLImExSvgDElement aSvgDElement(aViewBox, GetExport()); - pInnerSequenceX = xPolyPolygon3D.SequenceX.getArray(); - pInnerSequenceY = xPolyPolygon3D.SequenceY.getArray(); + mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, aViewBox.GetExportString()); - for (a = 0; a < nOuterSequenceCount; a++) - { - sal_Int32 nInnerSequenceCount(pInnerSequenceX->getLength()); - double* pArrayX = pInnerSequenceX->getArray(); - double* pArrayY = pInnerSequenceY->getArray(); - drawing::PointSequence aPoly(nInnerSequenceCount); - awt::Point* pInnerSequence = aPoly.getArray(); - - for(sal_Int32 b(0L); b < nInnerSequenceCount; b++) - { - double fX = *pArrayX++; - double fY = *pArrayY++; - - *pInnerSequence = awt::Point(FRound(fX), FRound(fY)); - pInnerSequence++; - } - - // calculate closed flag - awt::Point* pFirst = aPoly.getArray(); - awt::Point* pLast = pFirst + (nInnerSequenceCount - 1); - sal_Bool bClosed = (pFirst->X == pLast->X && pFirst->Y == pLast->Y); - - aSvgDElement.AddPolygon(&aPoly, 0L, aMinPoint, - aMaxSize, bClosed); - - // #80594# corrected error in PolyPolygon3D export for 3D XML - pInnerSequenceX++; - pInnerSequenceY++; - } + // prepare svg:d string + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers TTTT: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible // write point array - mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aSvgDElement.GetExportString()); + mrExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aPolygonString); if(eShapeType == XmlShapeTypeDraw3DLatheObject) { diff --git a/xmloff/source/draw/xexptran.cxx b/xmloff/source/draw/xexptran.cxx index 5f131251f6ee..dbc5cdbe9c4d 100644 --- a/xmloff/source/draw/xexptran.cxx +++ b/xmloff/source/draw/xexptran.cxx @@ -245,6 +245,13 @@ double Imp_GetDoubleChar(const OUString& rStr, sal_Int32& rPos, const sal_Int32 return fRetval; } +void Imp_PutDoubleChar(OUString& rStr, double fValue) +{ + OUStringBuffer sStringBuffer; + ::sax::Converter::convertDouble(sStringBuffer, fValue); + rStr += OUString(sStringBuffer.makeStringAndClear()); +} + void Imp_PutDoubleChar(OUString& rStr, const SvXMLUnitConverter& rConv, double fValue, bool bConvertUnits = false) { @@ -1206,21 +1213,21 @@ void SdXMLImExTransform3D::GetFullTransform(::basegfx::B3DHomMatrix& rFullTrans) } } -SdXMLImExViewBox::SdXMLImExViewBox(sal_Int32 nX, sal_Int32 nY, sal_Int32 nW, sal_Int32 nH) -: mnX( nX ), - mnY( nY ), - mnW( nW ), - mnH( nH ) +SdXMLImExViewBox::SdXMLImExViewBox(double fX, double fY, double fW, double fH) +: mfX( fX ), + mfY( fY ), + mfW( fW ), + mfH( fH ) { } // #100617# Asked vincent hardy: svg:viewBox values may be double precision. SdXMLImExViewBox::SdXMLImExViewBox(const OUString& rNew, const SvXMLUnitConverter& rConv) : msString(rNew), - mnX( 0L ), - mnY( 0L ), - mnW( 1000L ), - mnH( 1000L ) + mfX( 0.0 ), + mfY( 0.0 ), + mfW( 1000.0 ), + mfH( 1000.0 ) { if(!msString.isEmpty()) { @@ -1232,25 +1239,25 @@ SdXMLImExViewBox::SdXMLImExViewBox(const OUString& rNew, const SvXMLUnitConverte Imp_SkipSpaces(aStr, nPos, nLen); // get mX, #100617# be prepared for doubles - mnX = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)mnX)); + mfX = Imp_GetDoubleChar(aStr, nPos, nLen, rConv, mfX); // skip spaces and commas Imp_SkipSpacesAndCommas(aStr, nPos, nLen); // get mY, #100617# be prepared for doubles - mnY = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)mnY)); + mfY = Imp_GetDoubleChar(aStr, nPos, nLen, rConv, mfY); // skip spaces and commas Imp_SkipSpacesAndCommas(aStr, nPos, nLen); // get mW, #100617# be prepared for doubles - mnW = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)mnW)); + mfW = Imp_GetDoubleChar(aStr, nPos, nLen, rConv, mfW); // skip spaces and commas Imp_SkipSpacesAndCommas(aStr, nPos, nLen); // get mH, #100617# be prepared for doubles - mnH = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)mnH)); + mfH = Imp_GetDoubleChar(aStr, nPos, nLen, rConv, mfH); } } @@ -1259,16 +1266,16 @@ const OUString& SdXMLImExViewBox::GetExportString() OUString aNewString; OUString aEmptySpace(" "); - Imp_PutNumberChar(aNewString, mnX); + Imp_PutDoubleChar(aNewString, mfX); aNewString += aEmptySpace; - Imp_PutNumberChar(aNewString, mnY); + Imp_PutDoubleChar(aNewString, mfY); aNewString += aEmptySpace; - Imp_PutNumberChar(aNewString, mnW); + Imp_PutDoubleChar(aNewString, mfW); aNewString += aEmptySpace; - Imp_PutNumberChar(aNewString, mnH); + Imp_PutDoubleChar(aNewString, mfH); // set new string msString = aNewString; @@ -1276,872 +1283,4 @@ const OUString& SdXMLImExViewBox::GetExportString() return msString; } -SdXMLImExPointsElement::SdXMLImExPointsElement(drawing::PointSequence* pPoints, - const SdXMLImExViewBox& rViewBox, - const awt::Point& rObjectPos, - const awt::Size& rObjectSize, - // #96328# - const bool bClosed) -: maPoly( 0L ) -{ - DBG_ASSERT(pPoints, "Empty PointSequence handed over to SdXMLImExPointsElement(!)"); - - // add polygon to string - sal_Int32 nCnt(pPoints->getLength()); - - // #104076# Convert to string only when at last one point included - if(nCnt > 0) - { - OUString aNewString; - awt::Point* pArray = pPoints->getArray(); - - // last point same? Ignore it. - // #96328# ...but only when polygon is CLOSED - if(bClosed && (pArray->X == (pArray + (nCnt - 1))->X) && (pArray->Y == (pArray + (nCnt - 1))->Y)) - nCnt--; - - // object size and ViewBox size different? - bool bScale(rObjectSize.Width != rViewBox.GetWidth() - || rObjectSize.Height != rViewBox.GetHeight()); - bool bTranslate(rViewBox.GetX() != 0L || rViewBox.GetY() != 0L); - - for(sal_Int32 a(0L); a < nCnt; a++) - { - // prepare coordinates - sal_Int32 nX( pArray->X - rObjectPos.X ); - sal_Int32 nY( pArray->Y - rObjectPos.Y ); - - if(bScale && rObjectSize.Width && rObjectSize.Height) - { - nX = (nX * rViewBox.GetWidth()) / rObjectSize.Width; - nY = (nY * rViewBox.GetHeight()) / rObjectSize.Height; - } - - if(bTranslate) - { - nX += rViewBox.GetX(); - nY += rViewBox.GetY(); - } - - // X and comma - Imp_PutNumberChar(aNewString, nX); - aNewString += ","; - - // Y and space (not for last) - Imp_PutNumberChar(aNewString, nY); - if(a + 1 != nCnt) - aNewString += " "; - - // next point - pArray++; - } - - // set new string - msString = aNewString; - } -} - -// #100617# svg:polyline or svg:polygon values may be double precision. -SdXMLImExPointsElement::SdXMLImExPointsElement(const OUString& rNew, - const SdXMLImExViewBox& rViewBox, - const awt::Point& rObjectPos, - const awt::Size& rObjectSize, - const SvXMLUnitConverter& rConv) -: msString( rNew ), - maPoly( 0L ) -{ - // convert string to polygon - const OUString aStr(msString.getStr(), (sal_uInt16)msString.getLength()); - const sal_Int32 nLen(aStr.getLength()); - sal_Int32 nPos(0); - sal_Int32 nNumPoints(0L); - - // skip starting spaces - Imp_SkipSpaces(aStr, nPos, nLen); - - // count points in first loop - while(nPos < nLen) - { - // skip number, #100617# be prepared for doubles - Imp_SkipDouble(aStr, nPos, nLen); - - // skip spaces and commas - Imp_SkipSpacesAndCommas(aStr, nPos, nLen); - - // skip number, #100617# be prepared for doubles - Imp_SkipDouble(aStr, nPos, nLen); - - // skip spaces and commas - Imp_SkipSpacesAndCommas(aStr, nPos, nLen); - - // one more point - nNumPoints++; - } - - // second loop - if(nNumPoints) - { - nPos = 0; - maPoly.realloc(1); - drawing::PointSequence* pOuterSequence = maPoly.getArray(); - pOuterSequence->realloc(nNumPoints); - awt::Point* pInnerSequence = pOuterSequence->getArray(); - - // object size and ViewBox size different? - bool bScale(rObjectSize.Width != rViewBox.GetWidth() - || rObjectSize.Height != rViewBox.GetHeight()); - bool bTranslate(rViewBox.GetX() != 0L || rViewBox.GetY() != 0L); - - // skip starting spaces - Imp_SkipSpaces(aStr, nPos, nLen); - - while(nPos < nLen) - { - // prepare new parameter pair - sal_Int32 nX(0L); - sal_Int32 nY(0L); - - // get mX, #100617# be prepared for doubles - nX = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)nX)); - - // skip spaces and commas - Imp_SkipSpacesAndCommas(aStr, nPos, nLen); - - // get mY, #100617# be prepared for doubles - nY = FRound(Imp_GetDoubleChar(aStr, nPos, nLen, rConv, (double)nY)); - - // skip spaces and commas - Imp_SkipSpacesAndCommas(aStr, nPos, nLen); - - // prepare parameters - if(bTranslate) - { - nX -= rViewBox.GetX(); - nY -= rViewBox.GetY(); - } - - if(bScale && rViewBox.GetWidth() && rViewBox.GetHeight() ) - { - nX = (nX * rObjectSize.Width) / rViewBox.GetWidth(); - nY = (nY * rObjectSize.Height) / rViewBox.GetHeight(); - } - - nX += rObjectPos.X; - nY += rObjectPos.Y; - - // add new point - *pInnerSequence = awt::Point( nX, nY ); - pInnerSequence++; - } - } -} - -SdXMLImExSvgDElement::SdXMLImExSvgDElement(const SdXMLImExViewBox& rViewBox, - const SvXMLExport& rExport) -: mrViewBox( rViewBox ), - mbIsClosed( false ), - mbIsCurve( false ), - // fdo#47406 - handle writing svg:d path slightly different for - // old ODF versions and ODF1.2 compat mode - since ~all the legacy - // ODF ecosystem interprets relative svg:d paths incorrectly, - // write out absolute paths in those cases. - mbRelative( rExport.getDefaultVersion() >= SvtSaveOptions::ODFVER_012 && - rExport.getDefaultVersion() != SvtSaveOptions::ODFVER_012_EXT_COMPAT ), - mnLastX( 0L ), - mnLastY( 0L ), - maPoly() -{ -} - -void Imp_GetPrevPos(awt::Point*& pPrevPos1, - drawing::PolygonFlags& aPrevFlag1, - const bool bClosed, awt::Point* pPoints, - drawing::PolygonFlags* pFlags, const sal_Int32 nPos, - const sal_Int32 nCnt, const sal_Int32 nAdd) -{ - if(bClosed) - { - pPrevPos1 = pPoints + ((nPos + nCnt - nAdd) % nCnt); - aPrevFlag1 = *(pFlags + ((nPos + nCnt - nAdd) % nCnt)); - } - else if(nPos > (nAdd - 1)) - { - pPrevPos1 = pPoints + (nPos - nAdd); - aPrevFlag1 = *(pFlags + (nPos - nAdd)); - } - else - pPrevPos1 = 0L; -} - -void Imp_PrepareCoorExport(sal_Int32& nX, sal_Int32& nY, - const awt::Point* pPointArray, const awt::Point& rObjectPos, - const awt::Size& rObjectSize, const SdXMLImExViewBox& mrViewBox, - const bool bScale, const bool bTranslate) -{ - nX = pPointArray->X - rObjectPos.X; - nY = pPointArray->Y - rObjectPos.Y; - - if(bScale && rObjectSize.Width && rObjectSize.Height ) - { - nX = (nX * mrViewBox.GetWidth()) / rObjectSize.Width; - nY = (nY * mrViewBox.GetHeight()) / rObjectSize.Height; - } - - if(bTranslate) - { - nX += mrViewBox.GetX(); - nY += mrViewBox.GetY(); - } -} - -//#define TEST_QUADRATIC_CURVES -#ifdef TEST_QUADRATIC_CURVES -// To be able to test quadratic curve code: The code concerning to -// bDoTestHere can be used (see below). Construct shapes which have their control -// points on equal coordinates. When these are written, they can be -// forced to create correct 'Q' and 'T' statements using this flag. -// These may then be tested for import/exporting. -static bool bDoTestHere(true); -#endif // TEST_QUADRATIC_CURVES - -void SdXMLImExSvgDElement::AddPolygon( - drawing::PointSequence* pPoints, - drawing::FlagSequence* pFlags, - const awt::Point& rObjectPos, - const awt::Size& rObjectSize, - bool bClosed) -{ - // Leaving the export stuff for the while, should eventually also - // consolidated with basegfx svg support - DBG_ASSERT(pPoints, "Empty PointSequence handed over to SdXMLImExSvgDElement(!)"); - - sal_Int32 nCnt(pPoints->getLength()); - - // #104076# Convert to string only when at last one point included - if(nCnt > 0) - { - // append polygon to string - OUString aNewString; - sal_Unicode aLastCommand = ' '; - awt::Point* pPointArray = pPoints->getArray(); - - // are the flags used at all? If not forget about them - if(pFlags) - { - sal_Int32 nFlagCnt(pFlags->getLength()); - - if(nFlagCnt) - { - bool bFlagsUsed(false); - drawing::PolygonFlags* pFlagArray = pFlags->getArray(); - - for(sal_Int32 a(0); !bFlagsUsed && a < nFlagCnt; a++) - if(drawing::PolygonFlags_NORMAL != *pFlagArray++) - bFlagsUsed = true; - - if(!bFlagsUsed) - pFlags = 0L; - } - else - { - pFlags = 0L; - } - } - - // object size and ViewBox size different? - bool bScale(rObjectSize.Width != mrViewBox.GetWidth() - || rObjectSize.Height != mrViewBox.GetHeight()); - bool bTranslate(mrViewBox.GetX() != 0L || mrViewBox.GetY() != 0L); - - // #87202# rework of point reduction: - // Test for Last point same -> closed, ignore last point. Take - // some more circumstances in account when looking at curve segments. - drawing::PolygonFlags* pFlagArray = (pFlags) ? pFlags->getArray() : 0L; - - // #i121090# only reduce double start/end points if polygon *is* closed - if(bClosed && (pPointArray->X == (pPointArray + (nCnt - 1))->X) && (pPointArray->Y == (pPointArray + (nCnt - 1))->Y)) - { - if(pFlags) - { - // point needs to be ignored if point before it is - // NO control point. Else the last point is needed - // for exporting the last segment of the curve. That means - // that the last and the first point will be saved double, - // but SVG does not support a better solution here. - if(nCnt >= 2 && drawing::PolygonFlags_CONTROL != *(pFlagArray + (nCnt - 2))) - { - nCnt--; - } - } - else - { - // no curve, ignore last point - nCnt--; - } - } - - // bezier poly, handle curves - bool bDidWriteStart(false); - sal_Int32 nStartX(0), nStartY(0); - - for(sal_Int32 a(0L); a < nCnt; a++) - { - if(!pFlags || drawing::PolygonFlags_CONTROL != *pFlagArray++) - { - bool bDidWriteAsCurve(false); - - if(bDidWriteStart) - { - if(pFlags) - { - // real curve point, get previous to see if it's a control point - awt::Point* pPrevPos1; - drawing::PolygonFlags aPrevFlag1; - - Imp_GetPrevPos(pPrevPos1, aPrevFlag1, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 1); - - if(pPrevPos1 && drawing::PolygonFlags_CONTROL == aPrevFlag1) - { - // get previous2 to see if it's a control point, too - awt::Point* pPrevPos2; - drawing::PolygonFlags aPrevFlag2; - - Imp_GetPrevPos(pPrevPos2, aPrevFlag2, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 2); - - if(pPrevPos2 && drawing::PolygonFlags_CONTROL == aPrevFlag2) - { - // get previous3 to see if it's a curve point and if, - // if it is fully symmetric or not - awt::Point* pPrevPos3; - drawing::PolygonFlags aPrevFlag3; - - Imp_GetPrevPos(pPrevPos3, aPrevFlag3, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 3); - - if(pPrevPos3) - { - // prepare coordinates - sal_Int32 nX, nY; - - Imp_PrepareCoorExport(nX, nY, pPointArray, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - // #100617# test if this curve segment may be written as - // a quadratic bezier - // That's the case if both control points are in the same place - // when they are prolonged to the common quadratic control point - // Left: P = (3P1 - P0) / 2 - // Right: P = (3P2 - P3) / 2 - bool bIsQuadratic(false); - const bool bEnableSaveQuadratic(false); - - sal_Int32 nPX_L(FRound((double)((3 * pPrevPos2->X) - pPrevPos3->X) / 2.0)); - sal_Int32 nPY_L(FRound((double)((3 * pPrevPos2->Y) - pPrevPos3->Y) / 2.0)); - sal_Int32 nPX_R(FRound((double)((3 * pPrevPos1->X) - pPointArray->X) / 2.0)); - sal_Int32 nPY_R(FRound((double)((3 * pPrevPos1->Y) - pPointArray->Y) / 2.0)); - sal_Int32 nDist(0); - - if(nPX_L != nPX_R) - { - nDist += abs(nPX_L - nPX_R); - } - - if(nPY_L != nPY_R) - { - nDist += abs(nPY_L - nPY_R); - } - - if(nDist <= BORDER_INTEGERS_ARE_EQUAL) - { - if(bEnableSaveQuadratic) - { - bIsQuadratic = true; - } - } - -#ifdef TEST_QUADRATIC_CURVES - if(bDoTestHere) - { - bIsQuadratic = false; - - if(pPrevPos1->X == pPrevPos2->X && pPrevPos1->Y == pPrevPos2->Y) - bIsQuadratic = true; - } -#endif // TEST_QUADRATIC_CURVES - - if(bIsQuadratic) - { -#ifdef TEST_QUADRATIC_CURVES - if(bDoTestHere) - { - bool bPrevPointIsSymmetric(false); - - if(drawing::PolygonFlags_SYMMETRIC == aPrevFlag3) - { - // get previous4 to see if it's a control point - awt::Point* pPrevPos4; - drawing::PolygonFlags aPrevFlag4; - - Imp_GetPrevPos(pPrevPos4, aPrevFlag4, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 4); - - if(drawing::PolygonFlags_CONTROL == aPrevFlag4) - { - // okay, prevPos3 is symmetric (c2) and prevPos4 - // is existing control point, the 's' statement can be used - bPrevPointIsSymmetric = true; - } - } - - if(bPrevPointIsSymmetric) - { - // write a shorthand/smooth quadratic curveto entry (T) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('t')) - aNewString += "t"; - - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('t'); - } - else - { - if(aLastCommand != sal_Unicode('T')) - aNewString += "T"; - - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('T'); - } - } - else - { - // prepare coordinates - sal_Int32 nX1, nY1; - - Imp_PrepareCoorExport(nX1, nY1, pPrevPos1, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - // write a quadratic curveto entry (Q) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('q')) - aNewString += "q"; - - Imp_PutNumberCharWithSpace(aNewString, nX1 - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY1 - mnLastY); - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('q'); - } - else - { - if(aLastCommand != sal_Unicode('Q')) - aNewString += "Q"; - - Imp_PutNumberCharWithSpace(aNewString, nX1); - Imp_PutNumberCharWithSpace(aNewString, nY1); - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('Q'); - } - } - } - else - { -#endif // TEST_QUADRATIC_CURVES - awt::Point aNewPoint(nPX_L, nPY_L); - bool bPrevPointIsSmooth(false); - - if(drawing::PolygonFlags_SMOOTH == aPrevFlag3) - { - // get previous4 to see if it's a control point - awt::Point* pPrevPos4; - drawing::PolygonFlags aPrevFlag4; - - Imp_GetPrevPos(pPrevPos4, aPrevFlag4, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 4); - - if(drawing::PolygonFlags_CONTROL == aPrevFlag4) - { - // okay, prevPos3 is smooth (c1) and prevPos4 - // is existing control point. Test if it's even symmetric - // and thus the 'T' statement may be used. - ::basegfx::B2DVector aVec1(pPrevPos4->X - pPrevPos3->X, pPrevPos4->Y - pPrevPos3->Y); - ::basegfx::B2DVector aVec2(aNewPoint.X - pPrevPos3->X, aNewPoint.Y - pPrevPos3->Y); - bool bSameLength(false); - bool bSameDirection(false); - - // get vector values - Imp_CalcVectorValues(aVec1, aVec2, bSameLength, bSameDirection); - - if(bSameLength && bSameDirection) - bPrevPointIsSmooth = true; - } - } - - if(bPrevPointIsSmooth) - { - // write a shorthand/smooth quadratic curveto entry (T) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('t')) - aNewString += "t"; - - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('t'); - } - else - { - if(aLastCommand != sal_Unicode('T')) - aNewString += "T"; - - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('T'); - } - } - else - { - // prepare coordinates - sal_Int32 nX1, nY1; - - Imp_PrepareCoorExport(nX1, nY1, &aNewPoint, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - // write a quadratic curveto entry (Q) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('q')) - aNewString += "q"; - - Imp_PutNumberCharWithSpace(aNewString, nX1 - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY1 - mnLastY); - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('q'); - } - else - { - if(aLastCommand != sal_Unicode('Q')) - aNewString += "Q"; - - Imp_PutNumberCharWithSpace(aNewString, nX1); - Imp_PutNumberCharWithSpace(aNewString, nY1); - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('Q'); - } - } -#ifdef TEST_QUADRATIC_CURVES - } -#endif // TEST_QUADRATIC_CURVES - } - else - { - bool bPrevPointIsSymmetric(false); - - if(drawing::PolygonFlags_SYMMETRIC == aPrevFlag3) - { - // get previous4 to see if it's a control point - awt::Point* pPrevPos4; - drawing::PolygonFlags aPrevFlag4; - - Imp_GetPrevPos(pPrevPos4, aPrevFlag4, bClosed, pPoints->getArray(), - pFlags->getArray(), a, nCnt, 4); - - if(drawing::PolygonFlags_CONTROL == aPrevFlag4) - { - // okay, prevPos3 is symmetric (c2) and prevPos4 - // is existing control point, the 's' statement can be used - bPrevPointIsSymmetric = true; - } - } - - // prepare coordinates - sal_Int32 nX2, nY2; - - Imp_PrepareCoorExport(nX2, nY2, pPrevPos1, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - if(bPrevPointIsSymmetric) - { - // write a shorthand/smooth curveto entry (S) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('s')) - aNewString += "s"; - - Imp_PutNumberCharWithSpace(aNewString, nX2 - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY2 - mnLastY); - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('s'); - } - else - { - if(aLastCommand != sal_Unicode('S')) - aNewString += "S"; - - Imp_PutNumberCharWithSpace(aNewString, nX2); - Imp_PutNumberCharWithSpace(aNewString, nY2); - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('S'); - } - } - else - { - // prepare coordinates - sal_Int32 nX1, nY1; - - Imp_PrepareCoorExport(nX1, nY1, pPrevPos2, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - // write a curveto entry (C) - if(mbRelative) - { - if(aLastCommand != sal_Unicode('c')) - aNewString += "c"; - - Imp_PutNumberCharWithSpace(aNewString, nX1 - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY1 - mnLastY); - Imp_PutNumberCharWithSpace(aNewString, nX2 - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY2 - mnLastY); - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('c'); - } - else - { - if(aLastCommand != sal_Unicode('C')) - aNewString += "C"; - - Imp_PutNumberCharWithSpace(aNewString, nX1); - Imp_PutNumberCharWithSpace(aNewString, nY1); - Imp_PutNumberCharWithSpace(aNewString, nX2); - Imp_PutNumberCharWithSpace(aNewString, nY2); - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('C'); - } - } - } - - // remember that current point IS written - bDidWriteAsCurve = true; - - // remember new last position - mnLastX = nX; - mnLastY = nY; - } - } - } - } - } - - if(!bDidWriteAsCurve) - { - // current point not yet written, prepare coordinates - sal_Int32 nX, nY; - - Imp_PrepareCoorExport(nX, nY, pPointArray, rObjectPos, rObjectSize, - mrViewBox, bScale, bTranslate); - - if(bDidWriteStart) - { - // write as normal point - if(mnLastX == nX) - { - if(mbRelative) - { - if(aLastCommand != sal_Unicode('v')) - aNewString += "v"; - - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('v'); - } - else - { - if(aLastCommand != sal_Unicode('V')) - aNewString += "V"; - - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('V'); - } - } - else if(mnLastY == nY) - { - if(mbRelative) - { - if(aLastCommand != sal_Unicode('h')) - aNewString += "h"; - - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - - aLastCommand = sal_Unicode('h'); - } - else - { - if(aLastCommand != sal_Unicode('H')) - aNewString += "H"; - - Imp_PutNumberCharWithSpace(aNewString, nX); - - aLastCommand = sal_Unicode('H'); - } - } - else - { - if(mbRelative) - { - if(aLastCommand != sal_Unicode('l')) - aNewString += "l"; - - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('l'); - } - else - { - if(aLastCommand != sal_Unicode('L')) - aNewString += "L"; - - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('L'); - } - } - } - else - { - // write as start point - if(mbRelative) - { - aNewString += "m"; - - Imp_PutNumberCharWithSpace(aNewString, nX - mnLastX); - Imp_PutNumberCharWithSpace(aNewString, nY - mnLastY); - - aLastCommand = sal_Unicode('l'); - } - else - { - aNewString += "M"; - - Imp_PutNumberCharWithSpace(aNewString, nX); - Imp_PutNumberCharWithSpace(aNewString, nY); - - aLastCommand = sal_Unicode('L'); - } - - // remember start written - bDidWriteStart = true; - nStartX = nX; - nStartY = nY; - } - - // remember new last position - mnLastX = nX; - mnLastY = nY; - } - } - - // next point - pPointArray++; - } - - // close path if closed poly - if(bClosed) - { - if(mbRelative) - aNewString += "z"; - else - aNewString += "Z"; - - // update current point - we're back at the start - if( bDidWriteStart ) - { - mnLastX = nStartX; - mnLastY = nStartY; - } - } - - // append new string - msString += aNewString; - } -} - -SdXMLImExSvgDElement::SdXMLImExSvgDElement(const OUString& rNew, - const SdXMLImExViewBox& rViewBox, - const awt::Point& rObjectPos, - const awt::Size& rObjectSize, - const SvXMLImport& rImport) -: msString( rNew ), - mrViewBox( rViewBox ), - mbIsClosed( false ), - mbIsCurve( false ), - mbRelative( true ), - mnLastX( 0L ), - mnLastY( 0L ), - maPoly() -{ - bool bWrongPositionAfterZ( false ); - sal_Int32 nUPD( 0 ); - sal_Int32 nBuildId( 0 ); - if ( rImport.getBuildIds( nUPD, nBuildId ) && - ( ( nUPD == 641 ) || ( nUPD == 645 ) || ( nUPD == 680 ) || ( nUPD == 300 ) || - ( nUPD == 310 ) || ( nUPD == 320 ) || ( nUPD == 330 ) || ( nUPD == 340 ) || - ( nUPD == 350 && nBuildId < 202 ) ) ) - { - bWrongPositionAfterZ = true; - } - - // convert string to polygon - basegfx::B2DPolyPolygon aPoly; - basegfx::tools::importFromSvgD(aPoly,msString,bWrongPositionAfterZ); - - mbIsCurve = aPoly.areControlPointsUsed(); - mbIsClosed = aPoly.isClosed(); - - // object size and ViewBox size different? - basegfx::B2DHomMatrix aTransform; - const bool bScale(rObjectSize.Width != mrViewBox.GetWidth() - || rObjectSize.Height != mrViewBox.GetHeight()); - const bool bTranslate(mrViewBox.GetX() != 0L || mrViewBox.GetY() != 0L); - - if( bTranslate ) - aTransform.translate( - -mrViewBox.GetX(), - -mrViewBox.GetY()); - if( bScale ) - aTransform.scale( - (mrViewBox.GetWidth() ? rObjectSize.Width / mrViewBox.GetWidth() : 0), - (mrViewBox.GetHeight() ? rObjectSize.Height / mrViewBox.GetHeight() : 0)); - aTransform.translate( rObjectPos.X, rObjectPos.Y ); - aPoly.transform(aTransform); - - basegfx::unotools::b2DPolyPolygonToPolyPolygonBezier(aPoly,maPoly); -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/draw/ximp3dobject.cxx b/xmloff/source/draw/ximp3dobject.cxx index ae53e0a8a628..6992a12c2314 100644 --- a/xmloff/source/draw/ximp3dobject.cxx +++ b/xmloff/source/draw/ximp3dobject.cxx @@ -31,6 +31,9 @@ #include <xmloff/xmltoken.hxx> #include <com/sun/star/drawing/PolyPolygonShape3D.hpp> #include <com/sun/star/drawing/DoubleSequence.hpp> +#include <basegfx/polygon/b2dpolypolygon.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> +#include <basegfx/polygon/b3dpolypolygontools.hxx> using namespace ::com::sun::star; @@ -345,60 +348,37 @@ SdXML3DPolygonBasedShapeContext::~SdXML3DPolygonBasedShapeContext() void SdXML3DPolygonBasedShapeContext::StartElement(const uno::Reference< xml::sax::XAttributeList>& xAttrList) { uno::Reference< beans::XPropertySet > xPropSet(mxShape, uno::UNO_QUERY); + if(xPropSet.is()) { // set parameters if(!maPoints.isEmpty() && !maViewBox.isEmpty()) { - SdXMLImExViewBox aViewBox(maViewBox, GetImport().GetMM100UnitConverter()); - awt::Point aMinPoint(aViewBox.GetX(), aViewBox.GetY()); - awt::Size aMaxSize(aViewBox.GetWidth(), aViewBox.GetHeight()); - SdXMLImExSvgDElement aPoints(maPoints, aViewBox, aMinPoint, aMaxSize, GetImport()); - - // convert to double sequences - drawing::PointSequenceSequence& xPoSeSe = - (drawing::PointSequenceSequence&)aPoints.GetPointSequenceSequence(); - sal_Int32 nOuterSequenceCount = xPoSeSe.getLength(); - drawing::PointSequence* pInnerSequence = xPoSeSe.getArray(); - - drawing::PolyPolygonShape3D xPolyPolygon3D; - xPolyPolygon3D.SequenceX.realloc(nOuterSequenceCount); - xPolyPolygon3D.SequenceY.realloc(nOuterSequenceCount); - xPolyPolygon3D.SequenceZ.realloc(nOuterSequenceCount); - drawing::DoubleSequence* pOuterSequenceX = xPolyPolygon3D.SequenceX.getArray(); - drawing::DoubleSequence* pOuterSequenceY = xPolyPolygon3D.SequenceY.getArray(); - drawing::DoubleSequence* pOuterSequenceZ = xPolyPolygon3D.SequenceZ.getArray(); - - for(sal_Int32 a(0L); a < nOuterSequenceCount; a++) - { - sal_Int32 nInnerSequenceCount(pInnerSequence->getLength()); - awt::Point* pArray = pInnerSequence->getArray(); - - pOuterSequenceX->realloc(nInnerSequenceCount); - pOuterSequenceY->realloc(nInnerSequenceCount); - pOuterSequenceZ->realloc(nInnerSequenceCount); - double* pInnerSequenceX = pOuterSequenceX->getArray(); - double* pInnerSequenceY = pOuterSequenceY->getArray(); - double* pInnerSequenceZ = pOuterSequenceZ->getArray(); - - for(sal_Int32 b(0L); b < nInnerSequenceCount; b++) - { - *pInnerSequenceX++ = pArray->X; - *pInnerSequenceY++ = pArray->Y; - *pInnerSequenceZ++ = 0.0; - pArray++; - } - pInnerSequence++; + // import 2d PolyPolygon from svg:d + basegfx::B2DPolyPolygon aPolyPolygon; - pOuterSequenceX++; - pOuterSequenceY++; - pOuterSequenceZ++; + if(basegfx::tools::importFromSvgD(aPolyPolygon, maPoints, true, 0)) + { + // convert to 3D PolyPolygon + const basegfx::B3DPolyPolygon aB3DPolyPolygon( + basegfx::tools::createB3DPolyPolygonFromB2DPolyPolygon( + aPolyPolygon)); + + // convert to UNO API class PolyPolygonShape3D + drawing::PolyPolygonShape3D xPolyPolygon3D; + basegfx::tools::B3DPolyPolygonToUnoPolyPolygonShape3D( + aB3DPolyPolygon, + xPolyPolygon3D); + + // set polygon data + uno::Any aAny; + aAny <<= xPolyPolygon3D; + xPropSet->setPropertyValue(OUString("D3DPolyPolygon3D"), aAny); + } + else + { + OSL_ENSURE(false, "Error on importing svg:d for 3D PolyPolygon (!)"); } - - // set poly - uno::Any aAny; - aAny <<= xPolyPolygon3D; - xPropSet->setPropertyValue("D3DPolyPolygon3D", aAny); } // call parent diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx index ed9def807223..fcfb945c6378 100644 --- a/xmloff/source/draw/ximpshap.cxx +++ b/xmloff/source/draw/ximpshap.cxx @@ -76,7 +76,11 @@ #include <com/sun/star/drawing/XEnhancedCustomShapeDefaulter.hpp> #include <com/sun/star/container/XChild.hpp> #include <com/sun/star/text/XTextDocument.hpp> +#include <basegfx/matrix/b2dhommatrixtools.hxx> #include <basegfx/point/b2dpoint.hxx> +#include <basegfx/polygon/b2dpolygon.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> #include <basegfx/vector/b2dvector.hxx> using namespace ::com::sun::star; @@ -1280,20 +1284,45 @@ void SdXMLPolygonShapeContext::StartElement(const uno::Reference< xml::sax::XAtt // set polygon if(!maPoints.isEmpty() && !maViewBox.isEmpty()) { - SdXMLImExViewBox aViewBox(maViewBox, GetImport().GetMM100UnitConverter()); - awt::Size aSize(aViewBox.GetWidth(), aViewBox.GetHeight()); - if (maSize.Width != 0 && maSize.Height !=0) + const SdXMLImExViewBox aViewBox(maViewBox, GetImport().GetMM100UnitConverter()); + basegfx::B2DVector aSize(aViewBox.GetWidth(), aViewBox.GetHeight()); + + // Is this correct? It overrides ViewBox stuff; OTOH it makes no + // sense to have the geometry content size different from object size + if(maSize.Width != 0 && maSize.Height != 0) { - aSize = maSize; + aSize = basegfx::B2DVector(maSize.Width, maSize.Height); } - awt::Point aPosition(aViewBox.GetX(), aViewBox.GetY()); - SdXMLImExPointsElement aPoints(maPoints, aViewBox, - aPosition, aSize, GetImport().GetMM100UnitConverter()); - uno::Any aAny; - aAny <<= aPoints.GetPointSequenceSequence(); - xPropSet->setPropertyValue( - OUString("Geometry"), aAny); + basegfx::B2DPolygon aPolygon; + + if(basegfx::tools::importFromSvgPoints(aPolygon, maPoints)) + { + if(aPolygon.count()) + { + const basegfx::B2DRange aSourceRange( + aViewBox.GetX(), aViewBox.GetY(), + aViewBox.GetX() + aViewBox.GetWidth(), aViewBox.GetY() + aViewBox.GetHeight()); + const basegfx::B2DRange aTargetRange( + aViewBox.GetX(), aViewBox.GetY(), + aViewBox.GetX() + aSize.getX(), aViewBox.GetY() + aSize.getY()); + + if(!aSourceRange.equal(aTargetRange)) + { + aPolygon.transform( + basegfx::tools::createSourceRangeTargetRangeTransform( + aSourceRange, + aTargetRange)); + } + + com::sun::star::drawing::PointSequenceSequence aPointSequenceSequence; + uno::Any aAny; + + basegfx::tools::B2DPolyPolygonToUnoPointSequenceSequence(basegfx::B2DPolyPolygon(aPolygon), aPointSequenceSequence); + aAny <<= aPointSequenceSequence; + xPropSet->setPropertyValue(OUString("Geometry"), aAny); + } + } } } @@ -1346,84 +1375,110 @@ void SdXMLPathShapeContext::StartElement(const uno::Reference< xml::sax::XAttrib // create polygon shape if(!maD.isEmpty()) { - // prepare some of the parameters - SdXMLImExViewBox aViewBox(maViewBox, GetImport().GetMM100UnitConverter()); - awt::Size aSize(aViewBox.GetWidth(), aViewBox.GetHeight()); - awt::Point aPosition(aViewBox.GetX(), aViewBox.GetY()); - if (maSize.Width != 0 && maSize.Height !=0) - { - aSize = maSize; - } - SdXMLImExSvgDElement aPoints(maD, aViewBox, aPosition, aSize, GetImport()); + const SdXMLImExViewBox aViewBox(maViewBox, GetImport().GetMM100UnitConverter()); + basegfx::B2DVector aSize(aViewBox.GetWidth(), aViewBox.GetHeight()); - const char* pService; - // now create shape - if(aPoints.IsCurve()) + // Is this correct? It overrides ViewBox stuff; OTOH it makes no + // sense to have the geometry content size different from object size + if(maSize.Width != 0 && maSize.Height != 0) { - if(aPoints.IsClosed()) - { - pService = "com.sun.star.drawing.ClosedBezierShape"; - } - else - { - pService = "com.sun.star.drawing.OpenBezierShape"; - } - } - else - { - if(aPoints.IsClosed()) - { - pService = "com.sun.star.drawing.PolyPolygonShape"; - } - else - { - pService = "com.sun.star.drawing.PolyLineShape"; - } + aSize = basegfx::B2DVector(maSize.Width, maSize.Height); } - // Add, set Style and properties from base shape - AddShape(pService); + basegfx::B2DPolyPolygon aPolyPolygon; - // #89344# test for mxShape.is() and not for mxShapes.is() to support - // shape import helper classes WITHOUT XShapes (member mxShapes). This - // is used by the writer. - if( mxShape.is() ) + if(basegfx::tools::importFromSvgD(aPolyPolygon, maD, true, 0)) { - SetStyle(); - SetLayer(); - - // set local parameters on shape - uno::Reference< beans::XPropertySet > xPropSet(mxShape, uno::UNO_QUERY); - if(xPropSet.is()) + if(aPolyPolygon.count()) { - uno::Any aAny; + const basegfx::B2DRange aSourceRange( + aViewBox.GetX(), aViewBox.GetY(), + aViewBox.GetX() + aViewBox.GetWidth(), aViewBox.GetY() + aViewBox.GetHeight()); + const basegfx::B2DRange aTargetRange( + aViewBox.GetX(), aViewBox.GetY(), + aViewBox.GetX() + aSize.getX(), aViewBox.GetY() + aSize.getY()); - // set svg:d - if(!maD.isEmpty()) + if(!aSourceRange.equal(aTargetRange)) { - if(aPoints.IsCurve()) - { - drawing::PolyPolygonBezierCoords aSourcePolyPolygon( - aPoints.GetPointSequenceSequence(), - aPoints.GetFlagSequenceSequence()); + aPolyPolygon.transform( + basegfx::tools::createSourceRangeTargetRangeTransform( + aSourceRange, + aTargetRange)); + } - aAny <<= aSourcePolyPolygon; - xPropSet->setPropertyValue( - OUString("Geometry"), aAny); + // create shape + const char* pService; + + if(aPolyPolygon.areControlPointsUsed()) + { + if(aPolyPolygon.isClosed()) + { + pService = "com.sun.star.drawing.ClosedBezierShape"; } else { - aAny <<= aPoints.GetPointSequenceSequence(); - xPropSet->setPropertyValue( - OUString("Geometry"), aAny); + pService = "com.sun.star.drawing.OpenBezierShape"; + } + } + else + { + if(aPolyPolygon.isClosed()) + { + pService = "com.sun.star.drawing.PolyPolygonShape"; + } + else + { + pService = "com.sun.star.drawing.PolyLineShape"; } } - } - // set pos, size, shear and rotate - SetTransformation(); + // Add, set Style and properties from base shape + AddShape(pService); - SdXMLShapeContext::StartElement(xAttrList); + // #89344# test for mxShape.is() and not for mxShapes.is() to support + // shape import helper classes WITHOUT XShapes (member mxShapes). This + // is used by the writer. + if( mxShape.is() ) + { + SetStyle(); + SetLayer(); + + // set local parameters on shape + uno::Reference< beans::XPropertySet > xPropSet(mxShape, uno::UNO_QUERY); + + if(xPropSet.is()) + { + uno::Any aAny; + + // set polygon data + if(aPolyPolygon.areControlPointsUsed()) + { + drawing::PolyPolygonBezierCoords aSourcePolyPolygon; + + basegfx::tools::B2DPolyPolygonToUnoPolyPolygonBezierCoords( + aPolyPolygon, + aSourcePolyPolygon); + aAny <<= aSourcePolyPolygon; + } + else + { + drawing::PointSequenceSequence aSourcePolyPolygon; + + basegfx::tools::B2DPolyPolygonToUnoPointSequenceSequence( + aPolyPolygon, + aSourcePolyPolygon); + aAny <<= aSourcePolyPolygon; + } + + xPropSet->setPropertyValue(OUString("Geometry"), aAny); + } + + // set pos, size, shear and rotate + SetTransformation(); + + SdXMLShapeContext::StartElement(xAttrList); + } + } } } } @@ -1771,30 +1826,32 @@ void SdXMLConnectorShapeContext::processAttribute( sal_uInt16 nPrefix, const OUS } if( IsXMLToken( rLocalName, XML_D ) ) { - SdXMLImExViewBox aViewBox( 0, 0, 1, 1 ); - awt::Point aPoint( 0, 0 ); - awt::Size aSize( 1, 1 ); - - SdXMLImExSvgDElement aPoints( rValue, aViewBox, aPoint, aSize, GetImport() ); + basegfx::B2DPolyPolygon aPolyPolygon; - if ( aPoints.IsCurve() ) + if(basegfx::tools::importFromSvgD(aPolyPolygon, rValue, true, 0)) { - drawing::PolyPolygonBezierCoords aSourcePolyPolygon( - aPoints.GetPointSequenceSequence(), - aPoints.GetFlagSequenceSequence()); - maPath <<= aSourcePolyPolygon; - } - else - { - const drawing::PointSequenceSequence& rOuterSeq = aPoints.GetPointSequenceSequence(); - drawing::FlagSequenceSequence aFlagSeqSeq( rOuterSeq.getLength() ); - for ( int a = 0; a < rOuterSeq.getLength(); a++ ) - aFlagSeqSeq[ a ] = drawing::FlagSequence( rOuterSeq[ a ].getLength() ); + if(aPolyPolygon.count()) + { + // set polygon data + if(aPolyPolygon.areControlPointsUsed()) + { + drawing::PolyPolygonBezierCoords aSourcePolyPolygon; - drawing::PolyPolygonBezierCoords aSourcePolyPolygon( - aPoints.GetPointSequenceSequence(), - aFlagSeqSeq ); - maPath <<= aSourcePolyPolygon; + basegfx::tools::B2DPolyPolygonToUnoPolyPolygonBezierCoords( + aPolyPolygon, + aSourcePolyPolygon); + maPath <<= aSourcePolyPolygon; + } + else + { + drawing::PointSequenceSequence aSourcePolyPolygon; + + basegfx::tools::B2DPolyPolygonToUnoPointSequenceSequence( + aPolyPolygon, + aSourcePolyPolygon); + maPath <<= aSourcePolyPolygon; + } + } } } } @@ -3623,11 +3680,11 @@ void SdXMLCustomShapeContext::EndElement() if(bFlippedX) { - aNewPoroperty.Name = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("MirroredX")); + aNewPoroperty.Name = "MirroredX"; } else { - aNewPoroperty.Name = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("MirroredY")); + aNewPoroperty.Name = "MirroredY"; } aNewPoroperty.Handle = -1; diff --git a/xmloff/source/style/MarkerStyle.cxx b/xmloff/source/style/MarkerStyle.cxx index 125d411ab50c..b5f6fcdcdcd6 100644 --- a/xmloff/source/style/MarkerStyle.cxx +++ b/xmloff/source/style/MarkerStyle.cxx @@ -29,6 +29,9 @@ #include <rtl/ustrbuf.hxx> #include <rtl/ustring.hxx> #include <com/sun/star/drawing/PolyPolygonBezierCoords.hpp> +#include <basegfx/polygon/b2dpolypolygon.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> +#include <basegfx/matrix/b2dhommatrixtools.hxx> using namespace ::com::sun::star; @@ -92,40 +95,37 @@ sal_Bool XMLMarkerStyleImport::importXML( if( bHasViewBox && bHasPathData ) { - SdXMLImExSvgDElement aPoints(strPathData, *pViewBox, awt::Point( 0, 0 ), - awt::Size( pViewBox->GetWidth(), pViewBox->GetHeight() ), rImport ); + basegfx::B2DPolyPolygon aPolyPolygon; - if(aPoints.IsCurve()) + if(basegfx::tools::importFromSvgD(aPolyPolygon, strPathData, true, 0)) { - drawing::PolyPolygonBezierCoords aSourcePolyPolygon( - aPoints.GetPointSequenceSequence(), - aPoints.GetFlagSequenceSequence()); - rValue <<= aSourcePolyPolygon; - } - else - { - drawing::PolyPolygonBezierCoords aSourcePolyPolygon; - aSourcePolyPolygon.Coordinates = aPoints.GetPointSequenceSequence(); - aSourcePolyPolygon.Flags.realloc(aSourcePolyPolygon.Coordinates.getLength()); - - // Zeiger auf innere sequences holen - const drawing::PointSequence* pInnerSequence = aSourcePolyPolygon.Coordinates.getConstArray(); - drawing::FlagSequence* pInnerSequenceFlags = aSourcePolyPolygon.Flags.getArray(); - - for(sal_Int32 a(0); a < aSourcePolyPolygon.Coordinates.getLength(); a++) + if(aPolyPolygon.count()) { - pInnerSequenceFlags->realloc(pInnerSequence->getLength()); - drawing::PolygonFlags* pPolyFlags = pInnerSequenceFlags->getArray(); + // ViewBox probably not used, but stay with former processing inside of + // SdXMLImExSvgDElement + const basegfx::B2DRange aSourceRange( + pViewBox->GetX(), pViewBox->GetY(), + pViewBox->GetX() + pViewBox->GetWidth(), pViewBox->GetY() + pViewBox->GetHeight()); + const basegfx::B2DRange aTargetRange( + 0.0, 0.0, + pViewBox->GetWidth(), pViewBox->GetHeight()); + + if(!aSourceRange.equal(aTargetRange)) + { + aPolyPolygon.transform( + basegfx::tools::createSourceRangeTargetRangeTransform( + aSourceRange, + aTargetRange)); + } - for(sal_Int32 b(0); b < pInnerSequence->getLength(); b++) - *pPolyFlags++ = drawing::PolygonFlags_NORMAL; + // always use PolyPolygonBezierCoords here + drawing::PolyPolygonBezierCoords aSourcePolyPolygon; - // next run - pInnerSequence++; - pInnerSequenceFlags++; + basegfx::tools::B2DPolyPolygonToUnoPolyPolygonBezierCoords( + aPolyPolygon, + aSourcePolyPolygon); + rValue <<= aSourcePolyPolygon; } - - rValue <<= aSourcePolyPolygon; } if( !aDisplayName.isEmpty() ) @@ -134,7 +134,6 @@ sal_Bool XMLMarkerStyleImport::importXML( aDisplayName ); rStrName = aDisplayName; } - } if( pViewBox ) @@ -167,88 +166,44 @@ sal_Bool XMLMarkerStyleExport::exportXML( if(rValue >>= aBezier) { // Name - sal_Bool bEncoded = sal_False; + sal_Bool bEncoded(sal_False); OUString aStrName( rStrName ); - rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_NAME, - rExport.EncodeStyleName( aStrName, - &bEncoded ) ); - if( bEncoded ) - rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY_NAME, - aStrName ); - - // Viewbox (viewBox="0 0 1500 1000") - sal_Int32 nMinX(0x7fffffff); - sal_Int32 nMaxX(0x80000000); - sal_Int32 nMinY(0x7fffffff); - sal_Int32 nMaxY(0x80000000); - sal_Int32 nOuterCnt(aBezier.Coordinates.getLength()); - drawing::PointSequence* pOuterSequence = aBezier.Coordinates.getArray(); - sal_Int32 a, b; - sal_Bool bClosed(sal_False); - - for (a = 0; a < nOuterCnt; a++) - { - drawing::PointSequence* pSequence = pOuterSequence++; - const awt::Point *pPoints = pSequence->getConstArray(); - sal_Int32 nPointCount(pSequence->getLength()); - if(nPointCount) - { - const awt::Point aStart = pPoints[0]; - const awt::Point aEnd = pPoints[nPointCount - 1]; - - if(aStart.X == aEnd.X && aStart.Y == aEnd.Y) - { - bClosed = sal_True; - } - } + rExport.AddAttribute(XML_NAMESPACE_DRAW, XML_NAME, rExport.EncodeStyleName( aStrName, &bEncoded ) ); - for (b = 0; b < nPointCount; b++) - { - const awt::Point aPoint = pPoints[b]; - - if( aPoint.X < nMinX ) - nMinX = aPoint.X; - - if( aPoint.X > nMaxX ) - nMaxX = aPoint.X; - - if( aPoint.Y < nMinY ) - nMinY = aPoint.Y; - - if( aPoint.Y > nMaxY ) - nMaxY = aPoint.Y; - } + if( bEncoded ) + { + rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY_NAME, aStrName ); } - sal_Int32 nDifX(nMaxX - nMinX); - sal_Int32 nDifY(nMaxY - nMinY); + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::UnoPolyPolygonBezierCoordsToB2DPolyPolygon( + aBezier)); + const basegfx::B2DRange aPolyPolygonRange(aPolyPolygon.getB2DRange()); + + ///////////////// + // Viewbox (viewBox="0 0 1500 1000") - SdXMLImExViewBox aViewBox( 0, 0, nDifX, nDifY ); + SdXMLImExViewBox aViewBox( + aPolyPolygonRange.getMinX(), + aPolyPolygonRange.getMinY(), + aPolyPolygonRange.getWidth(), + aPolyPolygonRange.getHeight()); rExport.AddAttribute( XML_NAMESPACE_SVG, XML_VIEWBOX, aViewBox.GetExportString() ); // Pathdata - pOuterSequence = aBezier.Coordinates.getArray(); - drawing::FlagSequence* pOuterFlags = aBezier.Flags.getArray(); - SdXMLImExSvgDElement aSvgDElement(aViewBox, rExport); - - for (a = 0; a < nOuterCnt; a++) - { - drawing::PointSequence* pSequence = pOuterSequence++; - drawing::FlagSequence* pFlags = pOuterFlags++; - - aSvgDElement.AddPolygon(pSequence, pFlags, - awt::Point( 0, 0 ), - awt::Size( aViewBox.GetWidth(), aViewBox.GetHeight() ), - bClosed); - } + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible // write point array - rExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aSvgDElement.GetExportString()); + rExport.AddAttribute(XML_NAMESPACE_SVG, XML_D, aPolygonString); // Do Write - SvXMLElementExport rElem( rExport, XML_NAMESPACE_DRAW, XML_MARKER, - sal_True, sal_False ); + SvXMLElementExport rElem( rExport, XML_NAMESPACE_DRAW, XML_MARKER, sal_True, sal_False ); } } diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx index 7a0ca85574a7..a8edd774cf1b 100644 --- a/xmloff/source/text/XMLTextFrameContext.cxx +++ b/xmloff/source/text/XMLTextFrameContext.cxx @@ -47,12 +47,14 @@ #include <xmloff/XMLEventsImportContext.hxx> #include "XMLImageMapContext.hxx" #include "XMLTextFrameContext.hxx" - #include "XMLTextListBlockContext.hxx" #include "XMLTextListItemContext.hxx" #include <xmloff/attrlist.hxx> #include <comphelper/stl_types.hxx> - +#include <basegfx/polygon/b2dpolygon.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> +#include <basegfx/matrix/b2dhommatrixtools.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> #include <map> using namespace ::com::sun::star; @@ -283,31 +285,52 @@ XMLTextFrameContourContext_Impl::XMLTextFrameContourContext_Impl( } OUString sContourPolyPolygon("ContourPolyPolygon"); - Reference < XPropertySetInfo > xPropSetInfo = - rPropSet->getPropertySetInfo(); - if( xPropSetInfo->hasPropertyByName(sContourPolyPolygon ) && - nWidth > 0 && nHeight > 0 && bPixelWidth == bPixelHeight && - !(bPath ? sD : sPoints).isEmpty() ) + Reference < XPropertySetInfo > xPropSetInfo = rPropSet->getPropertySetInfo(); + + if(xPropSetInfo->hasPropertyByName(sContourPolyPolygon) && nWidth > 0 && nHeight > 0 && bPixelWidth == bPixelHeight && (bPath ? sD : sPoints).getLength()) { - awt::Point aPoint( 0, 0 ); - awt::Size aSize( nWidth, nHeight ); - SdXMLImExViewBox aViewBox( sViewBox, - GetImport().GetMM100UnitConverter()); + const SdXMLImExViewBox aViewBox( sViewBox, GetImport().GetMM100UnitConverter()); + basegfx::B2DPolyPolygon aPolyPolygon; Any aAny; + if( bPath ) { - SdXMLImExSvgDElement aPoints( sD, aViewBox, aPoint, aSize, GetImport() ); - aAny <<= aPoints.GetPointSequenceSequence(); + basegfx::tools::importFromSvgD(aPolyPolygon, sD, true, 0); } else { - SdXMLImExPointsElement aPoints( sPoints, aViewBox, aPoint, aSize, - GetImport().GetMM100UnitConverter() ); - aAny <<= aPoints.GetPointSequenceSequence(); + basegfx::B2DPolygon aPolygon; + + if(basegfx::tools::importFromSvgPoints(aPolygon, sPoints)) + { + aPolyPolygon = basegfx::B2DPolyPolygon(aPolygon); + } } - OUString sIsPixelContour("IsPixelContour"); - xPropSet->setPropertyValue( sContourPolyPolygon, aAny ); + if(aPolyPolygon.count()) + { + const basegfx::B2DRange aSourceRange( + aViewBox.GetX(), aViewBox.GetY(), + aViewBox.GetX() + aViewBox.GetWidth(), aViewBox.GetY() + aViewBox.GetHeight()); + const basegfx::B2DRange aTargetRange( + 0.0, 0.0, + nWidth, nHeight); + + if(!aSourceRange.equal(aTargetRange)) + { + aPolyPolygon.transform( + basegfx::tools::createSourceRangeTargetRangeTransform( + aSourceRange, + aTargetRange)); + } + + com::sun::star::drawing::PointSequenceSequence aPointSequenceSequence; + basegfx::tools::B2DPolyPolygonToUnoPointSequenceSequence(aPolyPolygon, aPointSequenceSequence); + aAny <<= aPointSequenceSequence; + xPropSet->setPropertyValue( sContourPolyPolygon, aAny ); + } + + const OUString sIsPixelContour("IsPixelContour"); if( xPropSetInfo->hasPropertyByName( sIsPixelContour ) ) { @@ -315,7 +338,8 @@ XMLTextFrameContourContext_Impl::XMLTextFrameContourContext_Impl( xPropSet->setPropertyValue( sIsPixelContour, aAny ); } - OUString sIsAutomaticContour("IsAutomaticContour"); + const OUString sIsAutomaticContour("IsAutomaticContour"); + if( xPropSetInfo->hasPropertyByName( sIsAutomaticContour ) ) { aAny.setValue( &bAuto, ::getBooleanCppuType() ); diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx index 877d714edcb8..bc9820944274 100644 --- a/xmloff/source/text/txtparae.cxx +++ b/xmloff/source/text/txtparae.cxx @@ -21,11 +21,9 @@ #include <tools/debug.hxx> #include <rtl/ustrbuf.hxx> #include <sal/types.h> - #include <vector> #include <list> #include <boost/unordered_map.hpp> - #include <com/sun/star/lang/XServiceInfo.hpp> #include <com/sun/star/container/XEnumerationAccess.hpp> #include <com/sun/star/container/XEnumeration.hpp> @@ -59,15 +57,12 @@ #include <com/sun/star/document/XEmbeddedObjectSupplier.hpp> #include <com/sun/star/document/XEventsSupplier.hpp> #include <com/sun/star/document/XRedlinesSupplier.hpp> - #include <com/sun/star/text/XBookmarksSupplier.hpp> #include <com/sun/star/text/XFormField.hpp> - #include <com/sun/star/text/XTextSection.hpp> #include <com/sun/star/text/SectionFileLink.hpp> #include <com/sun/star/drawing/XShape.hpp> #include <com/sun/star/text/XTextShapesSupplier.hpp> - #include <com/sun/star/style/XAutoStylesSupplier.hpp> #include <com/sun/star/style/XAutoStyleFamily.hpp> #include <com/sun/star/text/XTextFieldsSupplier.hpp> @@ -104,8 +99,10 @@ #include <xmloff/formlayerexport.hxx> #include "XMLTextCharStyleNamesElementExport.hxx" #include <comphelper/stlunosequence.hxx> - #include <xmloff/odffields.hxx> +#include <basegfx/polygon/b2dpolypolygon.hxx> +#include <basegfx/polygon/b2dpolypolygontools.hxx> +#include <basegfx/polygon/b2dpolygontools.hxx> #include <com/sun/star/embed/ElementModes.hpp> #include <com/sun/star/embed/XTransactedObject.hpp> #include <com/sun/star/document/XStorageBasedDocument.hpp> @@ -2964,38 +2961,29 @@ void XMLTextParagraphExport::_exportTextFrame( } void XMLTextParagraphExport::exportContour( - const Reference < XPropertySet > & rPropSet, - const Reference < XPropertySetInfo > & rPropSetInfo ) + const Reference < XPropertySet > & rPropSet, + const Reference < XPropertySetInfo > & rPropSetInfo ) { if( !rPropSetInfo->hasPropertyByName( sContourPolyPolygon ) ) + { return; + } PointSequenceSequence aSourcePolyPolygon; rPropSet->getPropertyValue( sContourPolyPolygon ) >>= aSourcePolyPolygon; + const basegfx::B2DPolyPolygon aPolyPolygon( + basegfx::tools::UnoPointSequenceSequenceToB2DPolyPolygon( + aSourcePolyPolygon)); + const sal_uInt32 nPolygonCount(aPolyPolygon.count()); - if( !aSourcePolyPolygon.getLength() ) - return; - - awt::Point aPoint( 0, 0 ); - awt::Size aSize( 0, 0 ); - sal_Int32 nPolygons = aSourcePolyPolygon.getLength(); - const PointSequence *pPolygons = aSourcePolyPolygon.getConstArray(); - while( nPolygons-- ) + if(!nPolygonCount) { - sal_Int32 nPoints = pPolygons->getLength(); - const awt::Point *pPoints = pPolygons->getConstArray(); - while( nPoints-- ) - { - if( aSize.Width < pPoints->X ) - aSize.Width = pPoints->X; - if( aSize.Height < pPoints->Y ) - aSize.Height = pPoints->Y; - pPoints++; - } - pPolygons++; + return; } - sal_Bool bPixel = sal_False; + const basegfx::B2DRange aPolyPolygonRange(aPolyPolygon.getB2DRange()); + bool bPixel(false); + if( rPropSetInfo->hasPropertyByName( sIsPixelContour ) ) { bPixel = *(sal_Bool *)rPropSet->getPropertyValue( sIsPixelContour ).getValue(); @@ -3003,77 +2991,59 @@ void XMLTextParagraphExport::exportContour( // svg: width OUStringBuffer aStringBuffer( 10 ); - if( bPixel ) + + if(bPixel) { - ::sax::Converter::convertMeasurePx(aStringBuffer, aSize.Width); + ::sax::Converter::convertMeasurePx(aStringBuffer, basegfx::fround(aPolyPolygonRange.getWidth())); } else { - GetExport().GetMM100UnitConverter().convertMeasureToXML( - aStringBuffer, aSize.Width); + GetExport().GetMM100UnitConverter().convertMeasureToXML(aStringBuffer, basegfx::fround(aPolyPolygonRange.getWidth())); } - GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_WIDTH, - aStringBuffer.makeStringAndClear() ); + + GetExport().AddAttribute(XML_NAMESPACE_SVG, XML_WIDTH, aStringBuffer.makeStringAndClear()); // svg: height - if( bPixel ) + if(bPixel) { - ::sax::Converter::convertMeasurePx(aStringBuffer, aSize.Height); + ::sax::Converter::convertMeasurePx(aStringBuffer, basegfx::fround(aPolyPolygonRange.getHeight())); } else { - GetExport().GetMM100UnitConverter().convertMeasureToXML( - aStringBuffer, aSize.Height); + GetExport().GetMM100UnitConverter().convertMeasureToXML(aStringBuffer, basegfx::fround(aPolyPolygonRange.getHeight())); } - GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_HEIGHT, - aStringBuffer.makeStringAndClear() ); - - // svg:viewbox - SdXMLImExViewBox aViewBox(0, 0, aSize.Width, aSize.Height); - GetExport().AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, - aViewBox.GetExportString()); - sal_Int32 nOuterCnt( aSourcePolyPolygon.getLength() ); + GetExport().AddAttribute(XML_NAMESPACE_SVG, XML_HEIGHT, aStringBuffer.makeStringAndClear()); + // svg:viewbox + SdXMLImExViewBox aViewBox(0.0, 0.0, aPolyPolygonRange.getWidth(), aPolyPolygonRange.getHeight()); + GetExport().AddAttribute(XML_NAMESPACE_SVG, XML_VIEWBOX, aViewBox.GetExportString()); enum XMLTokenEnum eElem = XML_TOKEN_INVALID; - if( 1L == nOuterCnt ) + + if(1 == nPolygonCount ) { // simple polygon shape, can be written as svg:points sequence - /*const*/ PointSequence* pSequence = - (PointSequence*)aSourcePolyPolygon.getConstArray(); - - SdXMLImExPointsElement aPoints( pSequence, aViewBox, aPoint, aSize ); + const OUString aPointString( + basegfx::tools::exportToSvgPoints( + aPolyPolygon.getB2DPolygon(0))); // write point array - GetExport().AddAttribute( XML_NAMESPACE_DRAW, XML_POINTS, - aPoints.GetExportString()); + GetExport().AddAttribute(XML_NAMESPACE_DRAW, XML_POINTS, aPointString); eElem = XML_CONTOUR_POLYGON; } else { // polypolygon, needs to be written as a svg:path sequence - /*const*/ PointSequence* pOuterSequence = - (PointSequence*)aSourcePolyPolygon.getConstArray(); - if(pOuterSequence) - { - // prepare svx:d element export - SdXMLImExSvgDElement aSvgDElement( aViewBox, GetExport() ); + const OUString aPolygonString( + basegfx::tools::exportToSvgD( + aPolyPolygon, + true, // bUseRelativeCoordinates + false, // bDetectQuadraticBeziers: not used in old, but maybe activated now + true)); // bHandleRelativeNextPointCompatible - for(sal_Int32 a(0L); a < nOuterCnt; a++) - { - /*const*/ PointSequence* pSequence = pOuterSequence++; - if(pSequence) - { - aSvgDElement.AddPolygon(pSequence, 0L, aPoint, - aSize, sal_True ); - } - } - - // write point array - GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_D, - aSvgDElement.GetExportString()); - eElem = XML_CONTOUR_PATH; - } + // write point array + GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_D, aPolygonString); + eElem = XML_CONTOUR_PATH; } if( rPropSetInfo->hasPropertyByName( sIsAutomaticContour ) ) |