diff options
author | Noel Grandin <noel@peralex.com> | 2015-01-20 12:38:10 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-01-26 08:42:28 +0200 |
commit | b44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch) | |
tree | 9b4d5d99e5dad0971079b997a02a6d96536709ca /xmloff | |
parent | 26ad60aec69310fecd918f1c2e09056aa4782320 (diff) |
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'xmloff')
-rw-r--r-- | xmloff/inc/txtvfldi.hxx | 4 | ||||
-rw-r--r-- | xmloff/source/core/DocumentSettingsContext.cxx | 2 | ||||
-rw-r--r-- | xmloff/source/core/DomExport.cxx | 20 | ||||
-rw-r--r-- | xmloff/source/forms/elementimport.hxx | 6 |
4 files changed, 16 insertions, 16 deletions
diff --git a/xmloff/inc/txtvfldi.hxx b/xmloff/inc/txtvfldi.hxx index 276dc9b303f6..3bd5b92e7d4a 100644 --- a/xmloff/inc/txtvfldi.hxx +++ b/xmloff/inc/txtvfldi.hxx @@ -87,11 +87,11 @@ public: virtual ~XMLValueImportHelper(); /// process attribute values - virtual void ProcessAttribute( sal_uInt16 nAttrToken, + void ProcessAttribute( sal_uInt16 nAttrToken, const OUString& sAttrValue ); /// prepare XTextField for insertion into document - virtual void PrepareField( + void PrepareField( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet> & xPropertySet); diff --git a/xmloff/source/core/DocumentSettingsContext.cxx b/xmloff/source/core/DocumentSettingsContext.cxx index 5e3fc42739e2..15e94ec5b4cb 100644 --- a/xmloff/source/core/DocumentSettingsContext.cxx +++ b/xmloff/source/core/DocumentSettingsContext.cxx @@ -162,7 +162,7 @@ public: virtual void EndElement() SAL_OVERRIDE; - virtual void ManipulateConfigItem(); + void ManipulateConfigItem(); }; class XMLConfigItemSetContext : public XMLConfigBaseContext diff --git a/xmloff/source/core/DomExport.cxx b/xmloff/source/core/DomExport.cxx index 87cc9393952e..f25e7c9fae76 100644 --- a/xmloff/source/core/DomExport.cxx +++ b/xmloff/source/core/DomExport.cxx @@ -63,16 +63,16 @@ public: virtual ~DomVisitor() {} virtual void element( const Reference<XElement>& ) {} virtual void character( const Reference<XCharacterData>& ) {} - virtual void attribute( const Reference<XAttr>& ) {} - virtual void cdata( const Reference<XCDATASection>& ) {} - virtual void comment( const Reference<XComment>& ) {} - virtual void documentFragment( const Reference<XDocumentFragment>& ) {} - virtual void document( const Reference<XDocument>& ) {} - virtual void documentType( const Reference<XDocumentType>& ) {} - virtual void entity( const Reference<XEntity>& ) {} - virtual void entityReference( const Reference<XEntityReference>& ) {} - virtual void notation( const Reference<XNotation>& ) {} - virtual void processingInstruction( const Reference<XProcessingInstruction>& ) {} + void attribute( const Reference<XAttr>& ) {} + void cdata( const Reference<XCDATASection>& ) {} + void comment( const Reference<XComment>& ) {} + void documentFragment( const Reference<XDocumentFragment>& ) {} + void document( const Reference<XDocument>& ) {} + void documentType( const Reference<XDocumentType>& ) {} + void entity( const Reference<XEntity>& ) {} + void entityReference( const Reference<XEntityReference>& ) {} + void notation( const Reference<XNotation>& ) {} + void processingInstruction( const Reference<XProcessingInstruction>& ) {} virtual void endElement( const Reference<XElement>& ) {} }; diff --git a/xmloff/source/forms/elementimport.hxx b/xmloff/source/forms/elementimport.hxx index b9f0c5466353..4d2592aadd8c 100644 --- a/xmloff/source/forms/elementimport.hxx +++ b/xmloff/source/forms/elementimport.hxx @@ -257,13 +257,13 @@ namespace xmloff virtual void doRegisterCellValueBinding( const OUString& _rBoundCellAddress ); /** register the given XForms binding */ - virtual void doRegisterXFormsValueBinding( const OUString& ); + void doRegisterXFormsValueBinding( const OUString& ); /** register the given XForms list binding */ - virtual void doRegisterXFormsListBinding( const OUString& ); + void doRegisterXFormsListBinding( const OUString& ); /** register the given XForms submission */ - virtual void doRegisterXFormsSubmission( const OUString& ); + void doRegisterXFormsSubmission( const OUString& ); protected: |